// Sprint-3-implement 1-is-proper-fraction.js all assertions and necessary functions added

Author: Mahtem

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -11,6 +11,18 @@ function isProperFraction(numerator, denominator) {
   if (numerator < denominator) {
     return true;
   }
+   else if (numerator > denominator){
+    return false;
+  }
+   else if (numerator === denominator) {
+    return false;
+  }
+   else if (numerator === 0){
+   retrurn (false);
+  }
+   else if (denominator === 0){
+    return (false);
+   }
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
@@ -46,14 +58,24 @@ assertEquals(improperFraction, false);
 // target output: true
 // Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
 const negativeFraction = isProperFraction(-4, 7);
-// ====> complete with your assertion
+assertEquals(negativeFraction, true);
 
 // Equal Numerator and Denominator check:
 // Input: numerator = 3, denominator = 3
 // target output: false
 // Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
 const equalFraction = isProperFraction(3, 3);
+assertEquals(equalFraction, false);
 // ====> complete with your assertion
 
 // Stretch:
 // What other scenarios could you test for?
+
+const numeratorZero = isProperFraction(0, 5);
+assertEquals(numeratorZero, true);
+
+const denominatorrZero = isProperFraction(5, 0);
+assertEquals(denominatorrZero, false);
+
+// Sprint-3-implement 1-is-proper-fraction.js all assertions and necessary functions added
+