chages are done for undified and test cases are updated

Author: shaghayeghfar

Sprint-3/2-practice-tdd/count.js

@@ -1,4 +1,14 @@
 function countChar(stringOfCharacters, findCharacter) {
+  if (
+    typeof stringOfCharacters !== "string" ||
+    typeof findCharacter !== "string"
+  ) {
+    return 0;
+  }
+  if (findCharacter.length !== 1) {
+    return 0;
+  }
+
   let count = 0;
   for (let i = 0; i < stringOfCharacters.length; i++) {
     if (stringOfCharacters[i] === findCharacter) {

Sprint-3/2-practice-tdd/count.test.js

@@ -51,16 +51,57 @@ test("should return 0 when the character does not exist in the string", () => {
   expect(count).toEqual(0);
 });
 
-test("should return 0 when the character does not exist in the string", () => {
-  const str = "hello";
-  const char = "z";
+test("should return 0 when the 'c' does not exist in string 'I dont have an apple'", () => {
+  const str = "I dont have an apple";
+  const char = "c";
   const count = countChar(str, char);
   expect(count).toEqual(0);
 });
 
-test("should return 0 when the 'c' does not exist in string 'I dont have an apple'", () => {
-  const str = "I dont have an apple";
-  const char = "c";
+// Scenario: Find character is longer than the input string
+// Given a string shorter than the findCharacter (e.g., 'a' vs 'abc'),
+// When the function is called,
+// Then it should return 0 because a multi-character string cannot match a single character position.
+
+test("should return 0 when findCharacter is longer than the input string", () => {
+  const str = "a";
+  const char = "abc";
+  const count = countChar(str, char);
+  expect(count).toEqual(0);
+});
+
+// Scenario: Empty string input
+// Given an empty input string and a valid character,
+// When the function is called,
+// Then it should return 0 because there are no characters to search.
+
+test("should return 0 when input string is empty", () => {
+  const str = "";
+  const char = "a";
+  const count = countChar(str, char);
+  expect(count).toEqual(0);
+});
+
+// Scenario: Non-string input type
+// Given that one or both inputs are not strings (e.g., number, array),
+// When the function is called,
+// Then it should return 0 or handle the input gracefully without throwing an error.
+
+test("should return 0 when inputs are not strings", () => {
+  const str = 12345;
+  const char = 1;
+  const count = countChar(str, char);
+  expect(count).toEqual(0);
+});
+
+// Scenario: Empty findCharacter
+// Given a valid string but an empty findCharacter,
+// When the function is called,
+// Then it should return 0 because an empty search target is not valid.
+
+test("should return 0 when findCharacter is an empty string", () => {
+  const str = "hello";
+  const char = "";
   const count = countChar(str, char);
   expect(count).toEqual(0);
 });

Sprint-3/2-practice-tdd/get-ordinal-number.js

@@ -1,14 +1,26 @@
 function getOrdinalNumber(number) {
-  if (number % 100 >= 11 && number % 100 <= 13) {
+  // Handle invalid inputs
+  if (typeof number !== "number" || !Number.isFinite(number)) {
+    return "Invalid input";
+  }
+
+  // Handle zero or negative numbers (optional)
+  if (number <= 0) {
     return number + "th";
-  } else {
-    const lastdigit = number.toString().slice(-1);
+  }
 
-    if (lastdigit == 1) return number + "st";
-    if (lastdigit == 2) return number + "nd";
-    if (lastdigit == 3) return number + "rd";
+  // Handle special 11–13 endings
+  if (number % 100 >= 11 && number % 100 <= 13) {
     return number + "th";
   }
+
+  // Get last digit to determine suffix
+  const lastDigit = number % 10;
+
+  if (lastDigit === 1) return number + "st";
+  if (lastDigit === 2) return number + "nd";
+  if (lastDigit === 3) return number + "rd";
+  return number + "th";
 }
 
 module.exports = getOrdinalNumber;

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

@@ -67,3 +67,35 @@ test("should return '20th' for 20", () => {
 test("should return '23rd' for 23", () => {
   expect(getOrdinalNumber(23)).toEqual("23rd");
 });
+
+// Case Undefind :
+// When the nymber is Undefind ,
+// Then the function should return "Invalid input"
+
+test("should return 'Invalid input' when input is undefined", () => {
+  expect(getOrdinalNumber(undefined)).toEqual("Invalid input");
+});
+
+// Case null :
+// When the nymber is null ,
+// Then the function should return "Invalid input"
+
+test("should return 'Invalid input' when input is null", () => {
+  expect(getOrdinalNumber(null)).toEqual("Invalid input");
+});
+
+// Case negetive number  :
+// When the number is negetive number ,
+// Then the function should return "-1th"
+
+test("should return '-1th' for -1", () => {
+  expect(getOrdinalNumber(-1)).toEqual("-1th");
+});
+
+// Case NaN input :
+// When the nymber is NaN  ,
+// Then the function should return "Invalid input"
+
+test("should return 'Invalid input' when input is NaN", () => {
+  expect(getOrdinalNumber(NaN)).toEqual("Invalid input");
+});

Sprint-3/2-practice-tdd/repeat.js

@@ -18,7 +18,6 @@ function repeat(str, count) {
     return "";
   }
 
-  // 5. Repeat the string count times
   let result = "";
   for (let i = 0; i < count; i++) {
     result += str;