Made small test with jest changes

Author: wankoak

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -10,7 +10,7 @@
 function getAngleType(angle) {
   if (angle === 90) {
     return "Right angle";
-  } else if (angle < 90 && angle > 0) {
+  } else if (angle < 90) {
     return "Acute angle";
   } else if (angle > 90 && angle < 180) {
     return "Obtuse angle";

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -8,17 +8,7 @@
 // write one test at a time, and make it pass, build your solution up methodically
 
 function isProperFraction(numerator, denominator) {
-  // Handle invalid denominators (e.g., divide by zero)
-  if (denominator === 0) {
-    return false;
-  }
-
-  // Compare absolute values for proper fraction check
-  if (Math.abs(numerator) < Math.abs(denominator)) {
-    return true;
-  } else {
-    return false;
-  }
+  return Math.abs(numerator) < Math.abs(denominator);
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -8,26 +8,20 @@
 // write one test at a time, and make it pass, build your solution up methodically
 // just make one change at a time -- don't rush -- programmers are deep and careful thinkers
 function getCardValue(card) {
-  // Extract rank (everything except the last character, which is the suit)
-  const rank = card.slice(0, -1);
+  let rank = card.slice(0, card.length - 1);
 
-  // Handle Ace
   if (rank === "A") {
     return 11;
-  }
 
-  // Handle Face Cards
-  if (["K", "Q", "J", "10"].includes(rank)) {
+  }  else if ((parseInt(rank) >= 2 && parseInt(rank)) && parseInt(rank) < 11){
+    return parseInt(rank)
+  }
+  else if( rank === "J" || rank === "Q" || rank === "K") {
     return 10;
   }
-
-  // Handle Number Cards (2–9)
-  if (!isNaN(rank) && Number(rank) >= 2 && Number(rank) <= 9) {
-    return Number(rank);
+  else{
+    throw  new Error("Invalid card rank.")
   }
-
-  // Handle invalid inputs
-  throw new Error("Invalid card rank");
 }
 
 // The line below allows us to load the getCardValue function into tests in other files.
@@ -62,32 +56,27 @@ assertEquals(fiveofHearts, 5);
 // Given a card with a rank of "10," "J," "Q," or "K",
 // When the function is called with such a card,
 // Then it should return the value 10, as these cards are worth 10 points each in blackjack.
-const jackOfDiamonds = getCardValue("J♦");
-assertEquals(jackOfDiamonds, 10);
-
-const queenOfClubs = getCardValue("Q♣");
-assertEquals(queenOfClubs, 10);
-
-const kingOfSpades = getCardValue("K♠");
-assertEquals(kingOfSpades, 10);
-
-const tenOfHearts = getCardValue("10♥");
-assertEquals(tenOfHearts, 10);
+const cardOfJ = getCardValue("J♥");
+assertEquals(cardOfJ, 10);
+const cardOfQ = getCardValue("Q♠");
+assertEquals(cardOfQ, 10);
+const cardOfK = getCardValue("K♠");
+assertEquals(cardOfK, 10);
 
 
 // Handle Ace (A):
 // Given a card with a rank of "A",
 // When the function is called with an Ace,
 // Then it should, by default, assume the Ace is worth 11 points, which is a common rule in blackjack.
-const aceofClubs = getCardValue("A♣");
-assertEquals(aceofClubs, 11);
+const aceOfHeart = getCardValue("A♥");
+assertEquals(aceOfHeart, 11);
 
 // Handle Invalid Cards:
 // Given a card with an invalid rank (neither a number nor a recognized face card),
 // When the function is called with such a card,
 // Then it should throw an error indicating "Invalid card rank."
 try {
-  getCardValue("X♣");
+  assertEquals(getCardValue("X♥"), "Invalid card rank");
 } catch (error) {
-  assertEquals(error.message, "Invalid card rank");
+  console.log(error.message);
 }

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -4,21 +4,19 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 
 test("should return true for a proper fraction", () => {
   expect(isProperFraction(2, 3)).toEqual(true);
-});
+}); 
 
 // Case 2: Identify Improper Fractions:
-test("should return false for an improper fraction (numerator > denominator)", () => {
-  expect(isProperFraction(5, 3)).toEqual(false);
+test("should return false for improper fraction", () => {
+  expect(isProperFraction(5, 2)).toEqual(false);
 });
 
 // Case 3: Identify Negative Fractions:
-test("should correctly handle negative fractions", () => {
-  expect(isProperFraction(-1, 3)).toEqual(true);
-  expect(isProperFraction(1, -3)).toEqual(true);
-  expect(isProperFraction(-4, 3)).toEqual(false);
+test("should return true for negative fraction", () => {
+  expect(isProperFraction(-4, 7)).toEqual(true);
 });
 
 // Case 4: Identify Equal Numerator and Denominator:
-test("should return false when numerator and denominator are equal", () => {
+test("should return false for Equal Numerator fraction", () => {
   expect(isProperFraction(3, 3)).toEqual(false);
 });

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -9,29 +9,25 @@ test("should return 11 for Ace of Spades", () => {
 
 // Case 2: Handle Number Cards (2-10):
 test("should return correct value for number cards", () => {
-  expect(getCardValue("2♥")).toEqual(2);
-  expect(getCardValue("5♦")).toEqual(5);
-  expect(getCardValue("9♣")).toEqual(9);
-  expect(getCardValue("10♠")).toEqual(10);
+  const fiveheart = getCardValue("5♥");
+  expect(fiveheart).toEqual(5);
 });
 
 // Case 3: Handle Face Cards (J, Q, K):
-test("should return 10 for face cards (J, Q, K)", () => {
-  expect(getCardValue("J♦")).toEqual(10);
-  expect(getCardValue("Q♥")).toEqual(10);
-  expect(getCardValue("K♣")).toEqual(10);
+test("Case 3: Handle Face Cards (J, Q, K)", () => {
+  const cardOfJ = getCardValue("J♥");
+  expect(cardOfJ).toEqual(10);
 });
 
 // Case 4: Handle Ace (A):
-test("should return 11 for Ace of any suit", () => {
-  expect(getCardValue("A♣")).toEqual(11);
-  expect(getCardValue("A♦")).toEqual(11);
-  expect(getCardValue("A♥")).toEqual(11);
+test("Case 4: Handle Face Cards (J, Q, K)", () => {
+  const aceOfHeart = getCardValue("A♥");
+  expect(aceOfHeart).toEqual(11);
 });
 
 // Case 5: Handle Invalid Cards:
-test("should throw an error for invalid card ranks", () => {
-  expect(() => getCardValue("X♣")).toThrow("Invalid card rank");
-  expect(() => getCardValue("1♠")).toThrow("Invalid card rank");
-  expect(() => getCardValue("Z♦")).toThrow("Invalid card rank");
+test("Case 5: Handle Invalid Cards", () => {
+  expect(() => {
+    getCardValue("21♠");
+  }).toThrow("Invalid card rank");
 });