wrote assertions for extra cases and updated the function accordingly

Author: alexandru-pocovnicu

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -8,11 +8,21 @@
 // write one test at a time, and make it pass, build your solution up methodically
 
 function isProperFraction(numerator, denominator) {
-  if (numerator < denominator) {
+  if (Math.abs(numerator) < Math.abs(denominator)) {
     return true;
   }
+  if (Math.abs(numerator) > Math.abs(denominator)) {
+    return false;
+  }
+  if (Math.abs(numerator) === Math.abs(denominator) ){
+    return false;
+  }
+  if (isNaN(numerator)|| isNaN(denominator)) {
+    return false;
+  }
 }
 
+
 // The line below allows us to load the isProperFraction function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.
 module.exports = isProperFraction;
@@ -46,14 +56,23 @@ assertEquals(improperFraction, false);
 // target output: true
 // Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
 const negativeFraction = isProperFraction(-4, 7);
+assertEquals(negativeFraction,true)
 // ====> complete with your assertion
 
 // Equal Numerator and Denominator check:
 // Input: numerator = 3, denominator = 3
 // target output: false
 // Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
 const equalFraction = isProperFraction(3, 3);
+assertEquals(equalFraction,false)
 // ====> complete with your assertion
 
 // Stretch:
 // What other scenarios could you test for?
+
+//Numerator or Denominator not a number
+//Input: numerator=NaN, denominator=3
+// target output: false
+// Explanation: the fraction NaN/3 is not a proper fraction because the numerator is not a number.The function should return false.
+const notANumberFraction=isProperFraction(NaN,3);
+assertEquals(notANumberFraction,false)