Skip to content

Commit ddf577d

Browse files
committed
update: fix password validation tests for minimum length, reused and missing symbol
1 parent 922ebf5 commit ddf577d

File tree

1 file changed

+16
-7
lines changed

1 file changed

+16
-7
lines changed

Sprint-3/4-stretch-investigate/password-validator.test.js

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,20 @@ test("password has at least 5 characters", () => {
2121
// Act
2222
const result = isValidPassword(password);
2323
// Assert
24-
expect(result).toEqual(true);
24+
expect(result).toEqual(false);
2525
});
26-
expect(result).toEqual(true);
27-
const isValidPassword = require("./password-validator");
28-
// // usage example
29-
// console.log(isValidPassword("Test123!")); // true
30-
// console.log(isValidPassword("pass")); // false (too short)
31-
// console.log(isValidPassword("password")); // false (no number or special character)
26+
27+
// TEST 4: Missing symbol
28+
// Should fail because there is no special character
29+
test("fails if missing symbol", () => {
30+
const password = "Hello123";
31+
const result = isValidPassword(password);
32+
expect(result).toEqual(false);
33+
});
34+
// TEST 6: Common/reused password (if your logic rejects common ones)
35+
// Should fail because the password is too common (if that rule is included)
36+
test("fails if reused/common password", () => {
37+
const password = "Password123!";
38+
const result = isValidPassword(password);
39+
expect(result).toEqual(false); // Update this only if your validator handles common passwords
40+
});

0 commit comments

Comments
 (0)