UPdate: fix isProperFraction function to handle negative numbers and add tests for zero numerator and denominator

Author: SuWebOnes

Sprint-3/1-key-implement/2-is-proper-fraction.js

@@ -8,7 +8,8 @@
 // write one test at a time, and make it pass, build your solution up methodically
 
 function isProperFraction(numerator, denominator) {
-    if (numerator < denominator) return true;
+  // if (numerator < denominator) return true; it will not work for negative numbers
+  return Math.abs(numerator) < Math.abs(denominator);
 }
 
 // here's our helper again
@@ -41,13 +42,28 @@ assertEquals(improperFraction, false);
 // Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
 const negativeFraction = isProperFraction(-4, 7);
 // ====> complete with your assertion
+assertEquals(negativeFraction, true);
 
 // Equal Numerator and Denominator check:
 // Input: numerator = 3, denominator = 3
 // target output: false
 // Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
 const equalFraction = isProperFraction(3, 3);
 // ====> complete with your assertion
-
+assertEquals(equalFraction, false);
 // Stretch:
 // What other scenarios could you test for?
+
+// Zero Numerator check:
+// Input: numerator = 0, denominator = 5
+// target output: true
+// Explanation: The fraction 0/5 is a proper fraction because the numerator (0) is less than the denominator (5). The function should return true.
+const zeroNumerator = isProperFraction(0, 5);
+assertEquals(zeroNumerator, true);
+
+// Zero Denominator check:
+// Input: numerator = 4, denominator = 0
+// target output: false
+// Explanation: A fraction with a zero denominator is undefined. The function should return false to indicate it's not a valid proper fraction.
+const zeroDenominator = isProperFraction(4, 0);
+assertEquals(zeroDenominator, false);