is-valid-triangle.js updated

Author: Grajales-K

Sprint-3/revise/implement/card-validator.js

@@ -1,26 +1,31 @@
 function cardValidator(num) {
-  const numStr = num.toString(); // Convert to string for iteration with this we can check the length and individual checks
-  if (numStr.length !== 16 || !/^[0-9]+$/.test(numStr) || numStr[numStr.length -1] % 2 === 1) {
-    console.log("I stopped because one of my condition is true")
-    return false; // Check length is 16 numbers long, if it only contains digits and if the last digits is even
+  const numStr = num.toString(); // Convert to string for iteration and validation
+
+  // Initial validation conditions:
+  if (
+    numStr.length !== 16 || // Must be exactly 16 digits long
+    !/^[0-9]+$/.test(numStr) || // Must contain only numbers
+    numStr[numStr.length - 1] % 2 === 1 || // Last digit must be even
+    numStr.split("").map(Number).reduce((acc, val) => acc + val, 0) <= 16 // Sum of digits must be greater than 16
+  ) {
+    console.log("I stopped because one of my conditions is true");
+    return false;
   }
 
-  let firstDigit = numStr[0]; // Track the first digit to compare with the rest digits
+  // Check if all digits are the same:
+  const firstDigit = numStr[0];
   for (let i = 1; i < numStr.length; i++) {
-  // console.log(`compare ${numStr[i]} con ${firstDigit} in position ${i}`);
-
     if (numStr[i] !== firstDigit) {
-      // console.log(`different digit found: ${numStr[i]}`);
       return true; // Found at least two different digits
     }
   }
-    // console.log("all digits are distint to same.");
+
   console.log(`The last digit (${numStr[numStr.length - 1]}) is odd, so the validation fails.`);
   return false; // All digits are the same
 }
 
-console.log(cardValidator(1111111111111111)); // Output: false and stop in the first return.
-console.log(cardValidator(1234567890123456)); // Output: true
-console.log(cardValidator(2222222222222222)); // Output: false
-console.log(cardValidator(3333333333333334)); // Output: true
-
+// Test cases:
+console.log(cardValidator(1111111111111111)); // Output: false (all digits are the same)
+console.log(cardValidator(1234567890123456)); // Output: true (valid card)
+console.log(cardValidator(2222222222222222)); // Output: false (all digits are the same)
+console.log(cardValidator(3333333333333334)); // Output: true (valid card)

Sprint-3/revise/implement/count.test.js

@@ -18,7 +18,7 @@
 
 
 function countChar(str, char) {
-
+    
     let findSameLetter = 0;
     for(let i = 0; i < str.length; i++){
         if(str[i] === char){