Edited incorrect test cases and fixed logic to ensure all tests pass successfully.

Author: ahmadehsas

Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.test.js

@@ -5,16 +5,19 @@ test("should return true for a proper fraction", () => {
 });
 
 // Case 2: Identify Improper Fractions:
-
-const improperFraction = isProperFraction(5, 2);
-assertEquals(improperFraction, false); // improper fraction is the fraction where the numerator is greater than or equal to the denominator.
+test("should return false for improper fractions", () => {
+  const improperFraction = isProperFraction(5, 2);
+  expect(improperFraction).toEqual(false);
+});
 
 // Case 3: Identify Negative Fractions:
-
-const negativeFraction = isProperFraction(-4, 7);
-assertEquals(negativeFraction, true); // negative fraction is the fraction where the absolute value of the numerator is less than the denominator.
+test("should return true for negative fractions", () => {
+  const negativeFraction = isProperFraction(-4, 7);
+  expect(negativeFraction).toEqual(true);
+});
 
 // Case 4: Identify Equal Numerator and Denominator:
-
-const equalFraction = isProperFraction(3, 3);
-assertEquals(equalFraction, false); // equal fraction is the fraction where the numerator is equal to the denominator.
+test("should return false for equal numerator and denominator", () => {
+  const equalFraction = isProperFraction(3, 3);
+  expect(equalFraction).toEqual(false);
+});

Sprint-3/2-mandatory-rewrite/3-get-card-value.js

@@ -1,4 +1,13 @@
 function getCardValue(card) {
+  const rank = card.slice(0, -1); // get the value part: A, 2–10, J, Q, K
+
   if (rank === "A") return 11;
+  if (["K", "Q", "J"].includes(rank)) return 10;
+
+  const number = parseInt(rank);
+  if (!isNaN(number) && number >= 2 && number <= 10) return number;
+
+  throw new Error("Invalid card");
 }
+
 module.exports = getCardValue;

Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js

@@ -5,23 +5,30 @@ test("should return 11 for Ace of Spades", () => {
   expect(aceofSpades).toEqual(11);
 });
 
-const aceofSpades = getCardValue("A♠");
-assertEquals(aceofSpades, 11);
-
-const fiveofHearts = getCardValue("5♥");
-assertEquals(fiveofHearts, 5);
+test("should return 5 for 5 of Hearts", () => {
+  const fiveofHearts = getCardValue("5♥");
+  expect(fiveofHearts).toEqual(5);
+});
 
-const tenofDiamonds = getCardValue("10♦");
-assertEquals(tenofDiamonds, 10);
+test("should return 10 for 10 of Diamonds", () => {
+  const tenofDiamonds = getCardValue("10♦");
+  expect(tenofDiamonds).toEqual(10);
+});
 
-const jackofClubs = getCardValue("J♣");
-assertEquals(jackofClubs, 10);
+test("should return 10 for Jack of Clubs", () => {
+  const jackofClubs = getCardValue("J♣");
+  expect(jackofClubs).toEqual(10);
+});
 
-const queenofHearts = getCardValue("Q♥");
-assertEquals(queenofHearts, 10);
+test("should return 10 for Queen of Hearts", () => {
+  const queenofHearts = getCardValue("Q♥");
+  expect(queenofHearts).toEqual(10);
+});
 
-const kingofSpades = getCardValue("K♠");
-assertEquals(kingofSpades, 10);
+test("should return 10 for King of Spades", () => {
+  const kingofSpades = getCardValue("K♠");
+  expect(kingofSpades).toEqual(10);
+});
 
 try {
   getCardValue("Z♠");