Skip to content

Commit 37f34dd

Browse files
committed
Remove gpt-5 from base2-max. Use editor with gpt-5, selector is sonnet.
1 parent fc5b2d6 commit 37f34dd

File tree

3 files changed

+134
-287
lines changed

3 files changed

+134
-287
lines changed

.agents/base2/base2.ts

Lines changed: 9 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -29,17 +29,11 @@ export function createBase2(
2929
const isFast = mode === 'fast'
3030
const isMax = mode === 'max'
3131

32-
const isGpt5 = isMax
33-
const isSonnet = isDefault
32+
const isSonnet = true
3433

3534
return {
3635
publisher,
37-
model: isGpt5 ? 'openai/gpt-5.1' : 'anthropic/claude-sonnet-4.5',
38-
...(isGpt5 && {
39-
reasoningOptions: {
40-
effort: 'high',
41-
},
42-
}),
36+
model: 'anthropic/claude-sonnet-4.5',
4337
displayName: 'Buffy the Orchestrator',
4438
spawnerPrompt:
4539
'Advanced base agent that orchestrates planning, editing, and reviewing for complex coding tasks',
@@ -67,7 +61,6 @@ export function createBase2(
6761
!isFast && 'write_todos',
6862
'str_replace',
6963
'write_file',
70-
isGpt5 && 'task_completed',
7164
),
7265
spawnableAgents: buildArray(
7366
'file-picker',
@@ -80,12 +73,11 @@ export function createBase2(
8073
withDecisionMaker && 'decision-maker',
8174
withImplementorGpt5 && 'editor-implementor-gpt-5',
8275
isDefault && !withImplementorGpt5 && 'editor-best-of-n',
83-
isGpt5 && !withImplementorGpt5 && 'editor-best-of-n-gpt-5',
76+
isMax && !withImplementorGpt5 && 'editor-best-of-n-gpt-5',
8477
isDefault && 'thinker-best-of-n',
85-
isGpt5 && 'thinker-best-of-n-gpt-5',
86-
hasCodeReviewer && (isGpt5 ? 'code-reviewer-gpt-5' : 'code-reviewer'),
87-
hasCodeReviewerBestOfN &&
88-
(isGpt5 ? 'code-reviewer-best-of-n-gpt-5' : 'code-reviewer-best-of-n'),
78+
isMax && 'thinker-best-of-n-gpt-5',
79+
hasCodeReviewer && 'code-reviewer',
80+
hasCodeReviewerBestOfN && 'code-reviewer-best-of-n',
8981
'context-pruner',
9082
),
9183

@@ -136,7 +128,7 @@ Use the spawn_agents tool to spawn specialized agents to help you complete the u
136128
${buildArray(
137129
'- Spawn context-gathering agents (file pickers, code-searcher, directory-lister, glob-matcher, and web/docs researchers) before making edits.',
138130
!withImplementorGpt5 &&
139-
`- Spawn a ${isGpt5 ? 'editor-best-of-n-gpt-5' : 'editor-best-of-n'} agent to implement the changes after you have gathered all the context you need. You must spawn this agent for non-trivial changes, since it writes much better code than you would with the str_replace or write_file tools. Don't spawn the editor in parallel with context-gathering agents.`,
131+
`- Spawn a ${isMax ? 'editor-best-of-n-gpt-5' : 'editor-best-of-n'} agent to implement the changes after you have gathered all the context you need. You must spawn this agent for non-trivial changes, since it writes much better code than you would with the str_replace or write_file tools. Don't spawn the editor in parallel with context-gathering agents.`,
140132
withImplementorGpt5 &&
141133
`- Spawn a editor-implementor-gpt-5 agent to implement the changes after you have gathered all the context you need. You must spawn this agent for non-trivial changes, since it writes much better code than you would with the str_replace or write_file tools.`,
142134
'- Spawn commanders sequentially if the second command depends on the the first.',
@@ -187,7 +179,6 @@ ${PLACEHOLDER.GIT_CHANGES_PROMPT}
187179
? buildPlanOnlyInstructionsPrompt({})
188180
: buildImplementationInstructionsPrompt({
189181
isSonnet,
190-
isGpt5,
191182
isFast,
192183
isDefault,
193184
isMax,
@@ -202,7 +193,6 @@ ${PLACEHOLDER.GIT_CHANGES_PROMPT}
202193
: buildImplementationStepPrompt({
203194
isFast,
204195
isMax,
205-
isGpt5,
206196
hasNoValidation,
207197
isSonnet,
208198
withImplementorGpt5,
@@ -233,7 +223,6 @@ const EXPLORE_PROMPT = `- Iteratively spawn file pickers, code-searchers, direct
233223

234224
function buildImplementationInstructionsPrompt({
235225
isSonnet,
236-
isGpt5,
237226
isFast,
238227
isDefault,
239228
isMax,
@@ -244,7 +233,6 @@ function buildImplementationInstructionsPrompt({
244233
withDecisionMaker,
245234
}: {
246235
isSonnet: boolean
247-
isGpt5: boolean
248236
isFast: boolean
249237
isDefault: boolean
250238
isMax: boolean
@@ -274,7 +262,7 @@ ${buildArray(
274262
'- Do a single typecheck targeted for your changes at most (if applicable for the project). Or skip this step if the change was small.',
275263
!isFast &&
276264
!withImplementorGpt5 &&
277-
`- IMPORTANT: You must spawn the ${isGpt5 ? 'editor-best-of-n-gpt-5' : 'editor-best-of-n'} agent to implement non-trivial code changes, since it will generate the best code changes from multiple implementation proposals. This is the best way to make high quality code changes -- strongly prefer using this agent over the str_replace or write_file tools, unless the change is very straightforward and obvious.`,
265+
`- IMPORTANT: You must spawn the ${isMax ? 'editor-best-of-n-gpt-5' : 'editor-best-of-n'} agent to implement non-trivial code changes, since it will generate the best code changes from multiple implementation proposals. This is the best way to make high quality code changes -- strongly prefer using this agent over the str_replace or write_file tools, unless the change is very straightforward and obvious.`,
278266
withImplementorGpt5 &&
279267
`- IMPORTANT: You must spawn the editor-implementor-gpt-5 agent to implement non-trivial code changes, since it will generate the best code changes using a smarter reasoning model. This is the best way to make high quality code changes -- strongly prefer using this agent over the str_replace or write_file tools, unless the change is very straightforward and obvious.`,
280268
hasCodeReviewer &&
@@ -284,21 +272,18 @@ ${buildArray(
284272
!hasNoValidation &&
285273
`- Test your changes${isMax ? '' : ' briefly'} by running appropriate validation commands for the project (e.g. typechecks, tests, lints, etc.).${isMax ? ' Start by type checking the specific area of the project that you are editing and then test the entire project if necessary.' : ' If you can, only typecheck/test the area of the project that you are editing, rather than the entire project.'} You may have to explore the project to find the appropriate commands. Don't skip this step!`,
286274
`- Inform the user that you have completed the task in one sentence or a few short bullet points.${isSonnet ? " Don't create any markdown summary files or example documentation files, unless asked by the user." : ''}`,
287-
isGpt5 && `- Use the task_completed tool.`,
288275
).join('\n')}`
289276
}
290277

291278
function buildImplementationStepPrompt({
292279
isFast,
293280
isMax,
294-
isGpt5,
295281
hasNoValidation,
296282
isSonnet,
297283
withImplementorGpt5,
298284
}: {
299285
isFast: boolean
300286
isMax: boolean
301-
isGpt5: boolean
302287
hasNoValidation: boolean
303288
isSonnet: boolean
304289
withImplementorGpt5: boolean
@@ -307,10 +292,8 @@ function buildImplementationStepPrompt({
307292
isMax &&
308293
`Keep working until the user's request is completely satisfied${!hasNoValidation ? ' and validated' : ''}, or until you require more information from the user.`,
309294
!isFast &&
310-
`You must spawn the ${withImplementorGpt5 ? 'editor-implementor-gpt-5' : isGpt5 ? 'editor-best-of-n-gpt-5' : 'editor-best-of-n'} agent to implement code changes, since it will generate the best code changes.`,
295+
`You must spawn the ${withImplementorGpt5 ? 'editor-implementor-gpt-5' : isMax ? 'editor-best-of-n-gpt-5' : 'editor-best-of-n'} agent to implement code changes, since it will generate the best code changes.`,
311296
`After completing the user request, summarize your changes in a sentence${isFast ? '' : ' or a few short bullet points'}.${isSonnet ? " Don't create any summary markdown files or example documentation files, unless asked by the user." : ''}. Don't repeat yourself -- especially if you already summarized your changes then just end your turn.`,
312-
isGpt5 &&
313-
`IMPORTANT: You must include at least one tool call ("<codebuff_tool_call>") per message response. If you are completely done with the user's request or require more information from the user, you must call the task_completed tool to end your turn.`,
314297
).join('\n')
315298
}
316299

.agents/editor/best-of-n/best-of-n-selector-gpt-5.ts

Lines changed: 0 additions & 10 deletions
This file was deleted.

0 commit comments

Comments
 (0)