style: await usage consistency

Author: brandonkachen

cli/scripts/build-binary.ts

@@ -296,7 +296,8 @@ async function ensureOpenTuiNativeBundle(targetInfo: TargetInfo) {
     )
   }
 
-  const metadata = (await metadataResponse.json()) as {
+  const metadataResponseBody = await metadataResponse.json()
+  const metadata = metadataResponseBody as {
     versions?: Record<
       string,
       {
@@ -325,7 +326,8 @@ async function ensureOpenTuiNativeBundle(targetInfo: TargetInfo) {
       tempDir,
       `${packageName.split('/').pop() ?? 'package'}-${version}.tgz`,
     )
-    await Bun.write(tarballPath, await tarballResponse.arrayBuffer())
+    const tarballBuffer = await tarballResponse.arrayBuffer()
+    await Bun.write(tarballPath, tarballBuffer)
 
     for (const target of missingTargets) {
       mkdirSync(target.packagesDir, { recursive: true })

cli/src/hooks/use-claude-quota-query.ts

@@ -67,7 +67,8 @@ export async function fetchClaudeQuota(
     throw new Error(`Failed to fetch Claude quota: ${response.status}`)
   }
 
-  const data = (await response.json()) as ClaudeQuotaResponse
+  const responseBody = await response.json()
+  const data = responseBody as ClaudeQuotaResponse
 
   // Parse the response into a more usable format
   const fiveHour = data.five_hour

cli/src/hooks/use-usage-query.ts

@@ -67,7 +67,8 @@ export async function fetchUsageData({
     throw new Error(`Failed to fetch usage: ${response.status}`)
   }
 
-  const data = (await response.json()) as UsageResponse
+  const responseBody = await response.json()
+  const data = responseBody as UsageResponse
   return data
 }
 

cli/src/login/utils.ts

@@ -58,7 +58,7 @@ export function formatUrl(url: string, maxWidth?: number): string[] {
  * Generates a unique fingerprint ID for CLI authentication
  */
 export function generateFingerprintId(): string {
-  return `codecane-cli-${Math.random().toString(36).substring(2, 15)}`
+  return `codebuff-cli-${Math.random().toString(36).substring(2, 15)}`
 }
 
 /**

cli/src/native/ripgrep.ts

@@ -19,7 +19,8 @@ const getRipgrepPath = async (): Promise<string> => {
   const outPath = path.join(binaryDir, rgFileName)
 
   // Check if already extracted
-  if (await Bun.file(outPath).exists()) {
+  const outPathExists = await Bun.file(outPath).exists()
+  if (outPathExists) {
     return outPath
   }
 
@@ -44,7 +45,8 @@ const getRipgrepPath = async (): Promise<string> => {
     }
 
     // Copy SDK's bundled binary to binary directory for portability
-    await Bun.write(outPath, await Bun.file(embeddedRgPath).arrayBuffer())
+    const embeddedBuffer = await Bun.file(embeddedRgPath).arrayBuffer()
+    await Bun.write(outPath, embeddedBuffer)
 
     // Make executable on Unix systems
     if (process.platform !== 'win32') {

cli/src/utils/codebuff-api.ts

@@ -331,7 +331,8 @@ export function createCodebuffApiClient(
 
         if (response.ok) {
           try {
-            const data = (await response.json()) as T
+            const responseBody = await response.json()
+            const data = responseBody as T
             return { ok: true, status: response.status, data }
           } catch {
             // Response was OK but no JSON body (e.g., 204 No Content)

cli/src/utils/codebuff-client.ts

@@ -78,10 +78,11 @@ export async function getCodebuffClient(): Promise<CodebuffClient | null> {
         agentDefinitions,
         overrideTools: {
           ask_user: async (input: ClientToolCall<'ask_user'>['input']) => {
-            const response = (await AskUserBridge.request(
+            const askUserResponse = await AskUserBridge.request(
               'cli-override',
               input.questions,
-            )) as {
+            )
+            const response = askUserResponse as {
               answers?: Array<{ questionIndex: number; selectedOption: string }>
               skipped?: boolean
             }

common/src/mcp/client.ts

@@ -124,7 +124,9 @@ export async function callMCPTool(
   if (!client) {
     throw new Error(`callTool: client not found with id: ${clientId}`)
   }
-  const content = ((await client.callTool(...args)) as CallToolResult).content
+  const callResult = await client.callTool(...args)
+  const result = callResult as CallToolResult
+  const content = result.content
 
   return content.map((c: (typeof content)[number]) => {
     if (c.type === 'text') {

common/src/project-file-tree.ts

@@ -52,10 +52,15 @@ export async function getProjectFileTree(params: {
 
   while (queue.length > 0 && totalFiles < maxFiles) {
     const { node, fullPath, ignore: currentIgnore } = queue.shift()!
+    const parsedIgnore = await parseGitignore({
+      fullDirPath: fullPath,
+      projectRoot,
+      fs,
+    })
     const mergedIgnore = ignore
       .default()
       .add(currentIgnore)
-      .add(await parseGitignore({ fullDirPath: fullPath, projectRoot, fs }))
+      .add(parsedIgnore)
 
     try {
       const files = await fs.readdir(fullPath)
@@ -167,7 +172,8 @@ export async function parseGitignore(params: {
   ]
 
   for (const ignoreFilePath of ignoreFiles) {
-    if (!(await fileExists({ filePath: ignoreFilePath, fs }))) continue
+    const ignoreFileExists = await fileExists({ filePath: ignoreFilePath, fs })
+    if (!ignoreFileExists) continue
 
     let ignoreContent: string
     try {

common/src/testing/mock-modules.ts

@@ -17,10 +17,14 @@ export async function mockModule(
   modulePath: string,
   renderMocks: () => Record<string, any>,
 ): Promise<MockResult> {
-  let original = originalModuleCache[modulePath] ?? {
-    ...(await import(modulePath)),
+  let original = originalModuleCache[modulePath]
+  if (!original) {
+    const moduleExports = await import(modulePath)
+    original = {
+      ...moduleExports,
+    }
+    originalModuleCache[modulePath] = original
   }
-  originalModuleCache[modulePath] = original
   let mocks = renderMocks()
   let result = {
     ...original,