Dedup max agent step constants. Set to 25, not 12 or 40

Author: jahooma

common/src/constants/agents.ts

@@ -119,4 +119,4 @@ export const AGENT_NAME_TO_TYPES = Object.entries(AGENT_NAMES).reduce(
   {} as Record<string, string[]>,
 )
 
-export const MAX_AGENT_STEPS_DEFAULT = 40
+export const MAX_AGENT_STEPS_DEFAULT = 25

common/src/json-config/constants.ts

@@ -1,3 +1,4 @@
+import { MAX_AGENT_STEPS_DEFAULT } from '../constants/agents'
 import { z } from 'zod/v4'
 
 export const codebuffConfigFile = 'codebuff.json'
@@ -64,8 +65,6 @@ export const FileChangeHook = z
   })
   .describe('Defines a single file change hook.')
 
-export const DEFAULT_MAX_AGENT_STEPS = 12
-
 export const CodebuffConfigSchema = z
   .object({
     description: z
@@ -83,7 +82,7 @@ export const CodebuffConfigSchema = z
     maxAgentSteps: z
       .number()
       .optional()
-      .default(DEFAULT_MAX_AGENT_STEPS)
+      .default(MAX_AGENT_STEPS_DEFAULT)
       .describe(
         'Maximum number of turns agent will take before being forced to end',
       ),

common/src/json-config/default.ts

@@ -1,12 +1,14 @@
-import type { CodebuffConfig } from './constants'
+import { MAX_AGENT_STEPS_DEFAULT } from '../constants/agents'
+import { type CodebuffConfig } from './constants'
 
 export function getDefaultConfig(): CodebuffConfig {
   return {
     description: '',
     startupProcesses: [],
     fileChangeHooks: [],
-    maxAgentSteps: 12,
+    maxAgentSteps: MAX_AGENT_STEPS_DEFAULT,
     baseAgent: undefined,
     spawnableAgents: undefined,
   }
 }
+

npm-app/src/client.ts

@@ -988,8 +988,10 @@ export class Client {
       },
     ])
 
+    const codebuffConfig = loadCodebuffConfig()
+
     this.sessionState.mainAgentState.stepsRemaining =
-      loadCodebuffConfig().maxAgentSteps
+      codebuffConfig.maxAgentSteps
 
     this.sessionState.fileContext.cwd = getWorkingDirectory()
     this.sessionState.fileContext.agentTemplates = await loadLocalAgents({})