Skip to content

Commit ba6b029

Browse files
refactor: convert messagesWithSystem to use object parameter
🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
1 parent 68e05e4 commit ba6b029

File tree

8 files changed

+41
-34
lines changed

8 files changed

+41
-34
lines changed

backend/src/admin/relabelRuns.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -169,10 +169,10 @@ export async function relabelForUserHandler(req: Request, res: Response) {
169169
const system = payload.system
170170

171171
output = await promptAiSdk({
172-
messages: messagesWithSystem(
173-
messages as Message[],
174-
system as System,
175-
),
172+
messages: messagesWithSystem({
173+
messages: messages as Message[],
174+
system: system as System,
175+
}),
176176
model: model,
177177
clientSessionId: 'relabel-trace-api',
178178
fingerprintId: 'relabel-trace-api',
@@ -395,7 +395,7 @@ export async function relabelWithClaudeWithFullFileContext(
395395
}
396396

397397
const output = await promptAiSdk({
398-
messages: messagesWithSystem(trace.payload.messages as Message[], system),
398+
messages: messagesWithSystem({ messages: trace.payload.messages as Message[], system }),
399399
model: model as any, // Model type is string here for flexibility
400400
clientSessionId: 'relabel-trace-api',
401401
fingerprintId: 'relabel-trace-api',

backend/src/find-files/request-files-prompt.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ async function getRelevantFiles(
327327
bufferTokens,
328328
)
329329
const start = performance.now()
330-
let codebuffMessages = messagesWithSystem(messagesWithPrompt, system)
330+
let codebuffMessages = messagesWithSystem({ messages: messagesWithPrompt, system })
331331

332332
// Converts assistant messages to user messages for finetuned model
333333
codebuffMessages = codebuffMessages
@@ -410,7 +410,7 @@ async function getRelevantFilesForTraining(
410410
)
411411
const start = performance.now()
412412
let response = await promptAiSdk({
413-
messages: messagesWithSystem(messagesWithPrompt, system),
413+
messages: messagesWithSystem({ messages: messagesWithPrompt, system }),
414414
clientSessionId,
415415
fingerprintId,
416416
userInputId,

backend/src/run-agent-step.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,9 @@ export const runAgentStep = async (
277277
let fullResponse = ''
278278
const toolResults: ToolResultPart[] = []
279279

280-
const stream = getStream(messagesWithSystem(agentMessages, system))
280+
const stream = getStream(
281+
messagesWithSystem({ messages: agentMessages, system }),
282+
)
281283

282284
const {
283285
toolCalls,

backend/src/run-programmatic-step.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ export async function runProgrammaticStep(
8686

8787
// Run with either a generator or a sandbox.
8888
let generator = runIdToGenerator[agentState.runId]
89-
let sandbox = sandboxManager.getSandbox(agentState.runId)
89+
let sandbox = sandboxManager.getSandbox({ runId: agentState.runId })
9090

9191
// Check if we need to initialize a generator
9292
if (!generator && !sandbox) {
@@ -113,18 +113,18 @@ export async function runProgrammaticStep(
113113

114114
if (typeof template.handleSteps === 'string') {
115115
// Initialize QuickJS sandbox for string-based generator
116-
sandbox = await sandboxManager.getOrCreateSandbox(
117-
agentState.runId,
118-
template.handleSteps,
119-
{
116+
sandbox = await sandboxManager.getOrCreateSandbox({
117+
runId: agentState.runId,
118+
generatorCode: template.handleSteps,
119+
initialInput: {
120120
agentState,
121121
prompt,
122122
params,
123123
logger: streamingLogger,
124124
},
125-
undefined, // config
126-
streamingLogger, // pass the streaming logger instance for internal use
127-
)
125+
config: undefined, // config
126+
logger: streamingLogger, // pass the streaming logger instance for internal use
127+
})
128128
} else {
129129
// Initialize native generator
130130
generator = template.handleSteps({
@@ -362,7 +362,7 @@ export async function runProgrammaticStep(
362362
if (endTurn) {
363363
if (sandbox) {
364364
// Clean up QuickJS sandbox if execution is complete
365-
sandboxManager.removeSandbox(agentState.runId)
365+
sandboxManager.removeSandbox({ runId: agentState.runId })
366366
}
367367
delete runIdToGenerator[agentState.runId]
368368
runIdToStepAll.delete(agentState.runId)

backend/src/util/__tests__/messages.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ describe('messagesWithSystem', () => {
3030
] as Message[]
3131
const system = 'Be helpful'
3232

33-
const result = messagesWithSystem(messages, system)
33+
const result = messagesWithSystem({ messages, system })
3434

3535
expect(result).toEqual([
3636
{ role: 'system', content: 'Be helpful' },

backend/src/util/messages.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,11 @@ import type {
1919
ToolMessage,
2020
} from '@codebuff/common/types/messages/codebuff-message'
2121

22-
export function messagesWithSystem(
23-
messages: Message[],
24-
system: System,
25-
): Message[] {
22+
export function messagesWithSystem(params: {
23+
messages: Message[]
24+
system: System
25+
}): Message[] {
26+
const { messages, system } = params
2627
return [
2728
{
2829
role: 'system',

backend/src/util/quickjs-sandbox.ts

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -261,18 +261,19 @@ export class SandboxManager {
261261
/**
262262
* Create or get a sandbox for the given agent ID
263263
*/
264-
async getOrCreateSandbox(
265-
runId: string,
266-
generatorCode: string,
267-
initialInput: any,
268-
config?: SandboxConfig,
264+
async getOrCreateSandbox(params: {
265+
runId: string
266+
generatorCode: string
267+
initialInput: any
268+
config?: SandboxConfig
269269
logger?: {
270270
debug: (data: any, msg?: string) => void
271271
info: (data: any, msg?: string) => void
272272
warn: (data: any, msg?: string) => void
273273
error: (data: any, msg?: string) => void
274-
},
275-
): Promise<QuickJSSandbox> {
274+
}
275+
}): Promise<QuickJSSandbox> {
276+
const { runId, generatorCode, initialInput, config, logger } = params
276277
const existing = this.sandboxes.get(runId)
277278
if (existing && existing.isInitialized()) {
278279
return existing
@@ -297,14 +298,16 @@ export class SandboxManager {
297298
/**
298299
* Get an existing sandbox
299300
*/
300-
getSandbox(runId: string): QuickJSSandbox | undefined {
301+
getSandbox(params: { runId: string }): QuickJSSandbox | undefined {
302+
const { runId } = params
301303
return this.sandboxes.get(runId)
302304
}
303305

304306
/**
305307
* Remove and dispose a sandbox
306308
*/
307-
removeSandbox(runId: string): void {
309+
removeSandbox(params: { runId: string }): void {
310+
const { runId } = params
308311
const sandbox = this.sandboxes.get(runId)
309312
if (sandbox) {
310313
sandbox.dispose()

backend/src/websockets/websocket-action.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,10 @@ export const sendAction = (ws: WebSocket, action: ServerAction) => {
4747
* @param authToken - The authentication token to validate
4848
* @returns The user ID if found, undefined otherwise
4949
*/
50-
export const getUserIdFromAuthToken = async (
51-
authToken?: string,
52-
): Promise<string | undefined> => {
50+
export const getUserIdFromAuthToken = async (params: {
51+
authToken?: string
52+
}): Promise<string | undefined> => {
53+
const { authToken } = params
5354
if (!authToken) return undefined
5455

5556
const userId = await db

0 commit comments

Comments
 (0)