Skip to content

Commit f8aa720

Browse files
committed
camGameZoomMult, camHudZoomMult
1 parent 7019505 commit f8aa720

File tree

2 files changed

+22
-13
lines changed

2 files changed

+22
-13
lines changed

source/funkin/backend/system/Flags.hx

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,12 @@ class Flags {
138138
public static var DEFAULT_HUD_ZOOM:Float = 1.0;
139139
public static var DEFAULT_ZOOM:Float = 1.0;
140140
public static var DEFAULT_ZOOM_LERP:Float = 0.05;
141+
public static var MAX_CAMERA_ZOOM_MULT:Float = 10;
141142
public static var USE_CAM_ZOOM_MULT:Bool = true;
142-
public static var MAX_CAMERA_ZOOM_MULT:Float = 1.35;
143+
public static var DEFAULT_CAM_ZOOM_MULT:Float = 0.015;
144+
public static var DEFAULT_HUD_ZOOM_MULT:Float = 0.03;
145+
public static var DEFAULT_CAM_ZOOM_LERP:Float = 0.05;
146+
public static var DEFAULT_HUD_ZOOM_LERP:Float = 0.05;
143147

144148
// to translate these you need to convert them into ids
145149
// Resume -> pause.resume
@@ -167,11 +171,6 @@ class Flags {
167171
public static var DEFAULT_INTRO_LENGTH:Int = 5;
168172
public static var DEFAULT_INTRO_SPRITES:Array<String> = [null, 'game/ready', 'game/set', 'game/go'];
169173

170-
public static var CAM_BOP_STRENGTH:Float = 0.015;
171-
public static var HUD_BOP_STRENGTH:Float = 0.03;
172-
public static var DEFAULT_CAM_ZOOM_LERP:Float = 0.05;
173-
public static var DEFAULT_HUD_ZOOM_LERP:Float = 0.05;
174-
175174
public static var MAX_SPLASHES:Int = 8;
176175
public static var STUNNED_TIME:Float = 5 / 60;
177176

source/funkin/game/PlayState.hx

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -362,6 +362,10 @@ class PlayState extends MusicBeatState
362362
* Speed at which the game camera zoom lerps to.
363363
*/
364364
public var camGameZoomLerp:Float = Flags.DEFAULT_CAM_ZOOM_LERP;
365+
/**
366+
* The current multiplier for game camera zooming.
367+
*/
368+
public var camGameZoomMult:Float = Flags.DEFAULT_CAM_ZOOM_MULT;
365369

366370
/**
367371
* Camera zoom at which the hud lerps to.
@@ -371,6 +375,10 @@ class PlayState extends MusicBeatState
371375
* Speed at which the hud camera zoom lerps to.
372376
*/
373377
public var camHUDZoomLerp:Float = Flags.DEFAULT_HUD_ZOOM_LERP;
378+
/**
379+
* The current multiplier for game camera zooming.
380+
*/
381+
public var camHUDZoomMult:Float = Flags.DEFAULT_HUD_ZOOM_MULT;
374382

375383
/**
376384
* Camera zoom at which the cameras that zooms lerps to.
@@ -420,7 +428,7 @@ class PlayState extends MusicBeatState
420428
*/
421429
public var useCamZoomMult:Bool = Flags.USE_CAM_ZOOM_MULT;
422430
/**
423-
* The current multiplier for cam zooming.
431+
* The current multiplier for camera zooming.
424432
* (Only used if useCamZoomMult is on).
425433
*/
426434
public var camZoomingMult:Float = Flags.DEFAULT_ZOOM;
@@ -429,7 +437,7 @@ class PlayState extends MusicBeatState
429437
*/
430438
public var maxCamZoom(get, default):Float = Math.NaN;
431439

432-
private inline function get_maxCamZoom() return Math.isNaN(maxCamZoom) ? maxCamZoomMult * defaultCamZoom : maxCamZoom;
440+
private inline function get_maxCamZoom() return Math.isNaN(maxCamZoom) ? defaultCamZoom + (camZoomingMult * camGameZoomMult) : maxCamZoom;
433441

434442
/**
435443
* Zoom for the pixel assets.
@@ -1348,10 +1356,12 @@ class PlayState extends MusicBeatState
13481356
var beat = Conductor.getBeats(camZoomingEvery, camZoomingInterval, camZoomingOffset);
13491357
if (camZoomingLastBeat != beat) {
13501358
camZoomingLastBeat = beat;
1351-
if (useCamZoomMult) camZoomingMult = Math.min(camZoomingMult + camZoomingStrength, defaultZoom + camZoomingStrength);
1359+
if (useCamZoomMult) {
1360+
if (camZoomingMult < maxCamZoomMult) camZoomingMult += camZoomingStrength;
1361+
}
13521362
else if (FlxG.camera.zoom < maxCamZoom) {
1353-
FlxG.camera.zoom += 0.015 * camZoomingStrength;
1354-
camHUD.zoom += 0.03 * camZoomingStrength;
1363+
FlxG.camera.zoom += camGameZoomMult * camZoomingStrength;
1364+
camHUD.zoom += camHUDZoomMult * camZoomingStrength;
13551365
}
13561366
}
13571367
}
@@ -1397,8 +1407,8 @@ class PlayState extends MusicBeatState
13971407
if (camZooming) {
13981408
if (useCamZoomMult) {
13991409
camZoomingMult = lerp(camZoomingMult, defaultZoom, camZoomLerp) - defaultZoom;
1400-
FlxG.camera.zoomMultiplier = camZoomingMult * 0.015 + defaultZoom;
1401-
camHUD.zoomMultiplier = camZoomingMult * 0.03 + defaultZoom;
1410+
FlxG.camera.zoomMultiplier = camZoomingMult * camGameZoomMult + defaultZoom;
1411+
camHUD.zoomMultiplier = camZoomingMult * camHUDZoomMult + defaultZoom;
14021412
camZoomingMult += defaultZoom;
14031413
}
14041414
FlxG.camera.zoom = lerp(FlxG.camera.zoom, defaultCamZoom, camGameZoomLerp);

0 commit comments

Comments
 (0)