Added unit tests for new SystemInformation API

Author: Sergio0694

Microsoft.Toolkit.Uwp/Helpers/SystemInformation.cs

@@ -50,23 +50,29 @@ private SystemInformation()
             }
 
             DeviceFamily = AnalyticsInfo.VersionInfo.DeviceFamily;
+
             ulong version = ulong.Parse(AnalyticsInfo.VersionInfo.DeviceFamilyVersion);
+
             OperatingSystemVersion = new OSVersion
             {
                 Major = (ushort)((version & 0xFFFF000000000000L) >> 48),
                 Minor = (ushort)((version & 0x0000FFFF00000000L) >> 32),
                 Build = (ushort)((version & 0x00000000FFFF0000L) >> 16),
                 Revision = (ushort)(version & 0x000000000000FFFFL)
             };
+
             OperatingSystemArchitecture = Package.Current.Id.Architecture;
-            EasClientDeviceInformation deviceInfo = new EasClientDeviceInformation();
+
+            EasClientDeviceInformation deviceInfo = new();
+
             OperatingSystem = deviceInfo.OperatingSystem;
             DeviceManufacturer = deviceInfo.SystemManufacturer;
             DeviceModel = deviceInfo.SystemProductName;
             IsFirstRun = DetectIfFirstUse();
             (IsAppUpdated, PreviousVersionInstalled) = DetectIfAppUpdated();
             FirstUseTime = DetectFirstUseTime();
             FirstVersionInstalled = DetectFirstVersionInstalled();
+
             InitializeValuesSetWithTrackAppUse();
         }
 

UnitTests/UnitTests.UWP/Helpers/Test_SystemInformation.cs

@@ -0,0 +1,75 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+using System;
+using Microsoft.Toolkit.Uwp.Helpers;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+using Windows.ApplicationModel;
+using Windows.Storage;
+
+namespace UnitTests.Helpers
+{
+    [TestClass]
+    public class Test_SystemInformation
+    {
+        [TestCategory("Helpers")]
+        [TestMethod]
+        public void Test_SystemInformation_ConsistentInfoForFirstStartup()
+        {
+            ApplicationData.Current.LocalSettings.Values.Clear();
+
+            var systemInformation = (SystemInformation)Activator.CreateInstance(typeof(SystemInformation), nonPublic: true);
+            var currentAppVersion = Package.Current.Id.Version;
+
+            Assert.IsTrue(systemInformation.IsFirstRun);
+            Assert.IsFalse(systemInformation.IsAppUpdated);
+            Assert.AreEqual(systemInformation.ApplicationVersion, currentAppVersion);
+            Assert.AreEqual(systemInformation.PreviousVersionInstalled, currentAppVersion);
+            Assert.AreEqual(systemInformation.FirstVersionInstalled, currentAppVersion);
+        }
+
+        [TestCategory("Helpers")]
+        [TestMethod]
+        public void Test_SystemInformation_ConsistentInfoForStartupWithNoUpdate()
+        {
+            ApplicationData.Current.LocalSettings.Values.Clear();
+
+            // Simulate a first app startup
+            _ = (SystemInformation)Activator.CreateInstance(typeof(SystemInformation), nonPublic: true);
+
+            var systemInformation = (SystemInformation)Activator.CreateInstance(typeof(SystemInformation), nonPublic: true);
+            var currentAppVersion = Package.Current.Id.Version;
+
+            Assert.IsFalse(systemInformation.IsFirstRun);
+            Assert.IsFalse(systemInformation.IsAppUpdated);
+            Assert.AreEqual(systemInformation.ApplicationVersion, currentAppVersion);
+            Assert.AreEqual(systemInformation.PreviousVersionInstalled, currentAppVersion);
+            Assert.AreEqual(systemInformation.FirstVersionInstalled, currentAppVersion);
+        }
+
+        [TestCategory("Helpers")]
+        [TestMethod]
+        public void Test_SystemInformation_ConsistentInfoForStartupWithUpdate()
+        {
+            ApplicationData.Current.LocalSettings.Values.Clear();
+
+            // Simulate a first app startup
+            _ = (SystemInformation)Activator.CreateInstance(typeof(SystemInformation), nonPublic: true);
+
+            LocalObjectStorageHelper localObjectStorageHelper = new(new SystemSerializer());
+            PackageVersion previousVersion = new() { Build = 42, Major = 1111, Minor = 2222, Revision = 12345 };
+
+            localObjectStorageHelper.Save("currentVersion", previousVersion.ToFormattedString());
+
+            var systemInformation = (SystemInformation)Activator.CreateInstance(typeof(SystemInformation), nonPublic: true);
+            var currentAppVersion = Package.Current.Id.Version;
+
+            Assert.IsFalse(systemInformation.IsFirstRun);
+            Assert.IsTrue(systemInformation.IsAppUpdated);
+            Assert.AreEqual(systemInformation.ApplicationVersion, currentAppVersion);
+            Assert.AreEqual(systemInformation.PreviousVersionInstalled, previousVersion);
+            Assert.AreEqual(systemInformation.FirstVersionInstalled, currentAppVersion);
+        }
+    }
+}

UnitTests/UnitTests.UWP/UnitTests.UWP.csproj

@@ -169,6 +169,7 @@
     <Compile Include="Helpers\Test_ConnectionHelper.cs" />
     <Compile Include="Helpers\Test_ScreenUnitHelper.cs" />
     <Compile Include="Helpers\Test_StorageFileHelper.cs" />
+    <Compile Include="Helpers\Test_SystemInformation.cs" />
     <Compile Include="Helpers\Test_StorageHelper.cs" />
     <Compile Include="Helpers\Test_StreamHelper.cs" />
     <Compile Include="Helpers\Test_DeepLinkParser.cs" />