Moved UserControl test paths down in priority

Author: Sergio0694

Microsoft.Toolkit.Uwp.UI/Extensions/Tree/LogicalTree.cs

@@ -153,44 +153,46 @@ public static class LogicalTree
                     }
                 }
             }
-            else if (element is UserControl userControl)
+            else if (element is ContentControl contentControl)
             {
-                if (userControl.Content is T result && predicate.Match(result))
+                if (contentControl.Content is T result && predicate.Match(result))
                 {
                     return result;
                 }
 
-                if (userControl.Content is FrameworkElement content)
+                if (contentControl.Content is FrameworkElement content)
                 {
                     element = content;
 
                     goto Start;
                 }
             }
-            else if (element is ContentControl contentControl)
+            else if (element is Border border)
             {
-                if (contentControl.Content is T result && predicate.Match(result))
+                if (border.Child is T result && predicate.Match(result))
                 {
                     return result;
                 }
 
-                if (contentControl.Content is FrameworkElement content)
+                if (border.Child is FrameworkElement child)
                 {
-                    element = content;
+                    element = child;
 
                     goto Start;
                 }
             }
-            else if (element is Border border)
+            else if (element is UserControl userControl)
             {
-                if (border.Child is T result && predicate.Match(result))
+                // We put UserControl right before the slower reflection fallback path as
+                // this type is less likely to be used compared to the other ones above.
+                if (userControl.Content is T result && predicate.Match(result))
                 {
                     return result;
                 }
 
-                if (border.Child is FrameworkElement child)
+                if (userControl.Content is FrameworkElement content)
                 {
-                    element = child;
+                    element = content;
 
                     goto Start;
                 }
@@ -348,9 +350,9 @@ public static IEnumerable<FrameworkElement> FindChildren(this FrameworkElement e
                     }
                 }
             }
-            else if (element is UserControl userControl)
+            else if (element is ContentControl contentControl)
             {
-                if (userControl.Content is FrameworkElement content)
+                if (contentControl.Content is FrameworkElement content)
                 {
                     yield return content;
 
@@ -359,24 +361,24 @@ public static IEnumerable<FrameworkElement> FindChildren(this FrameworkElement e
                     goto Start;
                 }
             }
-            else if (element is ContentControl contentControl)
+            else if (element is Border border)
             {
-                if (contentControl.Content is FrameworkElement content)
+                if (border.Child is FrameworkElement child)
                 {
-                    yield return content;
+                    yield return child;
 
-                    element = content;
+                    element = child;
 
                     goto Start;
                 }
             }
-            else if (element is Border border)
+            else if (element is UserControl userControl)
             {
-                if (border.Child is FrameworkElement child)
+                if (userControl.Content is FrameworkElement content)
                 {
-                    yield return child;
+                    yield return content;
 
-                    element = child;
+                    element = content;
 
                     goto Start;
                 }