Removing Math reference

shweaver-MSFT · shweaver-MSFT · commit ccefe38c8e1a · 2021-08-13T14:26:35.000-07:00
diff --git a/Microsoft.Toolkit.Uwp.UI.Controls.Input/TokenizingTextBox/TokenizingTextBox.cs b/Microsoft.Toolkit.Uwp.UI.Controls.Input/TokenizingTextBox/TokenizingTextBox.cs
@@ -78,10 +78,11 @@ private void ItemsSource_PropertyChanged(DependencyObject sender, DependencyProp
             {
                 _innerItemsSource = new InterspersedObservableCollection(ItemsSource);
 
-                if (ReadLocalValue(MaximumTokensProperty) != DependencyProperty.UnsetValue && _innerItemsSource.ItemsSource.Count > MaximumTokens)
+                if (ReadLocalValue(MaximumTokensProperty) != DependencyProperty.UnsetValue && _innerItemsSource.ItemsSource.Count >= MaximumTokens)
                 {
-                    // Reduce down to the max as necessary.
-                    for (var i = _innerItemsSource.ItemsSource.Count - 1; i >= Math.Max(MaximumTokens, 0); --i)
+                    // Reduce down to below the max as necessary.
+                    var endCount = MaximumTokens > 0 ? MaximumTokens : 0;
+                    for (var i = _innerItemsSource.ItemsSource.Count - 1; i >= endCount; --i)
                     {
                         _innerItemsSource.Remove(_innerItemsSource[i]);
                     }

Original file line number	Diff line number	Diff line change
`@@ -78,10 +78,11 @@ private void ItemsSource_PropertyChanged(DependencyObject sender, DependencyProp`
`78`	`78`	`{`
`79`	`79`	`_innerItemsSource = new InterspersedObservableCollection(ItemsSource);`
`80`	`80`
`81`		`- if (ReadLocalValue(MaximumTokensProperty) != DependencyProperty.UnsetValue && _innerItemsSource.ItemsSource.Count > MaximumTokens)`
	`81`	`+ if (ReadLocalValue(MaximumTokensProperty) != DependencyProperty.UnsetValue && _innerItemsSource.ItemsSource.Count >= MaximumTokens)`
`82`	`82`	`{`
`83`		`- // Reduce down to the max as necessary.`
`84`		`- for (var i = _innerItemsSource.ItemsSource.Count - 1; i >= Math.Max(MaximumTokens, 0); --i)`
	`83`	`+ // Reduce down to below the max as necessary.`
	`84`	`+ var endCount = MaximumTokens > 0 ? MaximumTokens : 0;`
	`85`	`+ for (var i = _innerItemsSource.ItemsSource.Count - 1; i >= endCount; --i)`
`85`	`86`	`{`
`86`	`87`	`_innerItemsSource.Remove(_innerItemsSource[i]);`
`87`	`88`	`}`