Skip to content

Commit 1a4534d

Browse files
committed
Revert "glue (#401)"
This reverts commit 4fe950f.
1 parent b0ab76a commit 1a4534d

File tree

2 files changed

+20
-20
lines changed

2 files changed

+20
-20
lines changed

conditional/blueprints/packet.py

Lines changed: 5 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def admin_packets(user_dict=None):
4646
# Pre-calculate and store the return values of did_sign(), signatures_received(), and signatures_required()
4747
for packet in open_packets:
4848
packet.did_sign_result = packet.did_sign(
49-
user_dict["username"], session["provider"] == "csh"
49+
user_dict["username"], app.config["REALM"] == "csh"
5050
)
5151
packet.signatures_received_result = packet.signatures_received()
5252
packet.signatures_required_result = packet.signatures_required()
@@ -306,7 +306,7 @@ def freshman_packet(packet_id, user_dict=None):
306306
"packet.html",
307307
info=user_dict,
308308
packet=packet,
309-
did_sign=packet.did_sign(user_dict["uid"], session["provider"] == "csh"),
309+
did_sign=packet.did_sign(user_dict["uid"], app.config["REALM"] == "csh"),
310310
required=packet.signatures_required(),
311311
received=packet.signatures_received(),
312312
upper=packet.upper_signatures,
@@ -333,7 +333,7 @@ def packets(user_dict=None):
333333
# Pre-calculate and store the return values of did_sign(), signatures_received(), and signatures_required()
334334
for packet in open_packets:
335335
packet.did_sign_result = packet.did_sign(
336-
user_dict["uid"], session["provider"] == "csh"
336+
user_dict["uid"], app.config["REALM"] == "csh"
337337
)
338338
packet.signatures_received_result = packet.signatures_received()
339339
packet.signatures_required_result = packet.signatures_required()
@@ -352,7 +352,7 @@ def index():
352352
"""
353353

354354

355-
@packet_bp.route("/upperclassmen/")
355+
@app.route("/upperclassmen/")
356356
@auth.oidc_auth("default")
357357
@get_user
358358
def upperclassmen_total(user_dict=None):
@@ -380,7 +380,7 @@ def upperclassmen_total(user_dict=None):
380380
)
381381

382382

383-
@packet_bp.route("/stats/packet/<packet_id>")
383+
@app.route("/stats/packet/<packet_id>")
384384
@auth.oidc_auth("default")
385385
@get_user
386386
def packet_graphs(packet_id, user_dict=None):
@@ -421,17 +421,3 @@ def agg(l, attr, date):
421421
fresh=stats["freshman"],
422422
packet=Packet.by_id(packet_id),
423423
)
424-
425-
426-
@packet_bp.route("/auth/csh")
427-
@auth.oidc_auth("default")
428-
def csh_login():
429-
session["provider"] = "csh"
430-
return redirect("/packet", code=301)
431-
432-
433-
@packet_bp.route("/auth/frosh")
434-
@auth.oidc_auth("frosh")
435-
def frosh_login():
436-
session["provider"] = "frosh"
437-
return redirect("/packet", code=301)

conditional/util/auth.py

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
from flask import request, session, redirect
44

5-
from conditional import auth
5+
from conditional import auth, app
66
from conditional.util.ldap import (
77
ldap_is_active,
88
ldap_is_alumni,
@@ -101,3 +101,17 @@ def csh_auth():
101101
@auth.oidc_auth("frosh")
102102
def frosh_auth():
103103
return
104+
105+
106+
@app.route("/auth/csh")
107+
@auth.oidc_auth("default")
108+
def csh_login():
109+
session["provider"] = "csh"
110+
return redirect("/packet", code=301)
111+
112+
113+
@app.route("/auth/frosh")
114+
@auth.oidc_auth("frosh")
115+
def frosh_login():
116+
session["provider"] = "frosh"
117+
return redirect("/packet", code=301)

0 commit comments

Comments
 (0)