ready reporter

Author: neuecc

src/ConsoleAppFramework/ConsoleAppGenerator.cs

@@ -568,10 +568,12 @@ static void EmitConsoleAppRun(SourceProductionContext sourceProductionContext, R
 
         var wellKnownTypes = new WellKnownTypes(model.Compilation);
 
-        var parser = new Parser(sourceProductionContext, node, model, wellKnownTypes, DelegateBuildType.MakeDelegateWhenHasDefaultValue, []);
+        var reporter = new DiagnosticReporter();
+        var parser = new Parser(reporter, node, model, wellKnownTypes, DelegateBuildType.MakeDelegateWhenHasDefaultValue, []);
         var command = parser.ParseAndValidateForRun();
         if (command == null)
         {
+            reporter.ReportToContext(sourceProductionContext);
             return;
         }
         if (command.HasFilter)
@@ -657,12 +659,13 @@ static void EmitConsoleAppBuilder(SourceProductionContext sourceProductionContex
             return;
         }
 
+        var reporter = new DiagnosticReporter();
         var names = new HashSet<string>();
         var commands1 = methodGroup["Add"]
             .Select(x =>
             {
                 var wellKnownTypes = new WellKnownTypes(x.Model.Compilation);
-                var parser = new Parser(sourceProductionContext, x.Node, x.Model, wellKnownTypes, DelegateBuildType.OnlyActionFunc, globalFilters);
+                var parser = new Parser(reporter, x.Node, x.Model, wellKnownTypes, DelegateBuildType.OnlyActionFunc, globalFilters);
                 var command = parser.ParseAndValidateForBuilderDelegateRegistration();
 
                 // validation command name duplicate
@@ -681,7 +684,7 @@ static void EmitConsoleAppBuilder(SourceProductionContext sourceProductionContex
             .SelectMany(x =>
             {
                 var wellKnownTypes = new WellKnownTypes(x.Model.Compilation);
-                var parser = new Parser(sourceProductionContext, x.Node, x.Model, wellKnownTypes, DelegateBuildType.None, globalFilters);
+                var parser = new Parser(reporter, x.Node, x.Model, wellKnownTypes, DelegateBuildType.None, globalFilters);
                 var commands = parser.ParseAndValidateForBuilderClassRegistration();
 
                 // validation command name duplicate
@@ -699,6 +702,12 @@ static void EmitConsoleAppBuilder(SourceProductionContext sourceProductionContex
 
         var commands = commands1.Concat(commands2).ToArray();
 
+        if (reporter.HasDiagnostics)
+        {
+            reporter.ReportToContext(sourceProductionContext);
+            return;
+        }
+
         // don't emit if exists failure(already reported error)
         if (commands.Any(x => x == null))
         {

src/ConsoleAppFramework/DiagnosticDescriptors.cs

@@ -2,14 +2,40 @@
 
 namespace ConsoleAppFramework;
 
+internal sealed class DiagnosticReporter
+{
+    List<Diagnostic>? diagnostics;
+
+    public bool HasDiagnostics => diagnostics != null && diagnostics.Count != 0;
+
+    public void ReportDiagnostic(DiagnosticDescriptor diagnosticDescriptor, Location location, params object?[]? messageArgs)
+    {
+        var diagnostic = Diagnostic.Create(diagnosticDescriptor, location, messageArgs);
+        if (diagnostics == null)
+        {
+            diagnostics = new();
+        }
+        diagnostics.Add(diagnostic);
+    }
+
+    public void ReportToContext(SourceProductionContext context)
+    {
+        if (diagnostics != null)
+        {
+            foreach (var item in diagnostics)
+            {
+                context.ReportDiagnostic(item);
+            }
+        }
+    }
+}
+
 internal static class DiagnosticDescriptors
 {
     const string Category = "GenerateConsoleAppFramework";
 
     public static void ReportDiagnostic(this SourceProductionContext context, DiagnosticDescriptor diagnosticDescriptor, Location location, params object?[]? messageArgs)
     {
-        // must use location.Clone(), incremental cached code + diagnostic craches visual studio however use Clone() can avoid it.
-        location = location.Clone();
         var diagnostic = Diagnostic.Create(diagnosticDescriptor, location, messageArgs);
         context.ReportDiagnostic(diagnostic);
     }

src/ConsoleAppFramework/Parser.cs

@@ -4,7 +4,7 @@
 
 namespace ConsoleAppFramework;
 
-internal class Parser(SourceProductionContext context, InvocationExpressionSyntax node, SemanticModel model, WellKnownTypes wellKnownTypes, DelegateBuildType delegateBuildType, FilterInfo[] globalFilters)
+internal class Parser(DiagnosticReporter context, InvocationExpressionSyntax node, SemanticModel model, WellKnownTypes wellKnownTypes, DelegateBuildType delegateBuildType, FilterInfo[] globalFilters)
 {
     public Command? ParseAndValidateForRun() // for ConsoleApp.Run, lambda or method or &method
     {