don't report CAF008 error on CommunityToolkit.Mvvm.ObservableProperty "Add" calls

Author: neuecc

sandbox/GeneratorSandbox/GeneratorSandbox.csproj

@@ -19,6 +19,7 @@
   <ItemGroup>
     <!--<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="9.0.0" />
 		<PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="9.0.0" />-->
+    <PackageReference Include="CommunityToolkit.Mvvm" Version="8.4.0" />
     <PackageReference Include="Microsoft.Extensions.Hosting" Version="9.0.0" />
     <!--<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="9.0.0" />-->
     <!--<PackageReference Include="ZLogger" Version="2.5.9" />-->

sandbox/GeneratorSandbox/Program.cs

@@ -1,5 +1,6 @@
 #nullable enable
 
+using CommunityToolkit.Mvvm.ComponentModel;
 using ConsoleAppFramework;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Hosting;
@@ -14,7 +15,20 @@
 services.AddSingleton<ITest, Test>();
 services.AddKeyedSingleton<ITest, KeyedTest>("Key");
 
+
+MyObj obj = new();
+while (obj.Data.Count < 1)
+{
+    obj.Data.Add(0); // <-- CAF008 error here
+}
+
 var app = builder.ToConsoleAppBuilder();
+// var app = ConsoleApp.Create();
+//for (int i = 0; i < 10; i++)
+//{
+//    app.Add("foo", (int x) => { });
+//}
+
 app.Run(args);
 
 interface ITest
@@ -42,7 +56,11 @@ public void Run()
     }
 }
 
-
+public partial class MyObj : ObservableObject
+{
+    [ObservableProperty]
+    private List<int> data = [];
+}
 
 
 //args = ["echo", "--msg", "zzzz"];

src/ConsoleAppFramework/ConsoleAppGenerator.cs

@@ -151,11 +151,12 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
                 context.SemanticModel,
                 ct))
             .WithTrackingName("ConsoleApp.Builder.0_CreateSyntaxProvider")
-            .Where(x =>
+            .Select((x, ct) =>
             {
                 var model = x.Model.GetTypeInfo((x.Node.Expression as MemberAccessExpressionSyntax)!.Expression, x.CancellationToken);
-                return model.Type?.Name is "ConsoleAppBuilder" or "IHostBuilder" || model.Type?.Kind == SymbolKind.ErrorType; // allow ErrorType(ConsoleAppBuilder from Configure***(Source Generator generated method) is unknown in Source Generator)
+                return (x, model.Type?.Name, model.Type?.Kind);
             })
+            .Where(x => x.Name is "ConsoleAppBuilder" or "IHostBuilder" || x.Kind == SymbolKind.ErrorType) // allow ErrorType(ConsoleAppBuilder from Configure***(Source Generator generated method) is unknown in Source Generator)
             .WithTrackingName("ConsoleApp.Builder.1_Where")
             .Collect()
             .Combine(generatorOptions)
@@ -353,7 +354,7 @@ class CollectBuilderContext : IEquatable<CollectBuilderContext>
         FilterInfo[]? globalFilters { get; }
         ConsoleAppFrameworkGeneratorOptions generatorOptions { get; }
 
-        public CollectBuilderContext(ConsoleAppFrameworkGeneratorOptions generatorOptions, ImmutableArray<BuilderContext> contexts, CancellationToken cancellationToken)
+        public CollectBuilderContext(ConsoleAppFrameworkGeneratorOptions generatorOptions, ImmutableArray<(BuilderContext, string?, SymbolKind?)> contexts, CancellationToken cancellationToken)
         {
             this.DiagnosticReporter = new DiagnosticReporter();
             this.CancellationToken = cancellationToken;
@@ -362,19 +363,24 @@ public CollectBuilderContext(ConsoleAppFrameworkGeneratorOptions generatorOption
             // validation, invoke in loop is not allowed.
             foreach (var item in contexts)
             {
-                if (item.Name is "Run" or "RunAsync") continue;
-                foreach (var n in item.Node.Ancestors())
+                var (ctx, name, kind) = item;
+                if (kind == SymbolKind.ErrorType) continue; // ErrorType can't distinguished from ConsoleAppFramework or others so ignore all.
+
+                if (ctx.Name is "Run" or "RunAsync") continue;
+                foreach (var n in ctx.Node.Ancestors())
                 {
                     if (n.Kind() is SyntaxKind.WhileStatement or SyntaxKind.DoStatement or SyntaxKind.ForStatement or SyntaxKind.ForEachStatement)
                     {
-                        DiagnosticReporter.ReportDiagnostic(DiagnosticDescriptors.AddInLoopIsNotAllowed, item.Node.GetLocation());
+                        DiagnosticReporter.ReportDiagnostic(DiagnosticDescriptors.AddInLoopIsNotAllowed, ctx.Node.GetLocation());
                         return;
                     }
                 }
             }
 
-            var methodGroup = contexts.ToLookup(x =>
+            var methodGroup = contexts.ToLookup(ctx =>
             {
+                var x = ctx.Item1;
+
                 if (x.Name == "Add" && ((x.Node.Expression as MemberAccessExpressionSyntax)?.Name.IsKind(SyntaxKind.GenericName) ?? false))
                 {
                     return "Add<T>";
@@ -384,6 +390,7 @@ public CollectBuilderContext(ConsoleAppFrameworkGeneratorOptions generatorOption
             });
 
             globalFilters = methodGroup["UseFilter"]
+                .Select(x => x.Item1)
                 .OrderBy(x => x.Node.GetLocation().SourceSpan) // sort by line number
                 .Select(x =>
                 {
@@ -413,6 +420,7 @@ public CollectBuilderContext(ConsoleAppFrameworkGeneratorOptions generatorOption
 
             var names = new HashSet<string>();
             var commands1 = methodGroup["Add"]
+                .Select(x => x.Item1)
                 .Select(x =>
                 {
                     var wellKnownTypes = new WellKnownTypes(x.Model.Compilation);
@@ -432,6 +440,7 @@ public CollectBuilderContext(ConsoleAppFrameworkGeneratorOptions generatorOption
                 .ToArray(); // evaluate first.
 
             var commands2 = methodGroup["Add<T>"]
+                .Select(x => x.Item1)
                 .SelectMany(x =>
                 {
                     var wellKnownTypes = new WellKnownTypes(x.Model.Compilation);