Skip to content

Commit 54770a5

Browse files
committed
logger and interceptor method names changed
1 parent 7b2d34c commit 54770a5

File tree

8 files changed

+191
-271
lines changed

8 files changed

+191
-271
lines changed

ReadMe.md

Lines changed: 149 additions & 231 deletions
Large diffs are not rendered by default.

src/ConsoleAppFramework.WebHosting/ConsoleAppFrameworkHostingExtensions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public void Configure(IApplicationBuilder app, IHostApplicationLifetime lifetime
7979
{
8080
try
8181
{
82-
await interceptor.OnConsoleAppEngineBeginAsync(provider, logger);
82+
await interceptor.OnEngineBeginAsync(provider, logger);
8383
}
8484
catch { }
8585
});
@@ -88,7 +88,7 @@ public void Configure(IApplicationBuilder app, IHostApplicationLifetime lifetime
8888
{
8989
try
9090
{
91-
await interceptor.OnConsoleAppEngineEndAsync();
91+
await interceptor.OnMethodEndAsync();
9292
}
9393
catch { }
9494
});

src/ConsoleAppFramework.WebHosting/ConsoleAppFrameworkMiddleware.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,27 +22,27 @@ public WebHostingInterceptor(IConsoleAppInterceptor innerInterceptor)
2222
this.innerInterceptor = innerInterceptor;
2323
}
2424

25-
public ValueTask OnConsoleAppEngineBeginAsync(IServiceProvider serviceProvider, ILogger<ConsoleAppEngine> logger)
25+
public ValueTask OnEngineBeginAsync(IServiceProvider serviceProvider, ILogger<ConsoleAppEngine> logger)
2626
{
27-
return innerInterceptor.OnConsoleAppEngineBeginAsync(serviceProvider, logger);
27+
return innerInterceptor.OnEngineBeginAsync(serviceProvider, logger);
2828
}
2929

30-
public ValueTask OnConsoleAppEngineEndAsync()
30+
public ValueTask OnMethodEndAsync()
3131
{
32-
return innerInterceptor.OnConsoleAppEngineEndAsync();
32+
return innerInterceptor.OnMethodEndAsync();
3333
}
3434

35-
public ValueTask OnConsoleAppRunBeginAsync(ConsoleAppContext context)
35+
public ValueTask OnMethodBeginAsync(ConsoleAppContext context)
3636
{
37-
return innerInterceptor.OnConsoleAppRunBeginAsync(context);
37+
return innerInterceptor.OnMethodBeginAsync(context);
3838
}
3939

40-
public ValueTask OnConsoleAppRunCompleteAsync(ConsoleAppContext context, string? errorMessageIfFailed, Exception? exceptionIfExists)
40+
public ValueTask OnEngineCompleteAsync(ConsoleAppContext context, string? errorMessageIfFailed, Exception? exceptionIfExists)
4141
{
4242
this.CompleteSuccessfully = (errorMessageIfFailed == null && exceptionIfExists == null);
4343
this.ErrorMessage = errorMessageIfFailed;
4444
this.Exception = exceptionIfExists;
45-
return innerInterceptor.OnConsoleAppRunCompleteAsync(context, errorMessageIfFailed, exceptionIfExists);
45+
return innerInterceptor.OnEngineCompleteAsync(context, errorMessageIfFailed, exceptionIfExists);
4646
}
4747
}
4848

src/ConsoleAppFramework/CompositeConsoleAppInterceptor.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ public CompositeConsoleAppInterceptor(params IConsoleAppInterceptor[] intercepto
1616
this.interceptors = interceptors;
1717
}
1818

19-
public async ValueTask OnConsoleAppEngineBeginAsync(IServiceProvider serviceProvider, ILogger<ConsoleAppEngine> logger)
19+
public async ValueTask OnEngineBeginAsync(IServiceProvider serviceProvider, ILogger<ConsoleAppEngine> logger)
2020
{
2121
var exceptions = new AggregateExceptionHolder();
2222
foreach (var item in interceptors)
2323
{
2424
try
2525
{
26-
await item.OnConsoleAppEngineBeginAsync(serviceProvider, logger);
26+
await item.OnEngineBeginAsync(serviceProvider, logger);
2727
}
2828
catch (Exception e)
2929
{
@@ -33,14 +33,14 @@ public async ValueTask OnConsoleAppEngineBeginAsync(IServiceProvider serviceProv
3333
exceptions.ThrowIfExists();
3434
}
3535

36-
public async ValueTask OnConsoleAppEngineEndAsync()
36+
public async ValueTask OnMethodEndAsync()
3737
{
3838
var exceptions = new AggregateExceptionHolder();
3939
foreach (var item in interceptors)
4040
{
4141
try
4242
{
43-
await item.OnConsoleAppEngineEndAsync();
43+
await item.OnMethodEndAsync();
4444
}
4545
catch (Exception e)
4646
{
@@ -50,14 +50,14 @@ public async ValueTask OnConsoleAppEngineEndAsync()
5050
exceptions.ThrowIfExists();
5151
}
5252

53-
public async ValueTask OnConsoleAppRunBeginAsync(ConsoleAppContext context)
53+
public async ValueTask OnMethodBeginAsync(ConsoleAppContext context)
5454
{
5555
var exceptions = new AggregateExceptionHolder();
5656
foreach (var item in interceptors)
5757
{
5858
try
5959
{
60-
await item.OnConsoleAppRunBeginAsync(context);
60+
await item.OnMethodBeginAsync(context);
6161
}
6262
catch (Exception e)
6363
{
@@ -67,14 +67,14 @@ public async ValueTask OnConsoleAppRunBeginAsync(ConsoleAppContext context)
6767
exceptions.ThrowIfExists();
6868
}
6969

70-
public async ValueTask OnConsoleAppRunCompleteAsync(ConsoleAppContext context, string? errorMessageIfFailed, Exception? exceptionIfExists)
70+
public async ValueTask OnEngineCompleteAsync(ConsoleAppContext context, string? errorMessageIfFailed, Exception? exceptionIfExists)
7171
{
7272
var exceptions = new AggregateExceptionHolder();
7373
foreach (var item in interceptors)
7474
{
7575
try
7676
{
77-
await item.OnConsoleAppRunCompleteAsync(context, errorMessageIfFailed, exceptionIfExists);
77+
await item.OnEngineCompleteAsync(context, errorMessageIfFailed, exceptionIfExists);
7878
}
7979
catch (Exception e)
8080
{

src/ConsoleAppFramework/ConsoleAppEngine.cs

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public async Task RunAsync(Type type, string[] args)
4242
var ctx = new ConsoleAppContext(args, DateTime.UtcNow, cancellationToken, logger);
4343
try
4444
{
45-
await interceptor.OnConsoleAppRunBeginAsync(ctx);
45+
await interceptor.OnMethodBeginAsync(ctx);
4646

4747
if (type == typeof(void))
4848
{
@@ -181,26 +181,28 @@ async Task RunCore(ConsoleAppContext ctx, Type type, MethodInfo methodInfo, stri
181181
}
182182
}
183183

184-
await interceptor.OnConsoleAppRunCompleteAsync(ctx, null, null);
184+
await interceptor.OnEngineCompleteAsync(ctx, null, null);
185185
logger.LogTrace("ConsoleAppEngine.Run Complete Successfully");
186186
}
187187

188188
async ValueTask SetFailAsync(ConsoleAppContext context, string message)
189189
{
190190
Environment.ExitCode = 1;
191191
logger.LogError(message);
192-
await interceptor.OnConsoleAppRunCompleteAsync(context, message, null);
192+
await interceptor.OnEngineCompleteAsync(context, message, null);
193193
}
194194

195195
async ValueTask SetFailAsync(ConsoleAppContext context, string message, Exception ex)
196196
{
197197
Environment.ExitCode = 1;
198198
logger.LogError(ex, message);
199-
await interceptor.OnConsoleAppRunCompleteAsync(context, message, ex);
199+
await interceptor.OnEngineCompleteAsync(context, message, ex);
200200
}
201201

202-
static bool TryGetInvokeArguments(ParameterInfo[] parameters, string?[] args, int argsOffset, out object[] invokeArgs, out string? errorMessage)
202+
bool TryGetInvokeArguments(ParameterInfo[] parameters, string?[] args, int argsOffset, out object[] invokeArgs, out string? errorMessage)
203203
{
204+
var jsonOption = (JsonSerializerOptions)provider.GetService(typeof(JsonSerializerOptions));
205+
204206
var argumentDictionary = ParseArgument(args, argsOffset);
205207
invokeArgs = new object[parameters.Length];
206208

@@ -268,7 +270,7 @@ static bool TryGetInvokeArguments(ParameterInfo[] parameters, string?[] args, in
268270
}
269271
try
270272
{
271-
invokeArgs[i] = JsonSerializer.Deserialize(v, parameters[i].ParameterType);
273+
invokeArgs[i] = JsonSerializer.Deserialize(v, parameters[i].ParameterType, jsonOption);
272274
continue;
273275
}
274276
catch
@@ -281,7 +283,7 @@ static bool TryGetInvokeArguments(ParameterInfo[] parameters, string?[] args, in
281283
{
282284
try
283285
{
284-
invokeArgs[i] = JsonSerializer.Deserialize(value.Value, parameters[i].ParameterType);
286+
invokeArgs[i] = JsonSerializer.Deserialize(value.Value, parameters[i].ParameterType, jsonOption);
285287
continue;
286288
}
287289
catch

src/ConsoleAppFramework/ConsoleAppEngineHostBuilderExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ IHostBuilder ConfigureEmptyService()
6161

6262
if (methodIndex != -1)
6363
{
64-
var (t, mi) = GetTypeFromAssemblies(args[1], null);
64+
var (t, mi) = GetTypeFromAssemblies(args[methodIndex], null);
6565
if (mi != null)
6666
{
6767
Console.Write(new CommandHelpBuilder().BuildHelpMessage(mi, showCommandName: true));

src/ConsoleAppFramework/ConsoleAppEngineService.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public ConsoleAppEngineService(IHostApplicationLifetime appLifetime, Type type,
3939

4040
public async Task StartAsync(CancellationToken cancellationToken)
4141
{
42-
await interceptor.OnConsoleAppEngineBeginAsync(scope.ServiceProvider, logger);
42+
await interceptor.OnEngineBeginAsync(scope.ServiceProvider, logger);
4343

4444
// raise after all event registered
4545
appLifetime.ApplicationStarted.Register(async state =>
@@ -84,7 +84,7 @@ public async Task StopAsync(CancellationToken cancellationToken)
8484
}
8585
finally
8686
{
87-
await interceptor.OnConsoleAppEngineEndAsync();
87+
await interceptor.OnMethodEndAsync();
8888
scope.Dispose();
8989
}
9090
}

src/ConsoleAppFramework/IConsoleAppInterceptor.cs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,47 +7,47 @@ namespace ConsoleAppFramework
77
public interface IConsoleAppInterceptor
88
{
99
/// <summary>
10-
/// Called once when ConsoleAppEngineService is stareted.
10+
/// Called once when ConsoleAppFramework is stareted.
1111
/// </summary>
12-
ValueTask OnConsoleAppEngineBeginAsync(IServiceProvider serviceProvider, ILogger<ConsoleAppEngine> logger);
12+
ValueTask OnEngineBeginAsync(IServiceProvider serviceProvider, ILogger<ConsoleAppEngine> logger);
1313

1414
/// <summary>
15-
/// Called once when ConsoleAppEngineService is finished.
15+
/// Called when ConsoleAppMethod is called.
1616
/// </summary>
17-
ValueTask OnConsoleAppEngineEndAsync();
17+
ValueTask OnMethodBeginAsync(ConsoleAppContext context);
1818

1919
/// <summary>
20-
/// Called when ConsoleAppMethod is called.
20+
/// Called once when ConsoleAppMethod is finished.
2121
/// </summary>
22-
ValueTask OnConsoleAppRunBeginAsync(ConsoleAppContext context);
22+
ValueTask OnMethodEndAsync();
2323

2424
/// <summary>
25-
/// Called when ConsoleAppMethod is error or completed.
25+
/// Called when ConsoleAppFramework is error or completed.
2626
/// </summary>
27-
ValueTask OnConsoleAppRunCompleteAsync(ConsoleAppContext context, string? errorMessageIfFailed, Exception? exceptionIfExists);
27+
ValueTask OnEngineCompleteAsync(ConsoleAppContext context, string? errorMessageIfFailed, Exception? exceptionIfExists);
2828
}
2929

3030
public class NullConsoleAppInterceptor : IConsoleAppInterceptor
3131
{
3232
public static readonly IConsoleAppInterceptor Default = new NullConsoleAppInterceptor();
3333
readonly ValueTask Empty = default(ValueTask);
3434

35-
public ValueTask OnConsoleAppEngineBeginAsync(IServiceProvider serviceProvider, ILogger<ConsoleAppEngine> logger)
35+
public ValueTask OnEngineBeginAsync(IServiceProvider serviceProvider, ILogger<ConsoleAppEngine> logger)
3636
{
3737
return Empty;
3838
}
3939

40-
public ValueTask OnConsoleAppEngineEndAsync()
40+
public ValueTask OnMethodEndAsync()
4141
{
4242
return Empty;
4343
}
4444

45-
public ValueTask OnConsoleAppRunBeginAsync(ConsoleAppContext context)
45+
public ValueTask OnMethodBeginAsync(ConsoleAppContext context)
4646
{
4747
return Empty;
4848
}
4949

50-
public ValueTask OnConsoleAppRunCompleteAsync(ConsoleAppContext context, string? errorMessageIfFailed, Exception? exceptionIfExists)
50+
public ValueTask OnEngineCompleteAsync(ConsoleAppContext context, string? errorMessageIfFailed, Exception? exceptionIfExists)
5151
{
5252
return Empty;
5353
}

0 commit comments

Comments
 (0)