Run to new style

Author: neuecc

src/ConsoleAppFramework/Command.cs

@@ -144,8 +144,8 @@ public string BuildDelegateType(string delegateName)
 public record class CommandParameter
 {
     public required EquatableTypeSymbol Type { get; init; }
-    public required Location Location { get; init; }
-    public required WellKnownTypes WellKnownTypes { get; init; }
+    public required IgnoreEquality<Location> Location { get; init; }
+    public required IgnoreEquality<WellKnownTypes> WellKnownTypes { get; init; }
     public required bool IsNullableReference { get; init; }
     public required bool IsParams { get; init; }
     public required string Name { get; init; }
@@ -238,7 +238,7 @@ string Core(ITypeSymbol type, bool nullable)
                     if (type.TypeKind == TypeKind.Array)
                     {
                         var elementType = (type as IArrayTypeSymbol)!.ElementType;
-                        var parsable = WellKnownTypes.ISpanParsable;
+                        var parsable = WellKnownTypes.Value.ISpanParsable;
                         if (parsable != null) // has parsable
                         {
                             if (elementType.AllInterfaces.Any(x => x.EqualsUnconstructedGenericType(parsable)))
@@ -250,12 +250,12 @@ string Core(ITypeSymbol type, bool nullable)
                     }
 
                     // System.DateTimeOffset, System.Guid,  System.Version
-                    tryParseKnownPrimitive = WellKnownTypes.HasTryParse(type);
+                    tryParseKnownPrimitive = WellKnownTypes.Value.HasTryParse(type);
 
                     if (!tryParseKnownPrimitive)
                     {
                         // ISpanParsable<T> (BigInteger, Complex, Half, Int128, etc...)
-                        var parsable = WellKnownTypes.ISpanParsable;
+                        var parsable = WellKnownTypes.Value.ISpanParsable;
                         if (parsable != null) // has parsable
                         {
                             tryParseIParsable = type.AllInterfaces.Any(x => x.EqualsUnconstructedGenericType(parsable));
@@ -312,13 +312,6 @@ public string DefaultValueToString(bool castValue = true, bool enumIncludeTypeNa
         return $"({Type.ToFullyQualifiedFormatDisplayString()}){DefaultValue}";
     }
 
-    public string? GetEnumSymbolName(object value)
-    {
-        var symbol = Type.GetMembers().OfType<IFieldSymbol>().FirstOrDefault(x => x.ConstantValue == value);
-        if (symbol == null) return "";
-        return symbol.Name;
-    }
-
     public string ToTypeDisplayString()
     {
         var t = Type.ToFullyQualifiedFormatDisplayString();

src/ConsoleAppFramework/ConsoleAppGenerator.cs

@@ -36,7 +36,17 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
                 }
 
                 return false;
-            }, (context, ct) => new RunContext((InvocationExpressionSyntax)context.Node, context.SemanticModel))
+            }, (context, ct) =>
+            {
+                var reporter = new DiagnosticReporter();
+                var node = (InvocationExpressionSyntax)context.Node;
+                var wellknownTypes = new WellKnownTypes(context.SemanticModel.Compilation);
+                var parser = new Parser(reporter, node, context.SemanticModel, wellknownTypes, DelegateBuildType.MakeDelegateWhenHasDefaultValue, []);
+                var isRunAsync = (node.Expression as MemberAccessExpressionSyntax)?.Name.Identifier.Text == "RunAsync";
+
+                var command = parser.ParseAndValidateForRun();
+                return new CommandContext(command, isRunAsync, reporter, node);
+            })
             .WithTrackingName("ConsoleApp.Run.0_CreateSyntaxProvider"); // annotate for IncrementalGeneratorTest
 
         context.RegisterSourceOutput(runSource, EmitConsoleAppRun);
@@ -561,36 +571,29 @@ namespace ConsoleAppFramework;
 
 """;
 
-    static void EmitConsoleAppRun(SourceProductionContext sourceProductionContext, RunContext runNode)
+    static void EmitConsoleAppRun(SourceProductionContext sourceProductionContext, CommandContext commandContext)
     {
-        var node = runNode.Node;
-        var model = runNode.SemanticModel;
-
-        var wellKnownTypes = new WellKnownTypes(model.Compilation);
-
-        var reporter = new DiagnosticReporter();
-        var parser = new Parser(reporter, node, model, wellKnownTypes, DelegateBuildType.MakeDelegateWhenHasDefaultValue, []);
-        var command = parser.ParseAndValidateForRun();
-        if (command == null)
+        if (commandContext.DiagnosticReporter.HasDiagnostics)
         {
-            reporter.ReportToContext(sourceProductionContext);
+            commandContext.DiagnosticReporter.ReportToContext(sourceProductionContext);
             return;
         }
+        var command = commandContext.Command;
+        if (command == null) return;
+
         if (command.HasFilter)
         {
-            sourceProductionContext.ReportDiagnostic(DiagnosticDescriptors.CommandHasFilter, node.GetLocation());
+            sourceProductionContext.ReportDiagnostic(DiagnosticDescriptors.CommandHasFilter, commandContext.Node.GetLocation());
             return;
         }
 
-        var isRunAsync = ((node.Expression as MemberAccessExpressionSyntax)?.Name.Identifier.Text == "RunAsync");
-
         var sb = new SourceBuilder(0);
         sb.AppendLine(GeneratedCodeHeader);
         using (sb.BeginBlock("internal static partial class ConsoleApp"))
         {
             var emitter = new Emitter();
             var withId = new Emitter.CommandWithId(null, command, -1);
-            emitter.EmitRun(sb, withId, isRunAsync);
+            emitter.EmitRun(sb, withId, command.IsAsync);
         }
         sourceProductionContext.AddSource("ConsoleApp.Run.g.cs", sb.ToString());
 
@@ -756,19 +759,20 @@ static void EmitConsoleAppBuilder(SourceProductionContext sourceProductionContex
         sourceProductionContext.AddSource("ConsoleApp.Builder.Help.g.cs", help.ToString());
     }
 
-    class CommandContext(Command command, bool isAsync, DiagnosticReporter diagnosticReporter) : IEquatable<CommandContext>
+    class CommandContext(Command? command, bool isAsync, DiagnosticReporter diagnosticReporter, InvocationExpressionSyntax node) : IEquatable<CommandContext>
     {
-        public Command Command => command;
+        public Command? Command => command;
         public DiagnosticReporter DiagnosticReporter => diagnosticReporter;
+        public InvocationExpressionSyntax Node => node;
         public bool IsAsync => isAsync;
 
         public bool Equals(CommandContext other)
         {
             // has diagnostics, always go to modified(don't cache)
             if (diagnosticReporter.HasDiagnostics || other.DiagnosticReporter.HasDiagnostics) return false;
+            if (command == null || other.Command == null) return false; // maybe has diagnostics
 
             if (isAsync != other.IsAsync) return false;
-
             return command.Equals(other.Command);
         }
     }

src/ConsoleAppFramework/EquatableTypeSymbol.cs

@@ -5,20 +5,24 @@ namespace ConsoleAppFramework;
 
 public class EquatableTypeSymbol(ITypeSymbol typeSymbol) : IEquatable<EquatableTypeSymbol>
 {
-    // check this two types usage for Equality
+    // Used for build argument parser, maybe ok to equals name.
     public ITypeSymbol TypeSymbol => typeSymbol;
+
+    // GetMembers is called for Enum and fields is not condition for command equality.
     public ImmutableArray<ISymbol> GetMembers() => typeSymbol.GetMembers();
 
     public TypeKind TypeKind { get; } = typeSymbol.TypeKind;
     public SpecialType SpecialType { get; } = typeSymbol.SpecialType;
 
-
     public string ToFullyQualifiedFormatDisplayString() => typeSymbol.ToFullyQualifiedFormatDisplayString();
     public string ToDisplayString(NullableFlowState state, SymbolDisplayFormat format) => typeSymbol.ToDisplayString(state, format);
 
     public bool Equals(EquatableTypeSymbol other)
     {
-        // TODO:
-        return false;
+        if (this.TypeKind != other.TypeKind) return false;
+        if (this.SpecialType != other.SpecialType) return false;
+        if (this.TypeSymbol.Name != other.TypeSymbol.Name) return false;
+
+        return this.TypeSymbol.EqualsNamespaceAndName(other.TypeSymbol);
     }
 }

src/ConsoleAppFramework/IgnoreEquality.cs

@@ -0,0 +1,22 @@
+namespace ConsoleAppFramework;
+
+public readonly struct IgnoreEquality<T>(T value) : IEquatable<IgnoreEquality<T>>
+{
+    public readonly T Value => value;
+
+    public static implicit operator IgnoreEquality<T>(T value)
+    {
+        return new IgnoreEquality<T>(value);
+    }
+
+    public static implicit operator T(IgnoreEquality<T> value)
+    {
+        return value.Value;
+    }
+
+    public bool Equals(IgnoreEquality<T> other)
+    {
+        // always true to ignore equality check.
+        return true;
+    }
+}

tests/ConsoleAppFramework.GeneratorTests/IncrementalGeneratorTest.cs

@@ -54,6 +54,7 @@ public void RunLambda()
         reasons[2][0].Reasons.Should().Be("Modified");
 
         VerifySourceOutputReasonIsCached(reasons[1]);
+        VerifySourceOutputReasonIsNotCached(reasons[2]);
     }
 
     [Fact]