Address option parsing review feedback

Author: dusrdev

src/ConsoleAppFramework/Emitter.cs

@@ -144,8 +144,14 @@ public void EmitRun(SourceBuilder sb, CommandWithId commandWithId, bool isRunAsy
                 using (sb.BeginBlock("for (int i = 0; i < commandArgs.Length; i++)"))
                 {
                     sb.AppendLine("var name = commandArgs[i];");
-                    sb.AppendLine("var optionMatched = false;");
-                    sb.AppendLine("var optionCandidate = name.Length > 1 && name[0] == '-' && !char.IsDigit(name[1]);");
+                    if (hasArgument)
+                    {
+                        sb.AppendLine("var optionCandidate = name.Length > 1 && name[0] == '-' && !char.IsDigit(name[1]);");
+                    }
+                    else
+                    {
+                        sb.AppendLine("var optionCandidate = name.Length > 1 && name[0] == '-';");
+                    }
                     sb.AppendLine();
 
                     if (!command.Parameters.All(p => !p.IsParsable || p.IsArgument))
@@ -173,8 +179,7 @@ public void EmitRun(SourceBuilder sb, CommandWithId commandWithId, bool isRunAsy
                                         {
                                             sb.AppendLine($"arg{i}Parsed = true;");
                                         }
-                                        sb.AppendLine("optionMatched = true;");
-                                        sb.AppendLine("break;");
+                                        sb.AppendLine("continue;");
                                     }
                                 }
 
@@ -200,21 +205,14 @@ public void EmitRun(SourceBuilder sb, CommandWithId commandWithId, bool isRunAsy
                                             {
                                                 sb.AppendLine($"arg{i}Parsed = true;");
                                             }
-                                            sb.AppendLine("optionMatched = true;");
-                                            sb.AppendLine($"break;");
+                                            sb.AppendLine("continue;");
                                         }
                                     }
 
                                     sb.AppendLine("ThrowArgumentNameNotFound(name);");
                                     sb.AppendLine("break;");
                                 }
                             }
-
-                            sb.AppendLine("if (optionMatched)");
-                            using (sb.BeginBlock())
-                            {
-                                sb.AppendLine("continue;");
-                            }
                         }
                     }
 
@@ -241,7 +239,10 @@ public void EmitRun(SourceBuilder sb, CommandWithId commandWithId, bool isRunAsy
                         sb.AppendLine();
                     }
 
-                    sb.AppendLine("ThrowArgumentNameNotFound(name);");
+                    if (hasArgument)
+                    {
+                        sb.AppendLine("ThrowArgumentNameNotFound(name);");
+                    }
                 }
 
                 // validate parsed

tests/ConsoleAppFramework.GeneratorTests/RunTest.cs

@@ -66,6 +66,20 @@ public void OptionTokenHandlesParamsArguments()
         verifier.Execute(code, "--dry-run path.txt", "True:path.txt:");
     }
 
+    [Fact]
+    public void ArgumentAllowsLeadingDashValue()
+    {
+        var code = """
+ConsoleApp.Run(args, ([Argument] int count, bool dryRun) =>
+{
+    Console.Write((count, dryRun).ToString());
+});
+""";
+
+        verifier.Execute(code, "-5 --dry-run", "(-5, True)");
+        verifier.Execute(code, "-5", "(-5, False)");
+    }
+
     [Fact]
     public void SyncRunShouldFailed()
     {
@@ -75,7 +89,7 @@ public void SyncRunShouldFailed()
     [Fact]
     public void MissingArgument()
     {
-        verifier.Error("ConsoleApp.Run(args, (int x, int y) => { Console.Write((x + y)); });", "--x 10 y 20").ShouldContain("Argument 'y' is not recognized.");
+        verifier.Error("ConsoleApp.Run(args, (int x, int y) => { Console.Write((x + y)); });", "--x 10 y 20").ShouldContain("Required argument 'y' was not specified.");
 
         Environment.ExitCode.ShouldBe(1);
         Environment.ExitCode = 0;