Skip to content

Commit 365ebb8

Browse files
jdamerowjdamerow
committed
Added citationet review and restructured recent reviews
1 parent 063a90b commit 365ebb8

8 files changed

+77
-36
lines changed

‎_config.yml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ url: "" # the base hostname & protocol for your site, e.g. http://example.com
2929
twitter_username: jekyllrb
3030
github_username: jekyll
3131

32+
collections:
33+
- reviews
34+
3235
# Build settings
3336
theme: minima
3437
plugins:

‎_reviews/2022/2022-04-20-oimdp-raff.md‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
---
2+
layout: review
3+
pull_request: "https://github.com/DHCodeReview/oimdp/pull/1"
4+
title: "oimdp: OpenITI mARkdown Parser"
5+
submitters: ["Raff Viglianti (University of Maryland)"]
6+
reviewers: ["Malte Vogl"]
7+
facilitator:
8+
date: 2022-04-20
9+
year: 2022
10+
---

‎_reviews/2022/2022-05-27-SemanticLayerTools-malte.md‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
---
2+
layout: review
3+
pull_request: "https://github.com/DHCodeReview/SemanticLayerTools/pull/1"
4+
title: "SemanticLayerTools"
5+
submitters: ["Malte Vogl (Max Planck Institute for the History of Science)"]
6+
reviewers: ["Itay Zandbank"]
7+
facilitator:
8+
date: 2022-06-27
9+
year: 2022
10+
---

‎_reviews/2022/2022-06-08-pydistinto-keli.md‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
---
2+
layout: review
3+
pull_request: "https://github.com/DHCodeReview/pydistinto/pull/1"
4+
title: "Pydistinto"
5+
submitters: ["Keli Du (Trier Center for Digital Humanities)"]
6+
reviewers: ["Moritz Mähr"]
7+
facilitator:
8+
date: 2022-06-08
9+
year: 2022
10+
---

‎_reviews/2023/2023-09-14-lenape-timetree-rebecca.md‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
---
2+
layout: review
3+
pull_request: "https://github.com/DHCodeReview/lenape-timetree/pull/2"
4+
title: "Lunaapahkiing Princeton Timetree"
5+
submitters: ["Rebecca S. Koeser"]
6+
reviewers: ["Cole Crawford", "Raffaele Viglianti"]
7+
facilitator: Julia Damerow
8+
date: 2023-09-14
9+
year: 2023
10+
---

‎_reviews/2024/2024-05-21-simulating-risk-rebecca.md‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
---
2+
layout: review
3+
pull_request: "https://github.com/DHCodeReview/simulating-risk/pull/1"
4+
title: Simulating Risk
5+
submitters: ["Rebecca Sutton Koeser (Princeton University)"]
6+
reviewers: ["Scott Foster (Arizona State University)", "Malte Vogl (Max Planck Institute of Geoanthropology)"]
7+
facilitator: Cole Crawford (Harvard University)
8+
date: 2024-05-21
9+
year: 2024
10+
---

‎_reviews/2024/2024-07-25-citationnet-malte.md‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
---
2+
layout: review
3+
pull_request: "https://github.com/DHCodeReview/citationnet/pull/1"
4+
title: Citationnet
5+
submitters: ["Malte Vogl (Max Planck Institute of Geoanthropology)"]
6+
reviewers: ["Rebecca S. Koeser (Princeton University)", "Raffaele Viglianti (University of Maryland)"]
7+
facilitator: Julia Damerow (Arizona State University)
8+
date: 2024-07-01
9+
year: 2024
10+
---

‎recent-reviews.html‎

Lines changed: 14 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -4,42 +4,20 @@
44
<h1>Recent Code Reviews</h1>
55

66
We have started the alpha phase of a community code review process. Below is a list of some of the reviews that were conducted.
7-
<hr>
8-
<h2>2024</h2>
9-
<ul class="list-group list-group-flush">
10-
<li class="list-group-item">
11-
<a href="https://github.com/DHCodeReview/simulating-risk/pull/1">Simulating Risk</a>
12-
<br>Submitter: Rebecca Sutton Koeser (Princeton University)
13-
<br>Reviewers: Scott Foster, Malte Vogl
14-
<br>Facilitator: Cole Crawford
15-
</li>
16-
</ul>
17-
<hr>
18-
<h2>2023</h2>
19-
<ul class="list-group list-group-flush">
20-
<li class="list-group-item">
21-
<a href="https://github.com/DHCodeReview/lenape-timetree/pull/2">Lunaapahkiing Princeton Timetree</a>
22-
<br>Submitter: Rebecca Sutton Koeser (Princeton University)
23-
<br>Reviewers: Cole Crawford, Raffaele Viglianti
24-
<br>Facilitator: Julia Damerow
25-
</li>
26-
</ul>
27-
<hr>
28-
<h2>2022</h2>
29-
<ul class="list-group list-group-flush">
30-
<li class="list-group-item">
31-
<a href="https://github.com/DHCodeReview/oimdp/pull/1">oimdp: OpenITI mARkdown Parser</a>
32-
<br>Submitter: Raff Viglianti (University of Maryland)
33-
<br>Reviewer: Malte Vogl
34-
</li>
35-
<li class="list-group-item">
36-
<a href="https://github.com/DHCodeReview/pydistinto/pull/1">Pydistinto</a>
37-
<br>Submitter: Keli Du (Trier Center for Digital Humanities)
38-
<br>Reviewer: Moritz Mähr
39-
</li>
7+
8+
{% assign years = site.reviews | group_by: 'year' | sort: 'date' | reverse %}
9+
{% for year in years %}
10+
<hr>
11+
<h2>{{ year.name }}</h2>
12+
<ul class="list-group list-group-flush">
13+
{% assign reviews = year.items | sort: 'date' | reverse %}
14+
{% for review in reviews %}
4015
<li class="list-group-item">
41-
<a href="https://github.com/DHCodeReview/SemanticLayerTools/pull/1">SemanticLayerTools</a>
42-
<br>Submitter: Malte Vogl (Max Planck Institute for the History of Science)
43-
<br>Reviewer: Itay Zandbank
16+
<a href="{{review.pull_request}}">{{review.title}}</a>
17+
<br>Submitter: {{ review.submitters | join:", " }}
18+
<br>Reviewer: {{ review.reviewers | join:", " }}
19+
{% if review.facilitator %}<br>Facilitator: {{review.facilitator}}{% endif %}
4420
</li>
21+
{% endfor %}
4522
</ul>
23+
{% endfor %}

0 commit comments

Comments
 (0)