From 95f5808142f70558dce1dd2697744d171141adf9 Mon Sep 17 00:00:00 2001 From: Douglas Q Hawkins Date: Wed, 10 Dec 2025 17:29:14 -0500 Subject: [PATCH 1/2] A bit of clean-up - Making empty final -- and static even though static is redundant here - Removing unnecessary package qualification on forEach --- internal-api/src/main/java/datadog/trace/api/TagMap.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/internal-api/src/main/java/datadog/trace/api/TagMap.java b/internal-api/src/main/java/datadog/trace/api/TagMap.java index 1166a2ebcfa..9c85a362a26 100644 --- a/internal-api/src/main/java/datadog/trace/api/TagMap.java +++ b/internal-api/src/main/java/datadog/trace/api/TagMap.java @@ -45,7 +45,7 @@ */ public interface TagMap extends Map, Iterable { /** Immutable empty TagMap - similar to {@link Collections#emptyMap()} */ - TagMap EMPTY = TagMapFactory.INSTANCE.empty(); + static final TagMap EMPTY = TagMapFactory.INSTANCE.empty(); /** Creates a new mutable TagMap that contains the contents of map */ static TagMap fromMap(Map map) { @@ -2688,7 +2688,7 @@ public void fillStringMap(Map stringMap) { } @Override - public void forEach(Consumer consumer) { + public void forEach(Consumer consumer) { for (Map.Entry entry : this.entrySet()) { consumer.accept(TagMap.Entry.newAnyEntry(entry)); } @@ -2696,7 +2696,7 @@ public void forEach(Consumer consumer) { @Override public void forEach( - T thisObj, BiConsumer consumer) { + T thisObj, BiConsumer consumer) { for (Map.Entry entry : this.entrySet()) { consumer.accept(thisObj, TagMap.Entry.newAnyEntry(entry)); } @@ -2704,7 +2704,7 @@ public void forEach( @Override public void forEach( - T thisObj, U otherObj, TriConsumer consumer) { + T thisObj, U otherObj, TriConsumer consumer) { for (Map.Entry entry : this.entrySet()) { consumer.accept(thisObj, otherObj, TagMap.Entry.newAnyEntry(entry)); } From 79092b09bc346dee1e234a9747384a5acb27b5ff Mon Sep 17 00:00:00 2001 From: Douglas Q Hawkins Date: Thu, 11 Dec 2025 08:27:05 -0500 Subject: [PATCH 2/2] spotless --- internal-api/src/main/java/datadog/trace/api/TagMap.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/internal-api/src/main/java/datadog/trace/api/TagMap.java b/internal-api/src/main/java/datadog/trace/api/TagMap.java index 9c85a362a26..c10904f6b3b 100644 --- a/internal-api/src/main/java/datadog/trace/api/TagMap.java +++ b/internal-api/src/main/java/datadog/trace/api/TagMap.java @@ -2695,8 +2695,7 @@ public void forEach(Consumer consumer) { } @Override - public void forEach( - T thisObj, BiConsumer consumer) { + public void forEach(T thisObj, BiConsumer consumer) { for (Map.Entry entry : this.entrySet()) { consumer.accept(thisObj, TagMap.Entry.newAnyEntry(entry)); }