From 72ff6f65fd113ef5d020ffe241e22ba419089ed3 Mon Sep 17 00:00:00 2001 From: Valentijn Scholten Date: Thu, 22 Jan 2026 19:56:07 +0100 Subject: [PATCH] Change pghistory backfill log level from ERROR to DEBUG for missing event tables When migration 0250 runs before migration 0256 creates the tags event tables, it logs ERROR messages for missing tables. These are expected during migration sequencing and should be DEBUG level instead. Changes: - Update auditlog.py to log at DEBUG level when event tables don't exist - Update progress_callback functions in migrations 0250 and 0257 to handle DEBUG level --- dojo/auditlog.py | 13 +++++++++++-- dojo/db_migrations/0250_pghistory_backfill.py | 2 ++ dojo/db_migrations/0257_pghistory_tags_backfill.py | 2 ++ 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/dojo/auditlog.py b/dojo/auditlog.py index 5221ccd1dbc..1f4fd4783bc 100644 --- a/dojo/auditlog.py +++ b/dojo/auditlog.py @@ -774,7 +774,16 @@ def process_model_backfill( """ if progress_callback is None: def progress_callback(msg, style=None): - logger.info(msg) + if style == "ERROR": + logger.error(msg) + elif style == "WARNING": + logger.warning(msg) + elif style == "SUCCESS": + logger.info(msg) + elif style == "DEBUG": + logger.debug(msg) + else: + logger.info(msg) try: table_name, event_table_name = get_table_names(model_name) @@ -790,7 +799,7 @@ def progress_callback(msg, style=None): progress_callback( f" Event table {event_table_name} not found. " f"Is {model_name} tracked by pghistory?", - "ERROR", + "DEBUG", ) return 0, 0.0 diff --git a/dojo/db_migrations/0250_pghistory_backfill.py b/dojo/db_migrations/0250_pghistory_backfill.py index 5d09d77c0e2..927ad091ba4 100644 --- a/dojo/db_migrations/0250_pghistory_backfill.py +++ b/dojo/db_migrations/0250_pghistory_backfill.py @@ -43,6 +43,8 @@ def progress_callback(msg, style=None): logger.warning(msg) elif style == "SUCCESS": logger.info(msg) + elif style == "DEBUG": + logger.debug(msg) else: logger.info(msg) diff --git a/dojo/db_migrations/0257_pghistory_tags_backfill.py b/dojo/db_migrations/0257_pghistory_tags_backfill.py index b05d725147a..d4c016073fc 100644 --- a/dojo/db_migrations/0257_pghistory_tags_backfill.py +++ b/dojo/db_migrations/0257_pghistory_tags_backfill.py @@ -56,6 +56,8 @@ def progress_callback(msg, style=None): logger.warning(msg) elif style == "SUCCESS": logger.info(msg) + elif style == "DEBUG": + logger.debug(msg) else: logger.info(msg)