Skip to content

Commit dc6b4bc

Browse files
authored
Merge pull request binance-exchange#380 from microjasa/master
fixed the ability to do testnet streaming per binance-exchange#379
2 parents 97a37b4 + d3262e1 commit dc6b4bc

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,17 +32,17 @@
3232
<dependency>
3333
<groupId>commons-codec</groupId>
3434
<artifactId>commons-codec</artifactId>
35-
<version>1.10</version>
35+
<version>1.15</version>
3636
</dependency>
3737
<dependency>
3838
<groupId>org.apache.commons</groupId>
3939
<artifactId>commons-lang3</artifactId>
40-
<version>3.6</version>
40+
<version>3.12.0</version>
4141
</dependency>
4242
<dependency>
4343
<groupId>junit</groupId>
4444
<artifactId>junit</artifactId>
45-
<version>4.12</version>
45+
<version>4.13.2</version>
4646
<scope>test</scope>
4747
</dependency>
4848
</dependencies>

src/main/java/com/binance/api/client/config/BinanceApiConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,6 @@ public static String getTestNetBaseUrl() {
7777
* Streaming Spot Test Network base URL.
7878
*/
7979
public static String getStreamTestNetBaseUrl() {
80-
return String.format("wss://%s", TESTNET_DOMAIN);
80+
return String.format("wss://%s/ws", TESTNET_DOMAIN);
8181
}
8282
}

src/main/java/com/binance/api/client/impl/BinanceApiServiceGenerator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ public static <S> S createService(Class<S> serviceClass, String apiKey, String s
5858
String baseUrl = null;
5959
if (!BinanceApiConfig.useTestnet) { baseUrl = BinanceApiConfig.getApiBaseUrl(); }
6060
else {
61-
baseUrl = BinanceApiConfig.useTestnetStreaming ?
62-
BinanceApiConfig.getStreamTestNetBaseUrl() :
61+
baseUrl = /*BinanceApiConfig.useTestnetStreaming ?
62+
BinanceApiConfig.getStreamTestNetBaseUrl() :*/
6363
BinanceApiConfig.getTestNetBaseUrl();
6464
}
6565

src/main/java/com/binance/api/client/impl/BinanceApiWebSocketClientImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ public void close() {
9393
}
9494

9595
private Closeable createNewWebSocket(String channel, BinanceApiWebSocketListener<?> listener) {
96-
String streamingUrl = String.format("%s/%s", BinanceApiConfig.getStreamApiBaseUrl(), channel);
96+
String streamingUrl = String.format("%s/%s", BinanceApiConfig.useTestnetStreaming?BinanceApiConfig.getStreamTestNetBaseUrl():BinanceApiConfig.getStreamApiBaseUrl(), channel);
9797
Request request = new Request.Builder().url(streamingUrl).build();
9898
final WebSocket webSocket = client.newWebSocket(request, listener);
9999
return () -> {

0 commit comments

Comments
 (0)