Merge pull request #73 from DevilsDev/security/github-actions-pinning

security: pin GitHub Actions to commit hashes and fix deprecated actions

Author: alikahwaji

.github/workflows/ci.yml

@@ -39,22 +39,27 @@ jobs:
         with:
           egress-policy: audit
 
-      - name: ⬇️ Checkout code
-        uses: actions/checkout@v4
+      - name: Checkout code
+        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
         with:
           persist-credentials: false
           fetch-depth: 1
 
       - name: 🟢 Setup Node.js
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
         with:
           node-version: ${{ env.NODE_VERSION }}
           cache: npm
           registry-url: https://registry.npmjs.org/
           cache-dependency-path: package-lock.json
 
-      - name: 📦 Install dependencies
-        run: npm ci
+      - name: Clear npm cache
+        run: npm cache clean --force
+        shell: bash
+
+      - name: Install dependencies
+        run: |
+          npm ci --no-optional --no-audit --prefer-offline
         shell: bash
 
       - name: 🧹 Lint
@@ -68,14 +73,14 @@ jobs:
 
       - name: Upload JUnit
         if: always()
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
         with:
           name: junit
           path: junit.xml
 
       - name: Upload coverage
         if: always()
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
         with:
           name: coverage
           path: coverage
@@ -85,21 +90,23 @@ jobs:
     if: always() && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
     timeout-minutes: 5
     runs-on: ubuntu-latest
+    permissions:
+      contents: read
     steps:
       - name: Harden runner
         uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7
         with:
           egress-policy: audit
 
       - name: Download coverage
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
         with:
           name: coverage
           path: coverage
         continue-on-error: true
 
       - name: Upload to Codecov
-        uses: codecov/codecov-action@v4
+        uses: codecov/codecov-action@e28ff129e5465c2c0dcc6f003fc735cb6ae0c673 # v4.5.0
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
           fail_ci_if_error: false

.github/workflows/comprehensive-testing.yml

@@ -52,9 +52,9 @@ jobs:
       cache-key: ${{ steps.cache-key.outputs.key }}
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
       - name: Setup Node.js
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
         with:
           node-version: ${{ env.NODE_VERSION }}
           cache: npm
@@ -67,7 +67,7 @@ jobs:
           echo "key=node-modules-${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}" >> "$GITHUB_OUTPUT"
         shell: bash
       - name: Cache dependencies
-        uses: actions/cache@v4
+        uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
         with:
           path: ~/.npm
           key: ${{ steps.cache-key.outputs.key }}
@@ -114,9 +114,9 @@ jobs:
           - 22
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
       - name: Setup Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
         with:
           node-version: ${{ matrix.node-version }}
           cache: npm
@@ -133,15 +133,15 @@ jobs:
           npm run test:unit:coverage
         shell: bash
       - name: Upload coverage reports
-        uses: codecov/codecov-action@v4
+        uses: codecov/codecov-action@e28ff129e5465c2c0dcc6f003fc735cb6ae0c673 # v4.5.0
         if: matrix.node-version == 20
         with:
           file: ./coverage/lcov.info
           flags: unit-tests
           name: unit-tests-coverage
       - name: Upload failure logs
         if: failure()
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
         with:
           name: unit-test-failure-logs-${{ matrix.node-version }}-${{ github.run_number }}
           path: |
@@ -173,9 +173,9 @@ jobs:
           - "6379:6379"
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
       - name: Setup Node.js
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
         with:
           node-version: ${{ env.NODE_VERSION }}
           cache: npm
@@ -201,7 +201,7 @@ jobs:
           npm run test:integration:coverage
         shell: bash
       - name: Upload integration test results
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
         if: always()
         with:
           name: integration-test-results
@@ -221,9 +221,9 @@ jobs:
       contents: read
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
       - name: Setup Node.js
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
         with:
           node-version: ${{ env.NODE_VERSION }}
           cache: npm
@@ -240,7 +240,7 @@ jobs:
           npm run benchmark:cpu
         shell: bash
       - name: Upload performance results
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
         if: always()
         with:
           name: performance-results
@@ -255,9 +255,9 @@ jobs:
     if: contains(fromJson(needs.setup.outputs.test-matrix), 'security')
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
       - name: Setup Node.js
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
         with:
           node-version: ${{ env.NODE_VERSION }}
           cache: npm
@@ -281,7 +281,7 @@ jobs:
           npm audit --audit-level=moderate --json > audit-results.json || true
         shell: bash
       - name: Upload security results
-        uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32
+        uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
         if: always()
         with:
           name: security-test-results
@@ -297,9 +297,9 @@ jobs:
     if: contains(fromJson(needs.setup.outputs.test-matrix), 'property-based')
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
       - name: Setup Node.js
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
         with:
           node-version: ${{ env.NODE_VERSION }}
           cache: npm
@@ -317,7 +317,7 @@ jobs:
           PROPERTY_TESTING: true
         shell: bash
       - name: Upload property test results
-        uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32
+        uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
         if: always()
         with:
           name: property-test-results
@@ -341,9 +341,9 @@ jobs:
           - 22
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
       - name: Setup Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
         with:
           node-version: ${{ matrix.node-version }}
           cache: npm
@@ -360,7 +360,7 @@ jobs:
           NODE_ENV: test
         shell: bash
       - name: Upload compatibility results
-        uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32
+        uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
         if: always()
         with:
           name: compatibility-test-results-${{ matrix.os }}-${{ matrix.node-version }}
@@ -381,9 +381,9 @@ jobs:
     if: always() && (github.event.inputs.generate_reports == 'true' || github.event.inputs.generate_reports == '')
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
       - name: Setup Node.js
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
         with:
           node-version: ${{ env.NODE_VERSION }}
           cache: npm
@@ -392,7 +392,7 @@ jobs:
         run: npm ci
         shell: bash
       - name: Download all test artifacts
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
         with:
           path: test-artifacts
       - name: Generate comprehensive test report
@@ -408,7 +408,7 @@ jobs:
           GITHUB_REF: "\"${{ github.ref }}\""
         shell: bash
       - name: Upload HTML reports
-        uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32
+        uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
         with:
           name: test-reports-html
           path: test-reports/
@@ -491,7 +491,7 @@ jobs:
             });
       - name: Slack notification
         if: failure() && github.ref == 'refs/heads/main'
-        uses: 8398a7/action-slack@28ba43ae48961b90ced0e7aac97fc847a4ab1666
+        uses: 8398a7/action-slack@v3
         with:
           status: failure
           channel: "#dev-alerts"

.github/workflows/contract-validation.yml

@@ -8,10 +8,9 @@ name: Contract Schema Validation (Security Hardened)
       - src/contracts/**
       - src/plugins/**
       - package.json
-    paths-ignore:
-      - docs/**
-      - "*.md"
-      - .github/ISSUE_TEMPLATE/**
+      - "!docs/**"
+      - "!*.md"
+      - "!.github/ISSUE_TEMPLATE/**"
   pull_request:
     branches:
       - main
@@ -20,10 +19,9 @@ name: Contract Schema Validation (Security Hardened)
       - src/contracts/**
       - src/plugins/**
       - package.json
-    paths-ignore:
-      - docs/**
-      - "*.md"
-      - .github/ISSUE_TEMPLATE/**
+      - "!docs/**"
+      - "!*.md"
+      - "!.github/ISSUE_TEMPLATE/**"
   workflow_dispatch:
     inputs:
       validation_type:
@@ -55,17 +53,21 @@ jobs:
       pull-requests: write
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
         with:
           fetch-depth: 0
       - name: Setup Node.js
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
         with:
           node-version: ${{ env.NODE_VERSION }}
           cache: npm
           cache-dependency-path: package-lock.json
+      - name: Clear npm cache
+        run: npm cache clean --force
+        shell: bash
       - name: Install dependencies
-        run: npm ci
+        run: |
+          npm ci --no-optional --no-audit --prefer-offline
         shell: bash
       - name: Run contract schema validation tests
         run: |
@@ -124,7 +126,7 @@ jobs:
           fi
         shell: bash
       - name: Upload validation report
-        uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808
+        uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
         with:
           name: contract-validation-report
           path: contract-validation-report.md
@@ -139,14 +141,17 @@ jobs:
         with:
           path: current
       - name: Checkout base branch
-        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
+        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
         with:
           ref: ${{ github.base_ref || 'main' }}
           path: base
       - name: Setup Node.js
-        uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8
+        uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
         with:
           node-version: "20"
+      - name: Clear npm cache
+        run: npm cache clean --force
+        shell: bash
       - name: Install dependencies
         run: |
           set -e
@@ -240,7 +245,7 @@ jobs:
         shell: bash
       - name: Comment on PR with breaking change analysis
         if: github.event_name == 'pull_request' && failure()
-        uses: actions/github-script@35b1cdd1b2c1fc704b1cd442536d6e4b28b2ba4e
+        uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
         with:
           script: |
             const comment = `## 🚨 Breaking Changes Detected

.github/workflows/deploy-production.yml

@@ -350,7 +350,7 @@ jobs:
           done
       - name: Send deployment notification
         if: always()
-        uses: 8398a7/action-slack@28ba43ae48961b90ced0e3a2b7f9a3b3fb92dd30
+        uses: 8398a7/action-slack@v3
         with:
           status: ${{ job.status }}
           channel: "#deployments"

.github/workflows/docs-build.yml

@@ -26,8 +26,8 @@ jobs:
         uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7
         with:
           egress-policy: audit
-      - uses: actions/checkout@v4
-      - uses: actions/setup-node@v4
+      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+      - uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
         with:
           node-version: 20
           cache: npm
@@ -40,7 +40,7 @@ jobs:
           npm ci
           npm run build
       - name: Upload artifact
-        uses: actions/upload-pages-artifact@56afc609e74202658d3ffba0e8f6dda462b719fa
+        uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
         with:
           path: docs-site/build