Skip to content

Commit cd6c54e

Browse files
Merge pull request #18 from Devotel/feature/devhub-rebranding
Fix hlrvalidation typo and update docs URL
2 parents 95c9f6e + 171afd2 commit cd6c54e

File tree

5 files changed

+13
-13
lines changed

5 files changed

+13
-13
lines changed

examples/sms_example.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def main():
3232
recipient=recipient,
3333
message=message,
3434
sender=sender,
35-
hirvalidation=True, # Enable high-quality routing validation
35+
hlrvalidation=True, # Enable high-quality routing validation
3636
)
3737

3838
print("SMS sent successfully!")

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ docs = [
5151

5252
[project.urls]
5353
Homepage = "https://github.com/devotel/devhub-python"
54-
Documentation = "https://devhub-python.readthedocs.io"
54+
Documentation = "https://devotel.github.io/devhub-python/"
5555
Repository = "https://github.com/devotel/devhub-python"
5656
Issues = "https://github.com/devotel/devhub-python/issues"
5757

src/devhub_python/models/sms.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class SMSQuickSendRequest(BaseModel):
1515
sender: str = Field(..., description="Sender phone number or ID")
1616
recipient: str = Field(..., description="Recipient phone number in E.164 format")
1717
message: str = Field(..., description="SMS message content")
18-
hirvalidation: bool = Field(True, description="Enable HIR validation")
18+
hlrvalidation: bool = Field(True, description="Enable HIR validation")
1919

2020

2121
class NumberPurchaseRequest(BaseModel):
@@ -62,7 +62,7 @@ class SMSQuickSendResponse(BaseModel):
6262
api_route: Optional[str] = Field(None, description="API route used")
6363
apimode: Optional[str] = Field(None, description="API mode")
6464
quicksendidentifier: Optional[str] = Field(None, description="Quick send identifier")
65-
hirvalidation: Optional[bool] = Field(None, description="HIR validation enabled")
65+
hlrvalidation: Optional[bool] = Field(None, description="HIR validation enabled")
6666

6767
# Error response fields
6868
statusCode: Optional[int] = Field(None, description="HTTP status code for errors")

src/devhub_python/resources/sms.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def send_sms(
5757
recipient: str,
5858
message: str,
5959
sender: str,
60-
hirvalidation: bool = True,
60+
hlrvalidation: bool = True,
6161
sandbox: bool = False,
6262
) -> "SMSQuickSendResponse":
6363
"""
@@ -67,7 +67,7 @@ def send_sms(
6767
recipient: The recipient's phone number in E.164 format
6868
message: The SMS message content
6969
sender: The sender phone number or sender ID
70-
hirvalidation: Enable HIR validation (default: True)
70+
hlrvalidation: Enable HIR validation (default: True)
7171
sandbox: Use sandbox environment for testing (default: False)
7272
7373
Returns:
@@ -100,7 +100,7 @@ def send_sms(
100100
sender=sender,
101101
recipient=recipient,
102102
message=message,
103-
hirvalidation=hirvalidation,
103+
hlrvalidation=hlrvalidation,
104104
)
105105

106106
# Send request to the exact API endpoint
@@ -327,5 +327,5 @@ def send(
327327
recipient=to,
328328
message=body,
329329
sender=from_,
330-
hirvalidation=kwargs.get("hirvalidation", True),
330+
hlrvalidation=kwargs.get("hlrvalidation", True),
331331
)

tests/test_sms.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def test_send_sms_success(self, sms_resource, test_phone_number):
3838
"api_route": "user-api/sms/quick-send",
3939
"apimode": "quick-send",
4040
"quicksendidentifier": "quick_123",
41-
"hirvalidation": True,
41+
"hlrvalidation": True,
4242
}
4343
sms_resource.client.post.return_value = mock_response
4444

@@ -47,15 +47,15 @@ def test_send_sms_success(self, sms_resource, test_phone_number):
4747
recipient=test_phone_number,
4848
message="Hello, World!",
4949
sender="+1987654321",
50-
hirvalidation=True,
50+
hlrvalidation=True,
5151
)
5252

5353
# Verify the response
5454
assert result.id == "msg_123456789"
5555
assert result.recipient == test_phone_number
5656
assert result.message == "Hello, World!"
5757
assert result.status == "queued"
58-
assert result.hirvalidation is True
58+
assert result.hlrvalidation is True
5959

6060
# Verify the API call
6161
sms_resource.client.post.assert_called_once_with(
@@ -64,7 +64,7 @@ def test_send_sms_success(self, sms_resource, test_phone_number):
6464
"sender": "+1987654321",
6565
"recipient": test_phone_number,
6666
"message": "Hello, World!",
67-
"hirvalidation": True,
67+
"hlrvalidation": True,
6868
},
6969
sandbox=False,
7070
)
@@ -319,7 +319,7 @@ def test_legacy_send_method(self, sms_resource, test_phone_number):
319319
"api_route": "user-api/sms/quick-send",
320320
"apimode": "quick-send",
321321
"quicksendidentifier": "quick_123",
322-
"hirvalidation": True,
322+
"hlrvalidation": True,
323323
}
324324
sms_resource.client.post.return_value = mock_response
325325

0 commit comments

Comments
 (0)