Skip to content

redesign conversion summary report #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tibisabau wants to merge 4 commits into
base: main
Choose a base branch
from
Open

redesign conversion summary report #353

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83f6f26
redesign conversion summary report
tibisabau Dec 5, 2025
f55c23e
Update analytics/site/conversionadmin.py
tibisabau Dec 5, 2025
41799f4
Update analytics/site/conversionadmin.py
tibisabau Dec 5, 2025
7936a32
Update analytics/site/conversionadmin.py
tibisabau Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions analytics/site/conversionadmin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from django.utils.translation import gettext_lazy as _

from analytics.site.requeststatadmin import BaseRequestStatAdmin
from django.utils.safestring import mark_safe
from analytics.utils.helpers import get_values_over_time


Expand Down Expand Up @@ -53,7 +54,7 @@ def create_context_data(self, request: WSGIRequest,
total_won_deals,
'receipt_date'
)
title = _('Conversion') + f' ({conversion} %)'
title = mark_safe(_('Conversion') + f' ({conversion} %)<br><br>' + _('Total requests') + f' = {total_requests_count}')
conversion_over_time = list(map(
lambda x, y:
{
Expand Down Expand Up @@ -93,7 +94,7 @@ def create_context_data(self, request: WSGIRequest,
)
self.add_chart_data(
response,
f"{conversion_of_primary_requests_str} ({primary_conversion} %)",
mark_safe(f"{conversion_of_primary_requests_str} ({primary_conversion} %)<br><br>" + _('Total primary requests') + f" = {primary_requests_count}"),
primary_conversion_over_time,
max_value2
)
Expand Down
3 changes: 0 additions & 3 deletions analytics/templates/analytics/summary_change_list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ <h1>{{ page_title }}</h1>
{% endblock %}
{% block result_list %}
<div>
{% for n, v in summary.items %}
<p>{{ n }} = {{ v }}</p>
{% endfor %}
{% include "analytics/data_table.html" %}
{% include "analytics/bar_chart.html" %}
</div>
Expand Down