Skip to content

Commit 678f36c

Browse files
committed
fix some issues with readme
1 parent 30d8844 commit 678f36c

File tree

11 files changed

+84
-293
lines changed

11 files changed

+84
-293
lines changed
Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
</head>
1111

1212
<body>
13-
<h1 style="font-size: 1.5em;">Read Barcodes from a Camera</h1>
14-
<button id="btn-show-scanner">Show Barcode Scanner</button>
1513
<script src="https://cdn.jsdelivr.net/npm/dynamsoft-javascript-barcode@9.0.0/dist/dbr.js"></script>
1614
<script>
1715
/** LICENSE ALERT - README
@@ -27,10 +25,9 @@ <h1 style="font-size: 1.5em;">Read Barcodes from a Camera</h1>
2725
* LICENSE ALERT - THE END
2826
*/
2927

30-
let pScanner = null;
31-
document.getElementById('btn-show-scanner').onclick = async function() {
28+
window.onload = async function() {
3229
try {
33-
const scanner = await (pScanner = pScanner || Dynamsoft.DBR.BarcodeScanner.createInstance());
30+
const scanner = await Dynamsoft.DBR.BarcodeScanner.createInstance();
3431
/*
3532
* onFrameRead is triggered after the library finishes reading a frame.
3633
* There can be multiple barcodes on one frame.
@@ -52,7 +49,6 @@ <h1 style="font-size: 1.5em;">Read Barcodes from a Camera</h1>
5249
}
5350
await scanner.show();
5451
} catch (ex) {
55-
alert(ex.message);
5652
throw ex;
5753
}
5854
};

1.hello-world/README.md

Lines changed: 0 additions & 73 deletions
This file was deleted.

2.ui-tweaking/README.md

Lines changed: 0 additions & 38 deletions
This file was deleted.

3.settings/5.regionOfInterest-regionPredetection.html

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ <h1 style="font-size: 1.5em;">Define or Detect the Region of Interest</h2>
2626
<!-- Manually defining the div that will contain the video so that the UI doesn't take up the full screen-->
2727
<div id="div-ui-container">
2828
<span id='lib-load' style='font-size:x-large' hidden>Loading Library...</span>
29-
<div class="dce-video-container" style="position:absolute;left:0;top:0;width:100%;height:100%;"></div>
29+
<div class="dce-video-container" style="position:absolute;left:0;top:0;width:100%;height:100%;"></div>
3030
</div>
3131

3232
<!-- Settings Menu displayed in a modal -->
@@ -119,36 +119,35 @@ <h1 style="font-size: 1.5em;">Define or Detect the Region of Interest</h2>
119119
* Should the Region of Interest form change (as in the user inputted a value for regionTop, regionLeft, regionBottom, or regionRight)
120120
* update the runtime settings to reflect this change.
121121
*/
122-
122+
let settings = null;
123123
let scanner = await pScanner;
124+
settings = await scanner.getRuntimeSettings();
125+
settings.region.regionMeasuredByPercentage = 1;
126+
settings.region.regionTop = 0;
127+
settings.region.regionBottom = 100;
128+
settings.region.regionLeft = 0;
129+
settings.region.regionRight = 100;
130+
await scanner.updateRuntimeSettings(settings);
124131
const roiFormInputs = document.querySelectorAll('input[name="regionDef"]');
125-
let settings = null;
126132
roiFormInputs.forEach(element => {
127133
element.addEventListener("input", async function() {
128134
try {
129135
settings = await scanner.getRuntimeSettings();
130-
if (settings.region.regionMeasuredByPercentage === undefined)
131-
settings.region.regionMeasuredByPercentage = true;
132-
if (settings.region.regionTop === undefined)
133-
settings.region.regionTop = 0;
134-
if (settings.region.regionBottom === undefined)
135-
settings.region.regionBottom = 100;
136-
if (settings.region.regionLeft === undefined)
137-
settings.region.regionLeft = 0;
138-
if (settings.region.regionRight === undefined)
139-
settings.region.regionRight = 100;
136+
let parsedValue = parseInt(this.value);
137+
if (parsedValue > 100) parsedValue = 100;
138+
if (parsedValue < 0) parse = 0;
140139
switch (this.id) {
141140
case "regionTop":
142-
settings.region.regionTop = this.value;
141+
settings.region.regionTop = parsedValue;
143142
break;
144143
case "regionBottom":
145-
settings.region.regionBottom = this.value;
144+
settings.region.regionBottom = parsedValue;
146145
break;
147146
case "regionLeft":
148-
settings.region.regionLeft = this.value;
147+
settings.region.regionLeft = parsedValue;
149148
break;
150149
case "regionRight":
151-
settings.region.regionRight = this.value;
150+
settings.region.regionRight = parsedValue;
152151
break;
153152
}
154153
await scanner.updateRuntimeSettings(settings);

0 commit comments

Comments
 (0)