From 161b1330dea71029633e91e9e5f2fb440e6c6a7d Mon Sep 17 00:00:00 2001 From: ShahanaFarooqui Date: Mon, 3 Nov 2025 14:01:29 -0800 Subject: [PATCH] Do not throw error if fiat rate fetching fails Fixes #132 --- apps/backend/source/controllers/shared.ts | 7 +++++-- apps/backend/source/server.ts | 1 - 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/apps/backend/source/controllers/shared.ts b/apps/backend/source/controllers/shared.ts index fabc3806..c8ca9a7d 100644 --- a/apps/backend/source/controllers/shared.ts +++ b/apps/backend/source/controllers/shared.ts @@ -82,6 +82,7 @@ export class SharedController { const FIAT_VENUE = FIAT_VENUES.hasOwnProperty(req.params.fiatCurrency) ? FIAT_VENUES[req.params.fiatCurrency] : 'COINGECKO'; + logger.info('Fiat URL: ' + FIAT_RATE_API + FIAT_VENUE + '/pairs/XBT/' + req.params.fiatCurrency); return axios .get(FIAT_RATE_API + FIAT_VENUE + '/pairs/XBT/' + req.params.fiatCurrency) .then((response: any) => { @@ -98,10 +99,12 @@ export class SharedController { } }) .catch(err => { - return handleError(err, req, res, next); + logger.error('Fiat Error Response: ' + JSON.stringify(err)); + res.status(200).json({ venue: "NONE", rate: "0" }); }); } catch (error: any) { - handleError(error, req, res, next); + logger.error('Error from Fiat Rate: ' + JSON.stringify(error)); + res.status(200).json({ venue: "NONE", rate: "0" }); } }; diff --git a/apps/backend/source/server.ts b/apps/backend/source/server.ts index d6d39e35..c5b9bc8e 100755 --- a/apps/backend/source/server.ts +++ b/apps/backend/source/server.ts @@ -141,7 +141,6 @@ async function startServer() { startServer(); process.on('uncaughtException', err => { - logger.error('I M HERE'); logger.error('Uncaught Exception:', err); process.exit(1); });