Workflows

Author: PDowney

.github/workflows/php-code-quality.yml

@@ -87,17 +87,23 @@ jobs:
 
       - name: Run PHP Compatibility Check
         run: |
-          # Install PHP compatibility standards if they're not already installed
+          # Install PHP compatibility standards and required packages
           composer require --dev phpcompatibility/php-compatibility wp-coding-standards/wpcs dealerdirect/phpcodesniffer-composer-installer --no-interaction || true
           
-          # Set up PHPCompatibility standard
-          vendor/bin/phpcs --config-set installed_paths $(pwd)/vendor/phpcompatibility/php-compatibility || true
+          # Set up PHPCompatibility standards - need to set correct paths
+          INSTALLED_PATHS=$(composer config vendor-dir)/phpcompatibility/php-compatibility,$(composer config vendor-dir)/wp-coding-standards/wpcs
+          vendor/bin/phpcs --config-set installed_paths $INSTALLED_PATHS || true
+          
+          # Verify configured standards
+          echo "Available coding standards:"
+          vendor/bin/phpcs -i
           
           # Try to auto-fix compatibility issues where possible
-          vendor/bin/phpcbf --standard=PHPCompatibilityWP --extensions=php --ignore=vendor/,node_modules/ --runtime-set testVersion 7.4-8.4 . || true
+          vendor/bin/phpcbf --standard=phpcs.xml --extensions=php --ignore=vendor/,node_modules/ . || true
           
           # Run the actual compatibility check
-          vendor/bin/phpcs --standard=PHPCompatibilityWP --extensions=php --ignore=vendor/,node_modules/ --runtime-set testVersion 7.4-8.4 .
+          # Use project phpcs.xml which already includes PHPCompatibility with correct testVersion
+          vendor/bin/phpcs --standard=phpcs.xml --extensions=php --ignore=vendor/,node_modules/ .
 
       - name: Fix text argument escaping issues
         run: |

.github/workflows/wordpress-tests.yml

@@ -174,6 +174,15 @@ jobs:
           # Make the install script executable
           chmod +x bin/install-wp-tests.sh
           
+          # Verify that the local db.php file exists
+          if [ ! -f "bin/db.php" ]; then
+            echo "::error::bin/db.php not found! This is required for the WordPress test environment setup."
+            ls -la bin/ || echo "bin directory not found or empty"
+            exit 1
+          else
+            echo "Local db.php file found - it will be used for the MySQL database driver"
+          fi
+          
           # Create and fix permissions for /tmp directory
           sudo mkdir -p /tmp/wordpress-tests-lib
           sudo chmod 1777 /tmp
@@ -209,12 +218,22 @@ jobs:
             exit 1
           fi
           
-          # Check WordPress core installation
+          # Check WordPress core installation and verify db.php was copied
           if [ ! -d "/tmp/wordpress" ]; then
             echo "::error::WordPress core directory not created."
             exit 1
           fi
           
+          # Verify db.php was copied successfully to WordPress content directory
+          if [ ! -f "/tmp/wordpress/wp-content/db.php" ]; then
+            echo "::error::db.php file not copied to WordPress content directory."
+            echo "Copying the db.php file manually as a final fallback..."
+            mkdir -p /tmp/wordpress/wp-content/
+            cp bin/db.php /tmp/wordpress/wp-content/db.php || echo "Failed to copy db.php manually"
+          else
+            echo "db.php file successfully installed in WordPress content directory."
+          fi
+          
           echo "WordPress test environment successfully set up:"
           ls -la /tmp/wordpress-tests-lib/
       

bin/install-wp-tests.sh

@@ -170,29 +170,27 @@ install_wp() {
 		fi
 	fi
 
-	echo "Downloading extra MySQL database driver..."
+	echo "Setting up MySQL database driver..."
 	# Create directory if it doesn't exist
 	mkdir -p $WP_CORE_DIR/wp-content/
 
-	# Try to download the db.php file with verification
-	download https://raw.github.com/markoheijnen/wp-mysqli/master/db.php $WP_CORE_DIR/wp-content/db.php
-	
-	# Check if download was successful and file is not empty
-	if [ ! -s "$WP_CORE_DIR/wp-content/db.php" ]; then
-		echo "Warning: Downloaded db.php file is empty or download failed."
+	# Use local db.php file from the repository
+	if [ -f "bin/db.php" ]; then
+		echo "Using local db.php from bin/db.php"
+		cp bin/db.php $WP_CORE_DIR/wp-content/db.php
+	elif [ -f "${0%/*}/db.php" ]; then
+		# Try to find db.php in the same directory as the script
+		echo "Using local db.php from script directory"
+		cp "${0%/*}/db.php" $WP_CORE_DIR/wp-content/db.php
+	else
+		echo "Error: Local db.php file not found in expected locations"
+		echo "Expected locations checked:"
+		echo "  - bin/db.php"
+		echo "  - ${0%/*}/db.php"
 
-		# Check if we have a local copy in the repository
-		if [ -f "bin/db.php" ]; then
-			echo "Using local fallback copy of db.php from bin/db.php"
-			cp bin/db.php $WP_CORE_DIR/wp-content/db.php
-		elif [ -f "${0%/*}/db.php" ]; then
-			# Try to find db.php in the same directory as the script
-			echo "Using local fallback copy of db.php from script directory"
-			cp "${0%/*}/db.php" $WP_CORE_DIR/wp-content/db.php
-		else
-			# Create a simple db.php file inline as last resort
-			echo "Creating a minimal db.php file as fallback"
-			cat > $WP_CORE_DIR/wp-content/db.php << 'EOL'
+		# Create a simple db.php file inline as last resort
+		echo "Creating a minimal db.php file as fallback"
+		cat > $WP_CORE_DIR/wp-content/db.php << 'EOL'
 <?php
 /**
  * Fallback database driver to ensure tests can run
@@ -207,11 +205,8 @@ EOL
 		if [ ! -s "$WP_CORE_DIR/wp-content/db.php" ]; then
 			echo "Error: Failed to create a valid db.php file. Tests may not work correctly."
 		else
-			echo "Fallback db.php file created successfully."
+			echo "db.php file created successfully."
 		fi
-	else
-		echo "db.php downloaded successfully."
-	fi
 
 	echo "WordPress core installation complete!"
 }

phpcs.xml

@@ -23,7 +23,8 @@
     <rule ref="WordPress.Security.ValidatedSanitizedInput" />
 
     <!-- PHP compatibility checks -->
-    <rule ref="PHPCompatibilityWP" />
+    <rule ref="PHPCompatibility" />
+    <config name="testVersion" value="7.4-8.4"/>
 
     <!-- Files to check -->
     <arg name="extensions" value="php" />