[Due for payment 2026-01-15] [$250] Workspace - Delete banner still display after clicking on the Got it button in Overview

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.87-7
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2545/41237957/1092911729?q=delete+workspace&issue_type=jira
Email or phone of affected tester (no customers): applausetester+vq+2712@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 10/Chrome
App Component: Workspace Settings

Action Performed:

Preconditions: Workspace has issued an Expensify card to the member

1. Open the NewDot app
2. Navigate to the Workspace Overview
3. Click on the More button
4. Select the Delete option
5. Click on the Delete button and click on the Got it
6. Navigate to the Workspace tab
7. Click on the three dots button and select Delete
8. Click on the Delete button and click on the Got it

Expected Result:

Step 5: After clicking the " Got it" button, the Delete banner should dismiss like Step 8

Actual Result:

The Delete banner at step 5 still displays

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022005772487710361501
• Upwork Job ID: 2005772487710361501
• Last Price Increase: 2025-12-29

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Delete banner at step 5 still displays

What is the root cause of that problem?

We don't setIsDeleteModalOpen when the user confirm delete if it's online

App/src/pages/workspace/WorkspaceOverviewPage.tsx

Lines 234 to 237 in a1e04dd

	if (isOffline) {
	setIsDeleteModalOpen(false);
	goBackFromInvalidPolicy();
	}

then on hideDeleteWorkspaceErrorModal we also don't setIsDeleteModalOpen as false

What changes do you think we should make in order to solve the problem?

We should also setIsDeleteModalOpen as false in hideDeleteWorkspaceErrorModal function

    const hideDeleteWorkspaceErrorModal = () => {
        setIsDeleteWorkspaceErrorModalOpen(false);
        setIsDeleteModalOpen(false);
        clearDeleteWorkspaceError(policy?.id);
    };

What alternative solutions did you explore? (Optional)

Or we can setIsDeleteModalOpen(false); in confirmDelete function even if it's online

        setIsDeleteModalOpen(false);
        deleteWorkspace({...
        ...
        if (isOffline) {
            goBackFromInvalidPolicy();
        }

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[ryntgh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Delete banner still display after clicking on the Got it button in Overview

What is the root cause of that problem?

When the delete operation fails, the effect opens the error modal but doesn't close the delete modal

App/src/pages/workspace/WorkspaceOverviewPage.tsx

Lines 275 to 285 in 9e3ecbb

	useEffect(() => {
	if (!isFocused || !prevIsPendingDelete || isPendingDelete) {
	return;
	}
	if (!policyLastErrorMessage) {
	goBackFromInvalidPolicy();
	return;
	}
	setIsDeleteWorkspaceErrorModalOpen(true);
	}, [isFocused, isPendingDelete, prevIsPendingDelete, policyLastErrorMessage]);

Meanwhile, in WorkspacesListPage, the same effect properly closes the delete modal (setIsDeleteModalOpen(false)) before showing the error modal

App/src/pages/workspace/WorkspacesListPage.tsx

Lines 320 to 329 in 9e3ecbb

	useEffect(() => {
	if (!prevIsPendingDelete || isPendingDelete || !policyIDToDelete) {
	return;
	}
	setIsDeleteModalOpen(false);
	if (!isFocused || !policyToDeleteLatestErrorMessage) {
	return;
	}
	setIsDeleteWorkspaceErrorModalOpen(true);
	}, [isPendingDelete, prevIsPendingDelete, isFocused, policyToDeleteLatestErrorMessage, policyIDToDelete]);

What changes do you think we should make in order to solve the problem?

We should close the delete modal before opening the error modal in WorkspaceOverviewPage

    useEffect(() => {
        if (!isFocused || !prevIsPendingDelete || isPendingDelete) {
            return;
        }

        if (!policyLastErrorMessage) {
            goBackFromInvalidPolicy();
            return;
        }
        setIsDeleteModalOpen(false);
        setIsDeleteWorkspaceErrorModalOpen(true);
    }, [isFocused, isPendingDelete, prevIsPendingDelete, policyLastErrorMessage]);

App/src/pages/workspace/WorkspaceOverviewPage.tsx

Lines 275 to 285 in 9e3ecbb

	useEffect(() => {
	if (!isFocused || !prevIsPendingDelete || isPendingDelete) {
	return;
	}
	if (!policyLastErrorMessage) {
	goBackFromInvalidPolicy();
	return;
	}
	setIsDeleteWorkspaceErrorModalOpen(true);
	}, [isFocused, isPendingDelete, prevIsPendingDelete, policyLastErrorMessage]);

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022005772487710361501

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[mallenexpensify]

Spent too long trying to repro, marked at External

[github-actions]

⚠️ @yatin-italy Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.

[jayeshmangwani]

Thanks to both of you for the proposals above.

I like @ryntgh 's approach #78514 (comment) of setting setIsDeleteModalOpen to false in the effect when we enable setIsDeleteWorkspaceErrorModalOpen. Let’s go with that.

🎀 👀 🎀 C+ reviewed