[BUG] ERROR Invariant Violation: Tried to register two views with the same name AddToWalletButton, js engine: hermes

[wcastand]

trying to implement this in an expo app, writing the plugin for it at the same time and switching from our internal version this this one.

I encounter this error and my best guess is it conflicts with stripe somehow that also tries to add the same view maybe?

i don't have a component with this name in my codebase so not sure why i would get this error otherwise.

 ERROR  Invariant Violation: Tried to register two views with the same name AddToWalletButton, js engine: hermes

i also get this error originating from the screen where we have Stripe payment sheet which leads me to believe it's linked. Also stripe is the only other lib i can see implementing this view since they have a pay with google pay feature in the payment sheet.

looking quickly at their source code, they do have a component with this name
https://github.com/search?q=repo:stripe/stripe-react-native%20AddToWalletButton&type=code

reproduction: https://github.com/wcastand/bug-rn-wallet

try to make it minimal but need stripe/rn-wallet so need expo-dev and stuff

[Skalakid]

Hello, we need more details to help you with it. When do you get this error? Every time when entering the screen with the AddToWalletButton component?

[wcastand]

i have provided a repro so you can see for yourself, it's happening as soon as i have stripe/rn-wallet setup and i import something from the libs (can be stripe provider and checkWalletAvailbility), doesn't have to import on same screen as far as i know either.

and i get the error when i launch the app on expo-router, it break the app like the export for expo-router break so it's at launch/init.

[Skalakid]

Okay, I see it, I will investigate it and come back to you with more info. Thanks!

[Skalakid]

@wcastand #42 that should fix the problem :D

[wcastand]

yeah sounds like the easiest solution to prefix the names.
i will try it out again when published, no reason it doesn't work properly now.

[Skalakid]

Merged 🚀

[wcastand]

do you make release when you publish a new version? so i know when to test?
i can just watch the repo for releases that way 🙏

[Skalakid]

No, we don’t create GitHub Releases right now. Every time a PR is merged, a new version is automatically published to npm right away. So you can test our changes right now in version 0.1.8

[wcastand]

so i tried on 0.1.8 multiple times, prebuild cleaned, build clean in xcode too etc deleted node modules etc but still getting the same build error

❌  duplicate symbol '_OBJC_METACLASS_$_AddToWalletButtonView' in
┌─ react_native_wallet[9](RNAddToWalletButtonView.o)
└─ stripe_react_native[26](AddToWalletButtonView.o)

❌  duplicate symbol '_OBJC_CLASS_$_AddToWalletButtonView' in
┌─ react_native_wallet[9](RNAddToWalletButtonView.o)
└─ stripe_react_native[26](AddToWalletButtonView.o)


❌  ld: 2 duplicate symbols



❌  clang: error: linker command failed with exit code 1 (use -v to see invocation)

[wcastand]

@Skalakid do you know if it's something you can fix or it's fully on our side somehow, my cache didn't update altho i tried to clean everything multiple times now 😓

[Skalakid]

@wcastand okay I was finally able to reproduce it, should be fixed by #44

[wcastand]

sorry forgot to provide a repro or update the previous one 🙏

thanks for fixing it and spending time on it then 🙏