Merge pull request #148 from FAForever/fix/147-invalid-usernames

URGENT Fix/147 invalid usernames

Author: micheljung

api/helpers.py

@@ -14,7 +14,7 @@
 from api.error import ApiException, Error, ErrorCode
 from config import CRYPTO_KEY
 
-USERNAME_REGEX = re.compile("[A-Za-z]{1}[A-Za-z0-9_-]{2,15}")
+USERNAME_REGEX = re.compile("[A-Za-z]{1}[A-Za-z0-9_-]{2,15}$")
 EMAIL_REGEX = re.compile(r"^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,4}$")
 
 

tests/unit_tests/test_helpers.py

@@ -52,7 +52,7 @@ def test_validate_username_success(setup_users):
 
 def test_validate_username_illegal_syntax(setup_users):
     with pytest.raises(ApiException) as excInfo:
-        validate_username("x,y")
+        validate_username("xxx yyy")
 
     assert excInfo.value.errors[0].code == ErrorCode.INVALID_USERNAME