Incorrect Bans in Ladder Games

[ssiccha]

Issue Summary: Incorrect Bans in Ladder Games Due to Missing PlayerOption Messages

Problem: Players are receiving incorrect violation bans in ladder games when connection failures occur.

Root Cause (per @Gatsik's analysis shared via Zulip):

• Server checks _configured_player_ids to determine if players are "configured" before assigning violations
• _configured_player_ids is only populated by set_player_option() calls (triggered by PlayerOption GPGNet messages)
• Ladder games don't send PlayerOption messages (only custom lobbies do)
• Result: All guests in ladder games appear "unconfigured" and get violations when games fail to start, even if the failure wasn't their fault

Code References:

• Game configuration check: server/games/game.py#L231 (get_connected_players())
• PlayerOption handling: server/games/game.py#L616-L621 (set_player_option())
• Host exclusion logic: server/ladder_service/ladder_service.py#L737 (NotConnectedError)

Suggested Fix:
Track actual connection status using other messages like EstablishedPeer instead of relying solely on PlayerOption messages for ladder games.

Impact:
All guests in failed ladder games receive violations regardless of whether they successfully connected, because they never appear in _configured_player_ids.

[Askaholic]

This must have been changed on the game side then. The auto lobby used to send the messages. The simplest thing would be to get the lua guys to fix it on their side (restore the old behavior). The code could likely even be copy pasted out of the git history.

[ssiccha]

More from Zulip:

looking further into it turns out that's not entirely true -- PlayerOptions are only sent by the host (server also has a check for that)
the thing is that looks like host sends PlayerOption for all players when everyone is connected and the game is ready to launch, instead of sending it separately based on player connection to host
see https://github.com/FAForever/fa/blob/8434c72a3199f4d91da8635e07076e03b8b76022/lua/ui/lobby/autolobby/AutolobbyController.lua#L381-L395
and
https://github.com/FAForever/fa/blob/8434c72a3199f4d91da8635e07076e03b8b76022/lua/ui/lobby/autolobby/AutolobbyController.lua#L557-L560

so this is not entirely on server, but still using PlayerOption message can be buggy, because if host leaves lobby and don't send PlayerOption then it can lead to false positives

[ssiccha]

Failed game IDs from @Strogo:
26212927
26213124
26213581
26213945

[Garanas]

It sends the game options here:

• https://github.com/FAForever/fa/blob/develop/lua/ui/lobby/autolobby/AutolobbyController.lua#L570-L577
• https://github.com/FAForever/fa/blob/develop/lua/ui/lobby/autolobby/components/AutolobbyServerCommunicationsComponent.lua#L97-L105

Only the hosts sends them though, is that maybe wrong?

edit: I now read the context from Zulip. What is the right direction here, to fix the problem?