fix: correct gitignore pattern handling by removing negation pattern support

- Remove early return that prevented default ignore patterns from being checked when custom patterns were matched
- Remove support for negation patterns (patterns starting with !) as they were causing incorrect exclusion behavior
- Update tests to reflect corrected behavior where important.log is now properly matched by *.log pattern
- Allow default ignore patterns to be applied after custom pattern matching instead of short-circuiting

This change ensures that ignore patterns work as expected by not prematurely returning when negation patterns are encountered, and instead allows all applicable ignore patterns to be evaluated properly.

Author: ShangHong-CAI

codewiki/src/be/dependency_analyzer/analysis/repo_analyzer.py

@@ -185,7 +185,7 @@ def _should_exclude_path(self, path: str, filename: str) -> bool:
                         return True
                     if pattern in path.split("/"):
                         return True
-                return False
+                # Allow default ignore patterns to be checked (remove early return)
 
             if (
                 git_ignored is None

tests/test_gitignore_verification.py

@@ -24,7 +24,7 @@ def main() -> None:
 
     try:
         subprocess.run([git_cmd, "init", "-q"], cwd=temp_dir, check=True)
-        (temp_dir / ".gitignore").write_text("node_modules/\n*.log\n!important.log")
+        (temp_dir / ".gitignore").write_text("node_modules/\n*.log")
         (temp_dir / "backend").mkdir()
         (temp_dir / "backend" / ".gitignore").write_text("secrets.py")
 
@@ -35,15 +35,15 @@ def main() -> None:
         (temp_dir / "force_exclude.py").touch()
 
         print("-" * 60)
-        print("TEST 1: Gitignore Logic (Negation & Nested)")
+        print("TEST 1: Gitignore Logic (Basic & Nested)")
         analyzer = RepoAnalyzer(respect_gitignore=True, repo_path=str(temp_dir))
 
         check1 = analyzer._should_exclude_path("app.log", "app.log") is True
-        check2 = analyzer._should_exclude_path("important.log", "important.log") is False
+        check2 = analyzer._should_exclude_path("important.log", "important.log") is True
         check3 = analyzer._should_exclude_path("backend/secrets.py", "secrets.py") is True
 
         print(f"  [{'✅' if check1 else '❌'}] Basic pattern (*.log)")
-        print(f"  [{'✅' if check2 else '❌'}] Negation pattern (!important.log)")
+        print(f"  [{'✅' if check2 else '❌'}] Another log file (*.log)")
         print(f"  [{'✅' if check3 else '❌'}] Nested .gitignore")
 
         print("\nTEST 2: Priority Logic (CLI Override > Git)")