Path fixes for spawn, reduce noise on npm i

Author: jamesdaniels

src/frameworks/index.ts

@@ -71,7 +71,6 @@ export const build = async (config: DeployConfig | Required<DeployConfig>, getPr
                 const path = version.split(':')[1];
                 if (await access(path).catch(() => true)) continue;
                 const stats = await stat(path);
-                console.log(`Packing file-system dependency on ${path} for Cloud Functions`);
                 if (stats.isDirectory()) {
                     const result = spawnSync(Commands.NPM, ['pack', relative(functionsDist, path)], { cwd: functionsDist });
                     if (!result.stdout) continue;
@@ -90,7 +89,6 @@ export const build = async (config: DeployConfig | Required<DeployConfig>, getPr
                     const path = version.split(':')[1];
                     if (await access(path).catch(() => true)) continue;
                     const stats = await stat(path);
-                    console.log(`Packing file-system dependency on ${path} for Cloud Functions`);
                     if (stats.isDirectory()) {
                         const result = spawnSync(Commands.NPM, ['pack', relative(functionsDist, path)], { cwd: functionsDist });
                         if (!result.stdout) continue;
@@ -119,11 +117,7 @@ export const build = async (config: DeployConfig | Required<DeployConfig>, getPr
 
         await copyFile(getProjectPath('package-lock.json'), join(functionsDist, 'package-lock.json')).catch(() => {});
 
-        await spawn(Commands.NPM, ['i', '--only', 'production', '--no-audit'], { cwd: functionsDist }, (stdoutChunk: any) => {
-            console.log(stdoutChunk.toString());
-        }, (errChunk: any) => {
-            console.error(errChunk.toString());
-        });
+        await spawn(Commands.NPM, ['i', '--omit', 'dev', '--no-audit'], { cwd: functionsDist });
 
         if (bootstrapScript) {
             await writeFile(join(functionsDist, 'bootstrap.js'), bootstrapScript);

src/utils.ts

@@ -13,6 +13,7 @@
 // limitations under the License.
 
 import { exec as execCallback, spawn as spawnCallback, ExecOptions, SpawnOptionsWithoutStdio, spawnSync } from 'child_process';
+import { join } from 'path';
 
 export const exec = (command: string, options: ExecOptions={}) => new Promise((resolve, reject) =>
     execCallback(command, options, (error, stdout) => {
@@ -75,6 +76,6 @@ export const findDependency = (name: string, cwd=process.cwd()) => {
 
 export const Commands = {
     NPM: process.platform === 'win32' ? 'npm.cmd' : 'npm',
-    next: process.platform === 'win32' ? 'next.cmd' : 'next',
-    ng: process.platform === 'win32' ? 'ng.cmd' : 'ng',
+    next: join('node_modules', '.bin', process.platform === 'win32' ? 'next.cmd' : 'next'),
+    ng: join('node_modules', '.bin', process.platform === 'win32' ? 'ng.cmd' : 'ng'),
 };