Skip to content

Commit 6fabcae

Browse files
committed
Use final and internal visibility where possible.
1 parent 32621d3 commit 6fabcae

16 files changed

+16
-16
lines changed

src/fbjava/src/main/java/org/firebirdsql/fbjava/impl/BlobConnection.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
*
4040
* @author <a href="mailto:adrianosf@gmail.com">Adriano dos Santos Fernandes</a>
4141
*/
42-
public class BlobConnection extends URLConnection
42+
final class BlobConnection extends URLConnection
4343
{
4444
private static final Logger log = LoggerFactory.getLogger(BlobConnection.class);
4545

src/fbjava/src/main/java/org/firebirdsql/fbjava/impl/CloseableMemory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
*
2727
* @author asfernandes
2828
*/
29-
class CloseableMemory extends Memory implements AutoCloseable
29+
final class CloseableMemory extends Memory implements AutoCloseable
3030
{
3131
public CloseableMemory(long size)
3232
{

src/fbjava/src/main/java/org/firebirdsql/fbjava/impl/DbClassLoader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
*
3636
* @author <a href="mailto:adrianosf@gmail.com">Adriano dos Santos Fernandes</a>
3737
*/
38-
final public class DbClassLoader extends URLClassLoader
38+
final class DbClassLoader extends URLClassLoader
3939
{
4040
private FBConnection connection;
4141

src/fbjava/src/main/java/org/firebirdsql/fbjava/impl/ExternalEngine.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
import com.sun.jna.Pointer;
6565

6666

67-
class ExternalEngine implements IExternalEngineIntf
67+
final class ExternalEngine implements IExternalEngineIntf
6868
{
6969
private static final EncodingFactory encodingFactory = EncodingFactory.getDefaultInstance();
7070
private static Map<String, SharedData> sharedDataMap = new ConcurrentHashMap<>();

src/fbjava/src/main/java/org/firebirdsql/fbjava/impl/ExternalFunction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
import com.sun.jna.Pointer;
2929

3030

31-
class ExternalFunction implements IExternalFunctionIntf
31+
final class ExternalFunction implements IExternalFunctionIntf
3232
{
3333
private IExternalFunction wrapper;
3434
private Routine routine;

src/fbjava/src/main/java/org/firebirdsql/fbjava/impl/ExternalProcedure.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
import com.sun.jna.Pointer;
3333

3434

35-
class ExternalProcedure implements IExternalProcedureIntf
35+
final class ExternalProcedure implements IExternalProcedureIntf
3636
{
3737
private IExternalProcedure wrapper;
3838
private Routine routine;

src/fbjava/src/main/java/org/firebirdsql/fbjava/impl/FbException.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import com.sun.jna.Pointer;
2525

2626

27-
class FbException extends Exception
27+
final class FbException extends Exception
2828
{
2929
private static final long serialVersionUID = 1L;
3030

src/fbjava/src/main/java/org/firebirdsql/fbjava/impl/InternalContext.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
import org.firebirdsql.fbjava.impl.FbClientLibrary.ITransaction;
2929

3030

31-
class InternalContext implements AutoCloseable
31+
final class InternalContext implements AutoCloseable
3232
{
3333
private static ThreadLocal<InternalContext> tls = new ThreadLocal<InternalContext>() {
3434
@Override

src/fbjava/src/main/java/org/firebirdsql/fbjava/impl/InternalDatabaseFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
import com.sun.jna.ptr.IntByReference;
3131

3232

33-
class InternalDatabaseFactory extends FbEmbeddedDatabaseFactory
33+
final class InternalDatabaseFactory extends FbEmbeddedDatabaseFactory
3434
{
3535
private static final InternalDatabaseFactory INSTANCE = new InternalDatabaseFactory();
3636

src/fbjava/src/main/java/org/firebirdsql/fbjava/impl/InternalFBConnection.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
import com.sun.jna.ptr.IntByReference;
3232

3333

34-
public final class InternalFBConnection extends FBConnection
34+
public final class InternalFBConnection extends FBConnection // must be public
3535
{
3636
public InternalFBConnection(FBManagedConnection mc) throws SQLException
3737
{

0 commit comments

Comments
 (0)