From 769e30a650b5afe7f825cb9106f405b037968006 Mon Sep 17 00:00:00 2001 From: Naveen Singh Date: Sat, 3 Jan 2026 14:28:15 +0530 Subject: [PATCH 1/2] feat: disable cancellation on touch outside checklist dialog --- CHANGELOG.md | 3 +++ .../org/fossify/notes/dialogs/NewChecklistItemDialog.kt | 7 ++++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c202b8417..2e8ccc924 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## [Unreleased] +### Changed +- Disabled touch outside the checklist dialog to prevent loss of content ([#291]) ### Fixed - Fixed inconsistent checklist sorting when the "Move checked items to the bottom" option is enabled ([#59]) @@ -105,6 +107,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 [#178]: https://github.com/FossifyOrg/Notes/issues/178 [#190]: https://github.com/FossifyOrg/Notes/issues/190 [#201]: https://github.com/FossifyOrg/Notes/issues/201 +[#291]: https://github.com/FossifyOrg/Notes/issues/291 [Unreleased]: https://github.com/FossifyOrg/Notes/compare/1.6.0...HEAD [1.6.0]: https://github.com/FossifyOrg/Notes/compare/1.5.0...1.6.0 diff --git a/app/src/main/kotlin/org/fossify/notes/dialogs/NewChecklistItemDialog.kt b/app/src/main/kotlin/org/fossify/notes/dialogs/NewChecklistItemDialog.kt index de69bc3b6..d1d86e53f 100644 --- a/app/src/main/kotlin/org/fossify/notes/dialogs/NewChecklistItemDialog.kt +++ b/app/src/main/kotlin/org/fossify/notes/dialogs/NewChecklistItemDialog.kt @@ -45,7 +45,12 @@ class NewChecklistItemDialog( .setPositiveButton(org.fossify.commons.R.string.ok, null) .setNegativeButton(org.fossify.commons.R.string.cancel, null) .apply { - activity.setupDialogStuff(view, this, R.string.add_new_checklist_items) { alertDialog -> + activity.setupDialogStuff( + view = view, + dialog = this, + titleId = R.string.add_new_checklist_items, + cancelOnTouchOutside = false + ) { alertDialog -> alertDialog.showKeyboard(titles.first()) alertDialog.getButton(BUTTON_POSITIVE).setOnClickListener { activity.config.addNewChecklistItemsTop = binding.settingsAddChecklistTop.isChecked From cde9d089f26ed1ac3ee0da2676edf4668956480d Mon Sep 17 00:00:00 2001 From: Naveen Singh Date: Sat, 3 Jan 2026 16:31:29 +0530 Subject: [PATCH 2/2] fix: disable cancellation on touch outside checklist dialog --- .../org/fossify/notes/dialogs/NewChecklistItemDialog.kt | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/app/src/main/kotlin/org/fossify/notes/dialogs/NewChecklistItemDialog.kt b/app/src/main/kotlin/org/fossify/notes/dialogs/NewChecklistItemDialog.kt index d1d86e53f..0e46fe3bd 100644 --- a/app/src/main/kotlin/org/fossify/notes/dialogs/NewChecklistItemDialog.kt +++ b/app/src/main/kotlin/org/fossify/notes/dialogs/NewChecklistItemDialog.kt @@ -45,12 +45,8 @@ class NewChecklistItemDialog( .setPositiveButton(org.fossify.commons.R.string.ok, null) .setNegativeButton(org.fossify.commons.R.string.cancel, null) .apply { - activity.setupDialogStuff( - view = view, - dialog = this, - titleId = R.string.add_new_checklist_items, - cancelOnTouchOutside = false - ) { alertDialog -> + activity.setupDialogStuff(view, this, R.string.add_new_checklist_items) { alertDialog -> + alertDialog.setCanceledOnTouchOutside(false) alertDialog.showKeyboard(titles.first()) alertDialog.getButton(BUTTON_POSITIVE).setOnClickListener { activity.config.addNewChecklistItemsTop = binding.settingsAddChecklistTop.isChecked