Add a specific message when magisk is not installed.

Author: Fox2Code

app/src/main/java/com/fox2code/mmm/NotificationType.java

@@ -32,9 +32,15 @@ public boolean shouldRemove() {
             return !MainApplication.isShowcaseMode();
         }
     },
-    NO_ROOT(R.string.fail_root_magisk, R.drawable.ic_baseline_numbers_24, v -> {
-        IntentHelper.openUrl(v.getContext(), "https://github.com/topjohnwu/Magisk/blob/master/docs/install.md");
-    }) {
+    NO_MAGISK(R.string.fail_magisk_missing, R.drawable.ic_baseline_numbers_24, v ->
+            IntentHelper.openUrl(v.getContext(),
+                    "https://github.com/topjohnwu/Magisk/blob/master/docs/install.md")) {
+        @Override
+        public boolean shouldRemove() {
+            return InstallerInitializer.getErrorNotification() != this;
+        }
+    },
+    NO_ROOT(R.string.fail_root_magisk, R.drawable.ic_baseline_numbers_24) {
         @Override
         public boolean shouldRemove() {
             return InstallerInitializer.getErrorNotification() != this;

app/src/main/java/com/fox2code/mmm/installer/InstallerInitializer.java

@@ -48,7 +48,9 @@ public static NotificationType getErrorNotification() {
                 hasRoot != Boolean.FALSE) {
             return null;
         }
-        if (hasRoot != Boolean.TRUE && HAS_MAGISK) {
+        if (!HAS_MAGISK) {
+            return NotificationType.NO_MAGISK;
+        } else if (hasRoot != Boolean.TRUE) {
             return NotificationType.ROOT_DENIED;
         }
         return NotificationType.NO_ROOT;

app/src/main/res/values/strings.xml

@@ -3,6 +3,7 @@
     <string name="app_name_short">Fox\'s Mmm</string>
     <string name="fail_root_magisk">Could not access either Root or Magisk</string>
     <string name="fail_root_denied">Root has been denied via the Magisk app</string>
+    <string name="fail_magisk_missing">Magisk is not installed on this device</string>
     <string name="loading">Loading…</string>
     <string name="updatable">Upgradable</string>
     <string name="installed">Installed</string>