Skip to content
This repository was archived by the owner on May 4, 2023. It is now read-only.

Commit 3eb1744

Browse files
committed
Fix previous PR + minor UI tweaks.
1 parent 5e2535e commit 3eb1744

File tree

11 files changed

+29
-16
lines changed

11 files changed

+29
-16
lines changed

app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ dependencies {
9797
// Utils
9898
implementation 'com.squareup.okhttp3:okhttp-dnsoverhttps:4.9.3'
9999
implementation 'com.squareup.okhttp3:okhttp-brotli:4.9.3'
100-
implementation 'com.github.topjohnwu.libsu:io:5.0.0'
100+
implementation 'com.github.topjohnwu.libsu:io:5.0.1'
101101

102102
// Markdown
103103
implementation "io.noties.markwon:core:4.6.2"

app/src/main/java/com/fox2code/mmm/MainActivity.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import android.view.WindowManager;
2121
import android.view.inputmethod.EditorInfo;
2222
import android.widget.TextView;
23-
import android.widget.Toast;
2423

2524
import com.fox2code.mmm.compat.CompatActivity;
2625
import com.fox2code.mmm.compat.CompatDisplay;
@@ -33,9 +32,7 @@
3332
import com.fox2code.mmm.settings.SettingsActivity;
3433
import com.fox2code.mmm.utils.Http;
3534
import com.fox2code.mmm.utils.IntentHelper;
36-
import com.google.android.material.dialog.MaterialAlertDialogBuilder;
3735
import com.google.android.material.progressindicator.LinearProgressIndicator;
38-
import com.topjohnwu.superuser.Shell;
3936

4037
import eightbitlab.com.blurview.BlurView;
4138
import eightbitlab.com.blurview.RenderScriptBlur;

app/src/main/java/com/fox2code/mmm/installer/InstallerActivity.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
import androidx.recyclerview.widget.RecyclerView;
1717

18-
import com.fox2code.mmm.ActionButtonType;
18+
import com.fox2code.mmm.module.ActionButtonType;
1919
import com.fox2code.mmm.AppUpdateManager;
2020
import com.fox2code.mmm.BuildConfig;
2121
import com.fox2code.mmm.Constants;
@@ -647,6 +647,7 @@ private void setInstallStateFinished(boolean success, String message, String opt
647647
return true;
648648
});
649649
} else if (success) {
650+
this.rebootFloatingButton.setVisibility(View.VISIBLE);
650651
final Intent intent = this.getIntent();
651652
final String config = MainApplication.checkSecret(intent) ?
652653
intent.getStringExtra(Constants.EXTRA_INSTALL_CONFIG) : null;
@@ -658,7 +659,6 @@ private void setInstallStateFinished(boolean success, String message, String opt
658659
IntentHelper.openConfig(this, config);
659660
return true;
660661
});
661-
this.rebootFloatingButton.setVisibility(View.VISIBLE);
662662
} catch (PackageManager.NameNotFoundException e) {
663663
Log.w(TAG, "Config package \"" +
664664
configPkg + "\" missing for installer view");

app/src/main/java/com/fox2code/mmm/ActionButtonType.java renamed to app/src/main/java/com/fox2code/mmm/module/ActionButtonType.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.fox2code.mmm;
1+
package com.fox2code.mmm.module;
22

33
import android.content.Context;
44
import android.text.Spanned;
@@ -11,6 +11,8 @@
1111
import androidx.annotation.DrawableRes;
1212
import androidx.appcompat.app.AlertDialog;
1313

14+
import com.fox2code.mmm.MainApplication;
15+
import com.fox2code.mmm.R;
1416
import com.fox2code.mmm.androidacy.AndroidacyUtil;
1517
import com.fox2code.mmm.compat.CompatActivity;
1618
import com.fox2code.mmm.compat.CompatDisplay;

app/src/main/java/com/fox2code/mmm/module/ModuleHolder.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import androidx.annotation.NonNull;
99
import androidx.annotation.StringRes;
1010

11-
import com.fox2code.mmm.ActionButtonType;
1211
import com.fox2code.mmm.MainApplication;
1312
import com.fox2code.mmm.NotificationType;
1413
import com.fox2code.mmm.R;

app/src/main/java/com/fox2code/mmm/module/ModuleViewAdapter.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import androidx.cardview.widget.CardView;
1919
import androidx.recyclerview.widget.RecyclerView;
2020

21-
import com.fox2code.mmm.ActionButtonType;
2221
import com.fox2code.mmm.MainApplication;
2322
import com.fox2code.mmm.NotificationType;
2423
import com.fox2code.mmm.R;
@@ -326,8 +325,6 @@ public boolean update(ModuleHolder moduleHolder) {
326325
// Fix card background being invisible on light theme
327326
if (bgColor == Color.WHITE) {
328327
bgColor = 0xFFF8F8F8;
329-
} else {
330-
bgColor = 0xFF1E1E1E;
331328
}
332329
this.titleText.setTextColor(fgColor);
333330
this.buttonAction.setColorFilter(fgColor);

app/src/main/java/com/fox2code/mmm/utils/Files.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.fox2code.mmm.utils;
22

33
import android.os.Build;
4-
import android.util.Log;
54

65
import androidx.annotation.NonNull;
76

app/src/main/res/layout/installer_wrap.xml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,17 @@
2626
app:layout_constraintEnd_toEndOf="parent"
2727
app:layout_constraintStart_toStartOf="parent"
2828
app:layout_constraintTop_toTopOf="parent" />
29+
30+
<com.google.android.material.floatingactionbutton.ExtendedFloatingActionButton
31+
android:id="@+id/install_terminal_reboot_fab"
32+
android:text="@string/install_terminal_reboot_now"
33+
android:visibility="gone"
34+
android:layout_width="wrap_content"
35+
android:layout_height="wrap_content"
36+
android:layout_margin="16dp"
37+
android:textColor="@android:color/white"
38+
app:iconTint="@android:color/white"
39+
app:icon="@drawable/ic_reboot_24"
40+
app:layout_constraintRight_toRightOf="parent"
41+
app:layout_constraintBottom_toBottomOf="parent" />
2942
</androidx.constraintlayout.widget.ConstraintLayout>

app/src/main/res/layout/module_entry.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@
4343
android:id="@+id/switch_action"
4444
android:layout_width="wrap_content"
4545
android:layout_height="wrap_content"
46+
android:layout_marginTop="6dp"
4647
app:layout_constraintTop_toTopOf="parent"
4748
app:layout_constraintRight_toRightOf="parent" />
4849

@@ -55,7 +56,7 @@
5556
android:layout_height="wrap_content"
5657
app:layout_constraintTop_toTopOf="parent"
5758
app:layout_constraintLeft_toLeftOf="parent"
58-
app:layout_constraintRight_toLeftOf="@+id/button_action" />
59+
app:layout_constraintRight_toRightOf="parent" />
5960

6061
<TextView
6162
android:id="@+id/credit_text"

app/src/main/res/values/themes.xml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<resources xmlns:tools="http://schemas.android.com/tools">
22
<style name="Theme.MagiskModuleManager.Light" parent="Theme.MaterialComponents.Light">
33
<item name="android:isLightTheme"
4-
tools:targetApi="q">false</item>
5-
<item name="isLightTheme">false</item>
4+
tools:targetApi="q">true</item>
5+
<item name="isLightTheme">true</item>
66
<!-- Primary brand color. -->
77
<item name="colorPrimary">@color/orange_200</item>
88
<item name="colorPrimaryVariant">@color/white</item>
@@ -26,6 +26,8 @@
2626
<item name="android:windowExitAnimation">@android:anim/fade_out</item>
2727
<item name="android:dialogCornerRadius" tools:targetApi="p">@dimen/card_corner_radius</item>
2828
<item name="dialogCornerRadius">@dimen/card_corner_radius</item>
29+
<item name="colorBackgroundFloating">#FFFFFFFF</item>
30+
<item name="backgroundColor">#FFFFFFFF</item>
2931
</style>
3032

3133
<style name="Theme.MagiskModuleManager.Transparent.Light" parent="Theme.MagiskModuleManager.Light">
@@ -69,6 +71,8 @@
6971
<item name="android:windowExitAnimation">@android:anim/fade_out</item>
7072
<item name="android:dialogCornerRadius" tools:targetApi="p">@dimen/card_corner_radius</item>
7173
<item name="dialogCornerRadius">@dimen/card_corner_radius</item>
74+
<item name="colorBackgroundFloating">#FF1E1E1E</item>
75+
<item name="backgroundColor">#FF111111</item>
7276
</style>
7377

7478
<!-- Base application theme. -->

0 commit comments

Comments
 (0)