Skip to content
This repository was archived by the owner on May 4, 2023. It is now read-only.

Commit b6b496b

Browse files
committed
Improve Settings Preferences
1 parent 0e85e49 commit b6b496b

File tree

2 files changed

+46
-35
lines changed

2 files changed

+46
-35
lines changed

app/src/main/res/values/strings.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,4 +100,7 @@
100100
<string name="repo_enabled">Repo enabled</string>
101101
<string name="repo_disabled">Repo disabled</string>
102102
<string name="androidacy_repo_info">Androidacy repo uses ads and trackers.</string>
103+
<string name="pref_category_security">Security</string>
104+
<string name="pref_category_appearance">Appearance</string>
105+
<string name="pref_category_general">General</string>
103106
</resources>

app/src/main/res/xml/root_preferences.xml

Lines changed: 43 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,42 @@
11
<PreferenceScreen xmlns:app="http://schemas.android.com/apk/res-auto">
22

3-
<PreferenceCategory
4-
app:title="@string/pref_category_settings">
3+
<!-- Custom repos has been announced, check https://github.com/Fox2Code/FoxMagiskModuleManager/issues/131 -->
4+
<PreferenceCategory app:title="@string/pref_category_repos">
55
<Preference
66
app:key="pref_manage_repos"
77
app:icon="@drawable/ic_baseline_extension_24"
88
app:title="@string/manage_repos_pref"
99
app:singleLineTitle="false" />
10+
</PreferenceCategory>
11+
12+
<PreferenceCategory
13+
app:title="@string/pref_category_general">
14+
<SwitchPreferenceCompat
15+
app:defaultValue="false"
16+
app:key="pref_show_incompatible"
17+
app:icon="@drawable/ic_baseline_hide_source_24"
18+
app:title="@string/show_incompatible_pref"
19+
app:summary="@string/show_incompatible_desc"
20+
app:singleLineTitle="false" />
1021

22+
<SwitchPreferenceCompat
23+
app:defaultValue="false"
24+
app:key="pref_use_magisk_install_command"
25+
app:icon="@drawable/ic_baseline_numbers_24"
26+
app:title="@string/use_magisk_install_command_pref"
27+
app:summary="@string/use_magisk_install_command_desc"
28+
app:singleLineTitle="false" />
29+
30+
<SwitchPreferenceCompat
31+
app:defaultValue="true"
32+
app:key="pref_dns_over_https"
33+
app:icon="@drawable/ic_baseline_security_24"
34+
app:title="@string/dns_over_https_pref"
35+
app:summary="@string/dns_over_https_desc"
36+
app:singleLineTitle="false" />
37+
</PreferenceCategory>
38+
39+
<PreferenceCategory app:title="@string/pref_category_appearance">
1140
<ListPreference
1241
app:key="pref_theme"
1342
app:icon="@drawable/ic_baseline_palette_24"
@@ -38,6 +67,16 @@
3867
app:title="@string/force_dark_terminal_title"
3968
app:singleLineTitle="false" />
4069

70+
<SwitchPreferenceCompat
71+
app:defaultValue="false"
72+
app:key="pref_wrap_text"
73+
app:icon="@drawable/ic_baseline_keyboard_return_24"
74+
app:title="@string/wrap_text_pref"
75+
app:summary="@string/wrap_text_desc"
76+
app:singleLineTitle="false" />
77+
</PreferenceCategory>
78+
79+
<PreferenceCategory app:title="@string/pref_category_security">
4180
<!-- Note: Lockdown mode used to be called showcase mode -->
4281
<SwitchPreferenceCompat
4382
app:defaultValue="false"
@@ -55,45 +94,13 @@
5594
app:summary="@string/prevent_reboot_desc"
5695
app:singleLineTitle="false" />
5796

58-
<SwitchPreferenceCompat
59-
app:defaultValue="false"
60-
app:key="pref_wrap_text"
61-
app:icon="@drawable/ic_baseline_keyboard_return_24"
62-
app:title="@string/wrap_text_pref"
63-
app:summary="@string/wrap_text_desc"
64-
app:singleLineTitle="false" />
65-
66-
<SwitchPreferenceCompat
67-
app:defaultValue="false"
68-
app:key="pref_show_incompatible"
69-
app:icon="@drawable/ic_baseline_hide_source_24"
70-
app:title="@string/show_incompatible_pref"
71-
app:summary="@string/show_incompatible_desc"
72-
app:singleLineTitle="false" />
73-
7497
<SwitchPreferenceCompat
7598
app:defaultValue="false"
7699
app:key="pref_disable_low_quality_module_filter"
77100
app:icon="@drawable/ic_baseline_warning_24"
78101
app:title="@string/disable_low_quality_module_filter_pref"
79102
app:summary="@string/disable_low_quality_module_filter_desc"
80103
app:singleLineTitle="false" />
81-
82-
<SwitchPreferenceCompat
83-
app:defaultValue="false"
84-
app:key="pref_use_magisk_install_command"
85-
app:icon="@drawable/ic_baseline_numbers_24"
86-
app:title="@string/use_magisk_install_command_pref"
87-
app:summary="@string/use_magisk_install_command_desc"
88-
app:singleLineTitle="false" />
89-
90-
<SwitchPreferenceCompat
91-
app:defaultValue="true"
92-
app:key="pref_dns_over_https"
93-
app:icon="@drawable/ic_baseline_security_24"
94-
app:title="@string/dns_over_https_pref"
95-
app:summary="@string/dns_over_https_desc"
96-
app:singleLineTitle="false" />
97104
</PreferenceCategory>
98105

99106
<PreferenceCategory
@@ -122,6 +129,7 @@
122129
app:key="pref_pkg_info"
123130
app:enabled="false"
124131
app:summary="@string/loading"
125-
app:singleLineTitle="false" />
132+
app:singleLineTitle="false"
133+
app:iconSpaceReserved="false" />
126134
</PreferenceCategory>
127135
</PreferenceScreen>

0 commit comments

Comments
 (0)