Skip to content
This repository was archived by the owner on May 4, 2023. It is now read-only.

Commit b81509d

Browse files
committed
Improve IntentHelper openFile debug log, and use 64bit secret instead of 32bit secret.
1 parent 5f2c2ff commit b81509d

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

app/src/main/java/com/fox2code/mmm/MainApplication.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public class MainApplication extends Application implements CompatActivity.Appli
5151
private static SimpleDateFormat timeFormat =
5252
new SimpleDateFormat(timeFormatString, timeFormatLocale);
5353
private static final Shell.Builder shellBuilder;
54-
private static final int secret;
54+
private static final long secret;
5555
private static SharedPreferences bootSharedPreferences;
5656
private static MainApplication INSTANCE;
5757
private static boolean firstBoot;
@@ -61,7 +61,7 @@ public class MainApplication extends Application implements CompatActivity.Appli
6161
.setFlags(Shell.FLAG_REDIRECT_STDERR)
6262
.setTimeout(10).setInitializers(InstallerInitializer.class)
6363
);
64-
secret = new Random().nextInt();
64+
secret = new Random().nextLong();
6565
}
6666

6767
public MainApplication() {
@@ -79,7 +79,7 @@ public static void addSecret(Intent intent) {
7979
}
8080

8181
public static boolean checkSecret(Intent intent) {
82-
return intent.getIntExtra("secret", ~secret) == secret;
82+
return intent.getLongExtra("secret", ~secret) == secret;
8383
}
8484

8585
public static SharedPreferences getSharedPreferences() {

app/src/main/java/com/fox2code/mmm/utils/IntentHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ public static void openFileTo(CompatActivity compatActivity, File destination,
208208
Files.copy(inputStream, outputStream);
209209
success = true;
210210
} catch (Exception e) {
211-
Log.e("IntentHelper", "fail copy", e);
211+
Log.e("IntentHelper", "failed copy of " + uri, e);
212212
Toast.makeText(compatActivity,
213213
R.string.file_picker_failure,
214214
Toast.LENGTH_SHORT).show();

0 commit comments

Comments
 (0)