fwk: Immediately adjust KB backlight if switching to auto

last_kbbl_led_brightness should be an int compared with kb_brightness,
which is int, so it does not make as a bool.

BUG=When cycling through brightness with FN+SPACE after high, switching
to auto the backlight will stay high. It doesn't adjust to the current
brightness until the ALS brightness changes between off/on.
TEST=press FN+space 4 times from off and make sure that in auto mode
kb backlight immediately updates to ultra-low or off
BRANCH=fwk-main

Signed-off-by: Daniel Schaefer <dhs@frame.work>
(cherry picked from commit 8e02721)

Author: JohnAZoidberg

zephyr/program/framework/include/led.h

@@ -188,6 +188,8 @@ int fp_led_auto_is_enable(void);
 
 int kbbl_auto_dim_is_enable(void);
 
+void auto_als_led_reset(void);
+
 /**
  * Return the current tick time from led driver
  *

zephyr/program/framework/src/keyboard_customization_13.c

@@ -415,14 +415,15 @@ int functional_hotkey(uint16_t *key_code, int8_t pressed)
 			return EC_ERROR_UNIMPLEMENTED;
 		}
 		break;
-	case SCANCODE_SPACE:	/* TODO: TOGGLE_KEYBOARD_BACKLIGHT */
+	case SCANCODE_SPACE: /* Keyboard backlight */
 		if (fn_table_set(pressed, KB_FN_SPACE)) {
 			if (pressed) {
 				if (kbbl_auto_dim_is_enable())
 					bl_brightness = KEYBOARD_BL_BRIGHTNESS_AUTO;
 				else
 					bl_brightness = kblight_get();
 
+				/* Cycle through off, 3 levels of brightness and on */
 				switch (bl_brightness) {
 				case KEYBOARD_BL_BRIGHTNESS_OFF:
 					bl_brightness = KEYBOARD_BL_BRIGHTNESS_LOW;
@@ -435,8 +436,10 @@ int functional_hotkey(uint16_t *key_code, int8_t pressed)
 					break;
 				case KEYBOARD_BL_BRIGHTNESS_HIGH:
 					kb_als_auto_brightness = true;
+					auto_als_led_reset();
 					return EC_ERROR_UNIMPLEMENTED;
 					break;
+				case KEYBOARD_BL_BRIGHTNESS_AUTO:
 				default:
 					bl_brightness = KEYBOARD_BL_BRIGHTNESS_OFF;
 					kb_als_auto_brightness = false;

zephyr/program/framework/src/led.c

@@ -152,7 +152,7 @@ static bool pre_fingerprint_led_state;
 static bool fp_als_auto_brightness;
 static bool last_fp_led_brightness;
 #ifdef CONFIG_PLATFORM_EC_KEYBOARD
-static bool last_kbbl_led_brightness;
+static int last_kbbl_led_brightness;
 #endif
 static int prev_als_lux;
 
@@ -257,6 +257,8 @@ void auto_als_led_brightness(void)
 
 #ifdef CONFIG_PLATFORM_EC_KEYBOARD
 	if (kbbl_auto_dim_is_enable()) {
+		last_kbbl_led_brightness = kblight_get();
+
 		if (als_lux > 5)
 			kb_brightness = KEYBOARD_BL_BRIGHTNESS_OFF;
 		else
@@ -270,6 +272,17 @@ void auto_als_led_brightness(void)
 #endif
 }
 
+/*
+ * Force ALS dependent brightness (keyboard, powerbutton) to immediately adjust
+ * based on ALS measurement, if they're enabled. Useeful if the setting was just enabled.
+ */
+void auto_als_led_reset(void)
+{
+	prev_als_lux = 0;
+	if (IS_ENABLED(CONFIG_PLATFORM_EC_DEDICATED_ALS))
+		auto_als_led_brightness();
+}
+
 test_export_static enum power_state get_chipset_state(void)
 {
 	enum power_state chipset_state = 0;