fwk: dogwood: fix ectool thermalget/set broken

In this change ee99355, I added the
variable in the host command struct and let the thermalget/set command
be broken.

This change moves the variable out from thermal_config struct and creates
a new struct for temperature_filter configuration.

BRANCH=fwk-dogwood-27111
BUG=https://app.clickup.com/t/86ett7kn7
TEST=the ectool thermalget/set will not return error message

Signed-off-by: Josh Tsai <Josh_Tsai@compal.com>

Author: Josh-Tsai

include/ec_commands.h

@@ -3778,12 +3778,6 @@ struct ec_thermal_config {
 	uint32_t temp_host_release[EC_TEMP_THRESH_COUNT]; /* release levels */
 	uint32_t temp_fan_off; /* no active cooling needed */
 	uint32_t temp_fan_max; /* max active cooling needed */
-	/**
-	 * (bug: 86ett7kn7)
-	 * TODO: should not add the new variable in host command struct
-	 * without cmd version
-	 */
-	int32_t coefficients[6]; /* coefficients to calculate the virtual temperature */
 } __ec_align4;
 
 /* Version 1 - get config for one sensor. */

zephyr/shim/src/temperature_filter.c

@@ -6,13 +6,29 @@
 #include "hooks.h"
 #include "math_util.h"
 #include "temperature_filter.h"
+#include "temp_sensor.h"
 #include "thermal.h"
 #include "util.h"
 
 #define Q_SCALE 14
 /* scale input up to improve filter performance */
 #define IN_SCALE 7
 
+struct ec_temperature_filter_config {
+	int32_t coefficients[6]; /* coefficients to calculate the virtual temperature */
+} __ec_align4;
+
+#define TEMP_FILTER_CONFIG(node_id) \
+	[TEMP_SENSOR_ID(node_id)] = {				\
+		.coefficients = DT_PROP_OR(node_id, coefficients, {0}), \
+	}
+
+struct ec_temperature_filter_config temp_filter_params[] = {
+#if DT_HAS_COMPAT_STATUS_OKAY(TEMP_SENSORS_COMPAT)
+	DT_FOREACH_CHILD_SEP(TEMP_SENSORS_NODEID, TEMP_FILTER_CONFIG, (,))
+#endif /* DT_HAS_COMPAT_STATUS_OKAY(TEMP_SENSORS_COMPAT) */
+};
+
 struct temperature_filter_t {
 	int32_t state[4];
 	int32_t coeff[6];
@@ -55,7 +71,7 @@ bool temperature_filter_is_support(enum temp_sensor_id id)
 	int zero[6] = {0};
 	int rv;
 
-	rv = memcmp(thermal_params[id].coefficients, zero, 6);
+	rv = memcmp(temp_filter_params[id].coefficients, zero, 6);
 
 	/* No coefficients (zero arrays), return false */
 	return !!rv;
@@ -76,7 +92,7 @@ static void temperature_filter_init(void)
 {
 	for (int temp_id = 0; temp_id < TEMP_SENSOR_COUNT; temp_id++) {
 		if (temperature_filter_is_support(temp_id))
-			memcpy(filters[temp_id].coeff, thermal_params[temp_id].coefficients,
+			memcpy(filters[temp_id].coeff, temp_filter_params[temp_id].coefficients,
 					sizeof(filters[temp_id].coeff));
 	}
 }

zephyr/shim/src/thermal.c

@@ -43,7 +43,6 @@
 		.temp_fan_max = C_TO_K(DT_PROP_OR(node_id,		\
 						  temp_fan_max,	\
 						  -273)),		\
-		.coefficients = DT_PROP_OR(node_id, coefficients, {0}), \
 	}
 
 struct ec_thermal_config thermal_params[] = {