Skip to content

Commit aef38a7

Browse files
committed
TODOs.
1 parent eafaa82 commit aef38a7

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

flake.nix

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@
9595
in rec {
9696
formatter = pkgs.alejandra;
9797

98+
# TODO: generalise lotus v. azalea
9899
packages.default = packages.lotus;
99100
packages.lotus = pkgs.stdenv.mkDerivation {
100101
name = "lotus";
@@ -113,6 +114,7 @@
113114

114115
sourceRoot = ".";
115116

117+
# TODO: see how much of the below we can remove and still get a build.
116118
postPatch = ''
117119
mkdir .repo
118120
@@ -176,7 +178,7 @@
176178
build-system = [pythonPkgs.setuptools];
177179

178180
# The DYLD_LIBRARY_PATH part here is only needed for Darwin, but it
179-
# doesn't harm Linux.
181+
# doesn't harm Linux. TODO: don't do on Linux.
180182
postPatch = ''
181183
sed -e 's#"/bin:/usr/bin"#"/bin:/usr/bin:${pkgs.gcc}/bin:${pkgs.dtc}/bin","DYLD_LIBRARY_PATH":"${pkgs.dtc}/lib"#' -i zmake/jobserver.py
182184
'';
@@ -209,7 +211,9 @@
209211
${setProjectDynamicToLicense}
210212
'';
211213

212-
makeWrapperArgs = ["--set DYLD_LIBRARY_PATH ${pkgs.dtc}/lib"];
214+
# No wrapper => no need for args. I'd like to be able to still do this
215+
# to have a nicer binman derivation.
216+
# makeWrapperArgs = ["--set DYLD_LIBRARY_PATH ${pkgs.dtc}/lib"];
213217
};
214218

215219
packages.dtoc = pythonPkgs.buildPythonPackage {
@@ -248,6 +252,7 @@
248252
buildInputs = [pythonPkgs.setuptools];
249253
};
250254

255+
# TODO: local builds in your area
251256
devShells.default = pkgs.mkShell {
252257
buildInputs = with pkgs; [
253258
zephyr-sdk

0 commit comments

Comments
 (0)