From a10d4cf38e389002f8c3b1c90dd83051b50e246b Mon Sep 17 00:00:00 2001
From: Daniel Schaefer <dhs@frame.work>
Date: Mon, 3 Nov 2025 00:01:57 +0800
Subject: [PATCH] --versions: Add support for Genesys GL3590 Hub Firmware
 Version

- Framework Laptop 16 7040
  - Version 34.0.4
- Framework Desktop AI 300
  - Version 10.0.2

```
> framework_tool --versions
[...]
USB Hub GL3590
  Firmware Version: 34.0.4
[...]
```

This hub handles USB 2.0 and USB 3.1Gen2 for the Middle Right, Lower Right and Lower Left ports.

Signed-off-by: Daniel Schaefer <dhs@frame.work>
---
 framework_lib/src/usbhub.rs | 32 ++++++++++++++++++++------------
 1 file changed, 20 insertions(+), 12 deletions(-)

diff --git a/framework_lib/src/usbhub.rs b/framework_lib/src/usbhub.rs
index 53f25576..4c022a8f 100644
--- a/framework_lib/src/usbhub.rs
+++ b/framework_lib/src/usbhub.rs
@@ -2,25 +2,33 @@ pub const REALTEK_VID: u16 = 0x0BDA;
 pub const RTL5432_PID: u16 = 0x5432;
 pub const RTL5424_PID: u16 = 0x5424;
 
+pub const GENESYS_VID: u16 = 0x05E3;
+pub const GL3590_PID: u16 = 0x0625;
+
 /// Get and print the firmware version of the usbhub
 pub fn check_usbhub_version() -> Result<(), rusb::Error> {
     for dev in rusb::devices().unwrap().iter() {
         let dev_descriptor = dev.device_descriptor().unwrap();
-        if dev_descriptor.vendor_id() != REALTEK_VID
-            || (dev_descriptor.product_id() != RTL5432_PID
-                && dev_descriptor.product_id() != RTL5424_PID)
+
+        if dev_descriptor.vendor_id() == REALTEK_VID
+            && [RTL5432_PID, RTL5424_PID].contains(&dev_descriptor.product_id())
         {
-            debug!(
-                "Skipping {:04X}:{:04X}",
-                dev_descriptor.vendor_id(),
-                dev_descriptor.product_id()
-            );
-            continue;
+            let dev_descriptor = dev.device_descriptor()?;
+            println!("USB Hub RTL{:04X}", dev_descriptor.product_id());
+            println!("  Firmware Version: {}", dev_descriptor.device_version());
         }
 
-        let dev_descriptor = dev.device_descriptor()?;
-        println!("USB Hub RTL{:04X}", dev_descriptor.product_id());
-        println!("  Firmware Version: {}", dev_descriptor.device_version());
+        if dev_descriptor.vendor_id() == GENESYS_VID
+            && [GL3590_PID].contains(&dev_descriptor.product_id())
+        {
+            let dev_descriptor = dev.device_descriptor()?;
+            if GL3590_PID == dev_descriptor.product_id() {
+                println!("USB Hub GL3590");
+            } else {
+                println!("USB Hub GL????");
+            }
+            println!("  Firmware Version: {}", dev_descriptor.device_version());
+        }
     }
     Ok(())
 }