From 5f193f3bbf1169c103e959e9d5a165cef0238222 Mon Sep 17 00:00:00 2001 From: Nova Date: Mon, 10 Nov 2025 14:28:31 +0100 Subject: [PATCH 1/3] Include Version Number in Release Artifacts --- .github/workflows/release.yml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index fceac2e..e91f38d 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -16,22 +16,22 @@ jobs: include: - target: x86_64-unknown-linux-gnu os: ubuntu-latest - name: gdscript-formatter-linux-x86_64 + name: gdscript-formatter-${{ github.ref_name }}-linux-x86_64 - target: aarch64-unknown-linux-gnu os: ubuntu-latest - name: gdscript-formatter-linux-aarch64 + name: gdscript-formatter-${{ github.ref_name }}-linux-aarch64 - target: x86_64-apple-darwin os: macos-latest - name: gdscript-formatter-macos-x86_64 + name: gdscript-formatter-${{ github.ref_name }}-macos-x86_64 - target: aarch64-apple-darwin os: macos-latest - name: gdscript-formatter-macos-aarch64 + name: gdscript-formatter-${{ github.ref_name }}-macos-aarch64 - target: x86_64-pc-windows-msvc os: windows-latest - name: gdscript-formatter-windows-x86_64.exe + name: gdscript-formatter-${{ github.ref_name }}-windows-x86_64.exe - target: aarch64-pc-windows-msvc os: windows-latest - name: gdscript-formatter-windows-aarch64.exe + name: gdscript-formatter-${{ github.ref_name }}-windows-aarch64.exe runs-on: ${{ matrix.os }} permissions: @@ -97,14 +97,14 @@ jobs: - name: Create godot-addon.zip run: | - zip -r godot-addon.zip addons/ + zip -r godot-addon-${{ github.ref_name }}.zip addons/ shell: bash - name: Upload artifact uses: actions/upload-artifact@v4 with: - name: godot-addon - path: godot-addon.zip + name: godot-addon-${{ github.ref_name }} + path: godot-addon-${{ github.ref_name }}.zip if-no-files-found: error publish-release: From ee321fef147833672d475feeefbc09b21a71bd98 Mon Sep 17 00:00:00 2001 From: Nova Date: Mon, 10 Nov 2025 16:55:29 +0100 Subject: [PATCH 2/3] update the plugin to handle the change --- .../GDQuest_GDScript_formatter/install_and_update.gd | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/addons/GDQuest_GDScript_formatter/install_and_update.gd b/addons/GDQuest_GDScript_formatter/install_and_update.gd index 59a4677..30e8206 100644 --- a/addons/GDQuest_GDScript_formatter/install_and_update.gd +++ b/addons/GDQuest_GDScript_formatter/install_and_update.gd @@ -69,7 +69,8 @@ func _process_response_latest_release(body: PackedByteArray) -> void: print("GDScript Formatter release information loaded successfully") var assets = json["assets"] - var download_url := _find_matching_asset(assets) + var tag = json["tag_name"] + var download_url := _find_matching_asset(assets, tag) if download_url.is_empty(): var error_message := "No matching binary found for current platform" @@ -148,16 +149,19 @@ func _get_platform_info() -> Dictionary: return platform_info -func _find_matching_asset(assets: Array) -> String: +func _find_matching_asset(assets: Array, tag: String) -> String: + print(tag) var platform_info := _get_platform_info() if platform_info.is_empty(): return "" - var expected_pattern := "gdscript-formatter-%s-%s" % [platform_info["os"], platform_info["architecture"]] + var expected_pattern := "gdscript-formatter-%s-%s-%s" % [tag, platform_info["os"], platform_info["architecture"]] if platform_info["os"] == "windows": expected_pattern += ".exe" expected_pattern += ".zip" + print(expected_pattern) + for asset in assets: var asset_name: String = asset["name"] if asset_name == expected_pattern: From 32429baf4b98b8d51621e2f3945a82bb0a2c0ceb Mon Sep 17 00:00:00 2001 From: Nathan Lovato <12694995+NathanLovato@users.noreply.github.com> Date: Mon, 10 Nov 2025 22:43:56 +0100 Subject: [PATCH 3/3] Remove print statements --- addons/GDQuest_GDScript_formatter/install_and_update.gd | 3 --- 1 file changed, 3 deletions(-) diff --git a/addons/GDQuest_GDScript_formatter/install_and_update.gd b/addons/GDQuest_GDScript_formatter/install_and_update.gd index 30e8206..7f95d0f 100644 --- a/addons/GDQuest_GDScript_formatter/install_and_update.gd +++ b/addons/GDQuest_GDScript_formatter/install_and_update.gd @@ -150,7 +150,6 @@ func _get_platform_info() -> Dictionary: func _find_matching_asset(assets: Array, tag: String) -> String: - print(tag) var platform_info := _get_platform_info() if platform_info.is_empty(): return "" @@ -160,8 +159,6 @@ func _find_matching_asset(assets: Array, tag: String) -> String: expected_pattern += ".exe" expected_pattern += ".zip" - print(expected_pattern) - for asset in assets: var asset_name: String = asset["name"] if asset_name == expected_pattern: