Merge pull request #111 from jiaozifs/fix/cannt_delete_def_branch

Fix/cannt delete def branch

Author: TsumikiQAQ

controller/branch_ctl.go

@@ -218,6 +218,11 @@ func (bct BranchController) DeleteBranch(ctx context.Context, w *api.JiaozifsRes
 		return
 	}
 
+	if params.RefName == repository.HEAD {
+		w.BadRequest("can not delete HEAD branch")
+		return
+	}
+
 	workRepo, err := versionmgr.NewWorkRepositoryFromConfig(ctx, operator, repository, bct.Repo, bct.PublicStorageConfig)
 	if err != nil {
 		w.Error(err)

integrationtest/branch_test.go

@@ -256,7 +256,11 @@ func BranchSpec(ctx context.Context, urlStr string) func(c convey.C) {
 				convey.So(err, convey.ShouldBeNil)
 				convey.So(resp.StatusCode, convey.ShouldEqual, http.StatusForbidden)
 			})
-
+			c.Convey("fail to delete default branch", func() {
+				resp, err := client.DeleteBranch(ctx, userName, repoName, &api.DeleteBranchParams{RefName: "main"})
+				convey.So(err, convey.ShouldBeNil)
+				convey.So(resp.StatusCode, convey.ShouldEqual, http.StatusBadRequest)
+			})
 			createWip(ctx, c, client, "creat wip for delete", userName, repoName, "feat/sec_branch")
 			c.Convey("delete branch successful", func() {
 				resp, err := client.DeleteBranch(ctx, userName, repoName, &api.DeleteBranchParams{RefName: "feat/sec_branch"})